mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] platform/x86: oxpec: add OneXPlayer X2 Mini (G3E) DMI entry
@ 2026-11-01  1:26 Jiajun Leng
  2026-11-01  1:35 ` Antheas Kapenekakis
  2026-11-01  2:18 ` [PATCH v2] " Jiajun Leng
  0 siblings, 2 replies; 5+ messages in thread
From: Jiajun Leng @ 2026-11-01  1:26 UTC (permalink / raw)
  To: platform-driver-x86
  Cc: Antheas Kapenekakis, Derek John Clark,
	Joaquín Ignacio Aramendía, Hans de Goede,
	Ilpo Järvinen, linux-kernel, Jiajun Leng

The OneXPlayer X2 Mini (G3E) is the Intel variant and reports DMI board
name "ONEXPLAYER X2Mini". It is not covered by the existing "ONEXPLAYER
X2Mini PRO" entry, which is the AMD board using oxp_fly.

Map it to oxp_g1_i, the profile used by the ONEXPLAYER 3, which has the
same Intel EC layout.

Verified on Bazzite 44 with kernel 7.2.11-ogc4.1.fc44.x86_64: fan
reading, manual PWM and charging control work.

AI assistance: Claude (Anthropic) was used to draft this changelog and the
diff. The submitter reviewed the change, built it as an out-of-tree module
and tested it on the hardware.

Signed-off-by: Jiajun Leng <adolphpi@outlook.com>
---
 drivers/platform/x86/oxpec.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/platform/x86/oxpec.c b/drivers/platform/x86/oxpec.c
index c4c4babe8e30..50d169302fc3 100644
--- a/drivers/platform/x86/oxpec.c
+++ b/drivers/platform/x86/oxpec.c
@@ -230,6 +230,13 @@ static const struct dmi_system_id dmi_table[] = {
 		},
 		.driver_data = (void *)oxp_g1_i,
 	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "ONE-NETBOOK"),
+			DMI_EXACT_MATCH(DMI_BOARD_NAME, "ONEXPLAYER X2Mini"),
+		},
+		.driver_data = (void *)oxp_g1_i,
+	},
 	{
 		.matches = {
 			DMI_MATCH(DMI_BOARD_VENDOR, "ONE-NETBOOK"),
-- 
2.53.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] platform/x86: oxpec: add OneXPlayer X2 Mini (G3E) DMI entry
  2026-11-01  1:26 [PATCH] platform/x86: oxpec: add OneXPlayer X2 Mini (G3E) DMI entry Jiajun Leng
@ 2026-11-01  1:35 ` Antheas Kapenekakis
  2026-11-01  1:37   ` Antheas Kapenekakis
  2026-11-01  2:18 ` [PATCH v2] " Jiajun Leng
  1 sibling, 1 reply; 5+ messages in thread
From: Antheas Kapenekakis @ 2026-11-01  1:35 UTC (permalink / raw)
  To: Jiajun Leng
  Cc: platform-driver-x86, Derek John Clark,
	Joaquín Ignacio Aramendía, Hans de Goede,
	Ilpo Järvinen, linux-kernel

On Sun, 1 Nov 2026 at 02:26, Jiajun Leng <adolphpi@outlook.com> wrote:
>
> The OneXPlayer X2 Mini (G3E) is the Intel variant and reports DMI board
> name "ONEXPLAYER X2Mini".

> It is not covered by the existing "ONEXPLAYER
> X2Mini PRO" entry, which is the AMD board using oxp_fly.

Obviously. Remove.

> Map it to oxp_g1_i, the profile used by the ONEXPLAYER 3, which has the
> same Intel EC layout.

Keep. Move up to the first paragraph.

> Verified on Bazzite 44 with kernel 7.2.11-ogc4.1.fc44.x86_64:

Drop. Broadly speaking we don't care, and I could ask you to test a
mainline kernel now. But it is not necessary.

> reading, manual PWM and charging control work.

Move to the initial paragraph

> AI assistance: Claude (Anthropic) was used to draft this changelog and the
> diff. The submitter reviewed the change, built it as an out-of-tree module
> and tested it on the hardware.

Also drop. if you want to mention you used AI, do it after the
trailer. The assisted-by tag is not used anymore.

> Signed-off-by: Jiajun Leng <adolphpi@outlook.com>
> ---

/\ this is the trailer

Best,
Antheas

>  drivers/platform/x86/oxpec.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/platform/x86/oxpec.c b/drivers/platform/x86/oxpec.c
> index c4c4babe8e30..50d169302fc3 100644
> --- a/drivers/platform/x86/oxpec.c
> +++ b/drivers/platform/x86/oxpec.c
> @@ -230,6 +230,13 @@ static const struct dmi_system_id dmi_table[] = {
>                 },
>                 .driver_data = (void *)oxp_g1_i,
>         },
> +       {
> +               .matches = {
> +                       DMI_MATCH(DMI_BOARD_VENDOR, "ONE-NETBOOK"),
> +                       DMI_EXACT_MATCH(DMI_BOARD_NAME, "ONEXPLAYER X2Mini"),
> +               },
> +               .driver_data = (void *)oxp_g1_i,
> +       },
>         {
>                 .matches = {
>                         DMI_MATCH(DMI_BOARD_VENDOR, "ONE-NETBOOK"),
> --
> 2.53.0
>
>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] platform/x86: oxpec: add OneXPlayer X2 Mini (G3E) DMI entry
  2026-11-01  1:35 ` Antheas Kapenekakis
@ 2026-11-01  1:37   ` Antheas Kapenekakis
  0 siblings, 0 replies; 5+ messages in thread
From: Antheas Kapenekakis @ 2026-11-01  1:37 UTC (permalink / raw)
  To: Jiajun Leng
  Cc: platform-driver-x86, Derek John Clark,
	Joaquín Ignacio Aramendía, Hans de Goede,
	Ilpo Järvinen, linux-kernel

On Sun, 1 Nov 2026 at 02:35, Antheas Kapenekakis <lkml@antheas.dev> wrote:
>
> On Sun, 1 Nov 2026 at 02:26, Jiajun Leng <adolphpi@outlook.com> wrote:
> >
> > The OneXPlayer X2 Mini (G3E) is the Intel variant and reports DMI board
> > name "ONEXPLAYER X2Mini".
>
> > It is not covered by the existing "ONEXPLAYER
> > X2Mini PRO" entry, which is the AMD board using oxp_fly.
>
> Obviously. Remove.
>
> > Map it to oxp_g1_i, the profile used by the ONEXPLAYER 3, which has the
> > same Intel EC layout.
>
> Keep. Move up to the first paragraph.
>
> > Verified on Bazzite 44 with kernel 7.2.11-ogc4.1.fc44.x86_64:
>
> Drop. Broadly speaking we don't care, and I could ask you to test a
> mainline kernel now. But it is not necessary.
>
> > reading, manual PWM and charging control work.
>
> Move to the initial paragraph
>
> > AI assistance: Claude (Anthropic) was used to draft this changelog and the
> > diff. The submitter reviewed the change, built it as an out-of-tree module
> > and tested it on the hardware.
>
> Also drop. if you want to mention you used AI, do it after the
> trailer. The assisted-by tag is not used anymore.
>
> > Signed-off-by: Jiajun Leng <adolphpi@outlook.com>
> > ---
>
> /\ this is the trailer
>
> Best,
> Antheas
>
> >  drivers/platform/x86/oxpec.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/platform/x86/oxpec.c b/drivers/platform/x86/oxpec.c
> > index c4c4babe8e30..50d169302fc3 100644
> > --- a/drivers/platform/x86/oxpec.c
> > +++ b/drivers/platform/x86/oxpec.c
> > @@ -230,6 +230,13 @@ static const struct dmi_system_id dmi_table[] = {
> >                 },
> >                 .driver_data = (void *)oxp_g1_i,
> >         },
> > +       {
> > +               .matches = {
> > +                       DMI_MATCH(DMI_BOARD_VENDOR, "ONE-NETBOOK"),
> > +                       DMI_EXACT_MATCH(DMI_BOARD_NAME, "ONEXPLAYER X2Mini"),
> > +               },
> > +               .driver_data = (void *)oxp_g1_i,
> > +       },

Also, move above X2Mini Pro to adhere to alphabetical sorting.

> >         {
> >                 .matches = {
> >                         DMI_MATCH(DMI_BOARD_VENDOR, "ONE-NETBOOK"),
> > --
> > 2.53.0
> >
> >


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2] platform/x86: oxpec: add OneXPlayer X2 Mini (G3E) DMI entry
  2026-11-01  1:26 [PATCH] platform/x86: oxpec: add OneXPlayer X2 Mini (G3E) DMI entry Jiajun Leng
  2026-11-01  1:35 ` Antheas Kapenekakis
@ 2026-11-01  2:18 ` Jiajun Leng
  2026-11-01  2:24   ` Antheas Kapenekakis
  1 sibling, 1 reply; 5+ messages in thread
From: Jiajun Leng @ 2026-11-01  2:18 UTC (permalink / raw)
  To: platform-driver-x86
  Cc: Antheas Kapenekakis, Derek John Clark,
	Joaquín Ignacio Aramendía, Hans de Goede,
	Ilpo Järvinen, linux-kernel, Jiajun Leng

The OneXPlayer X2 Mini (G3E) is the Intel variant and reports DMI board
name "ONEXPLAYER X2Mini". Map it to oxp_g1_i, the profile used by the
ONEXPLAYER 3, which has the same Intel EC layout. Fan reading, manual PWM
and charging control work.

Signed-off-by: Jiajun Leng <adolphpi@outlook.com>
---
Changes in v2:
- Remove the X2Mini PRO comparison and the downstream kernel version.
- Merge the quirk mapping and test results into the first paragraph.
- Place the entry above ONEXPLAYER X2Mini PRO to keep alphabetical order.
- Move the AI assistance note out of the commit message.

AI assistance: Claude (Anthropic) was used to draft this changelog and the
diff; the submitter reviewed and tested the change.

 drivers/platform/x86/oxpec.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/platform/x86/oxpec.c b/drivers/platform/x86/oxpec.c
index c4c4babe8e30..f4b5a35a4d69 100644
--- a/drivers/platform/x86/oxpec.c
+++ b/drivers/platform/x86/oxpec.c
@@ -300,6 +300,13 @@ static const struct dmi_system_id dmi_table[] = {
 		},
 		.driver_data = (void *)oxp_x1,
 	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "ONE-NETBOOK"),
+			DMI_EXACT_MATCH(DMI_BOARD_NAME, "ONEXPLAYER X2Mini"),
+		},
+		.driver_data = (void *)oxp_g1_i,
+	},
 	{
 		.matches = {
 			DMI_MATCH(DMI_BOARD_VENDOR, "ONE-NETBOOK"),
-- 
2.53.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] platform/x86: oxpec: add OneXPlayer X2 Mini (G3E) DMI entry
  2026-11-01  2:18 ` [PATCH v2] " Jiajun Leng
@ 2026-11-01  2:24   ` Antheas Kapenekakis
  0 siblings, 0 replies; 5+ messages in thread
From: Antheas Kapenekakis @ 2026-11-01  2:24 UTC (permalink / raw)
  To: Jiajun Leng
  Cc: platform-driver-x86, Derek John Clark,
	Joaquín Ignacio Aramendía, Hans de Goede,
	Ilpo Järvinen, linux-kernel

On Sun, 1 Nov 2026 at 03:18, Jiajun Leng <adolphpi@outlook.com> wrote:
>
> The OneXPlayer X2 Mini (G3E) is the Intel variant and reports DMI board
> name "ONEXPLAYER X2Mini". Map it to oxp_g1_i, the profile used by the
> ONEXPLAYER 3, which has the same Intel EC layout. Fan reading, manual PWM
> and charging control work.
>

Reviewed-by: Antheas Kapenekakis <lkml@antheas.dev>

FYI no reply-to next time. You shouldn't chain versions on the same
thread especially for series. If you find out why Claude does that let
us know

Antheas

> Signed-off-by: Jiajun Leng <adolphpi@outlook.com>
> ---
> Changes in v2:
> - Remove the X2Mini PRO comparison and the downstream kernel version.
> - Merge the quirk mapping and test results into the first paragraph.
> - Place the entry above ONEXPLAYER X2Mini PRO to keep alphabetical order.
> - Move the AI assistance note out of the commit message.
>
> AI assistance: Claude (Anthropic) was used to draft this changelog and the
> diff; the submitter reviewed and tested the change.
>
>  drivers/platform/x86/oxpec.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/platform/x86/oxpec.c b/drivers/platform/x86/oxpec.c
> index c4c4babe8e30..f4b5a35a4d69 100644
> --- a/drivers/platform/x86/oxpec.c
> +++ b/drivers/platform/x86/oxpec.c
> @@ -300,6 +300,13 @@ static const struct dmi_system_id dmi_table[] = {
>                 },
>                 .driver_data = (void *)oxp_x1,
>         },
> +       {
> +               .matches = {
> +                       DMI_MATCH(DMI_BOARD_VENDOR, "ONE-NETBOOK"),
> +                       DMI_EXACT_MATCH(DMI_BOARD_NAME, "ONEXPLAYER X2Mini"),
> +               },
> +               .driver_data = (void *)oxp_g1_i,
> +       },
>         {
>                 .matches = {
>                         DMI_MATCH(DMI_BOARD_VENDOR, "ONE-NETBOOK"),
> --
> 2.53.0
>
>


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-11-01  2:24 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-01  1:26 [PATCH] platform/x86: oxpec: add OneXPlayer X2 Mini (G3E) DMI entry Jiajun Leng
2026-11-01  1:35 ` Antheas Kapenekakis
2026-11-01  1:37   ` Antheas Kapenekakis
2026-11-01  2:18 ` [PATCH v2] " Jiajun Leng
2026-11-01  2:24   ` Antheas Kapenekakis

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®