Re: [PATCH] trivial patch to support for "ACPI" keys in pc_keyb.c

Re: [PATCH] trivial patch to support for "ACPI" keys in pc_keyb.c

[Andries.Brouwer]

On Tue, 13 Nov 2001, Pavel Machek wrote:

    > These keys are common on recent keyboards so I'd vote for adding this.

And Zwane Mwaikambo answered and asked:

    Do these keys correspond to the correct ones on your keyboards? I still
    have to come across a keyboard which has these keys but different
    scancodes. But i think i'm beating a dead horse ;)

My collection of scancode data can be found at
	http://www.win.tue.nl/~aeb/linux/kbd/scancodes.html
In particular you see at
	http://www.win.tue.nl/~aeb/linux/kbd/scancodes-1.html#ss1.9
that having power saving keys with scancodes e0 followed by 5e/5f/63
is a Microsoft standard. Every modern keyboard that has power saving keys
has them with these scancodes.

So, I have no real objections against your patch.
(On the other hand, this is an area that is perhaps best regarded as
frozen. Changes just to avoid the trouble of a setkeycodes call
should perhaps be postponed.)

Andries

Re: [PATCH] trivial patch to support for "ACPI" keys in pc_keyb.c

[Zwane Mwaikambo]

On Tue, 13 Nov 2001, Pavel Machek wrote:

> These keys are common on recent keyboards so I'd vote for adding this.
>
> 								Pavel

Do these keys correspond to the correct ones on your keyboards? I still
have to come across a keyboard which has these keys but different
scancodes. But i think i'm beating a dead horse ;)

Regards,
	Zwane Mwaikambo

Re: [PATCH] trivial patch to support for "ACPI" keys in pc_keyb.c

[Pavel Machek]

Hi!

> I know this should normally be done with setkeycodes but it seems pretty
> harmless to have them in pc_keyb.c and doesn't stomp (i think) on any of
> the other entries. I have these keys on both my BTC keyboards and some
> noname brand keyboards too and they seem to correspond to the proper keys.

These keys are common on recent keyboards so I'd vote for adding this.

								Pavel
-- 
Philips Velo 1: 1"x4"x8", 300gram, 60, 12MB, 40bogomips, linux, mutt,
details at http://atrey.karlin.mff.cuni.cz/~pavel/velo/index.html.

[PATCH] trivial patch to support for "ACPI" keys in pc_keyb.c

[Zwane Mwaikambo]

I know this should normally be done with setkeycodes but it seems pretty
harmless to have them in pc_keyb.c and doesn't stomp (i think) on any of
the other entries. I have these keys on both my BTC keyboards and some
noname brand keyboards too and they seem to correspond to the proper keys.

Diffed against 2.4.13-ac7 but i think it should apply cleanly to newer
kernels.

Regards,
	Zwane Mwaikambo

--- pc_keyb.c.orig	Sat Nov 10 19:22:08 2001
+++ pc_keyb.c	Sat Nov 10 19:50:29 2001
@@ -207,6 +207,10 @@

 /* BTC */
 #define E0_MACRO   112
+#define E0_PWROFF  113
+#define E0_SLEEP   114
+#define E0_WKUP    115
+
 /* LK450 */
 #define E0_F13     113
 #define E0_F14     114
@@ -241,8 +245,8 @@
   E0_DO, E0_F17, 0, 0, 0, 0, E0_BREAK, E0_HOME,	      /* 0x40-0x47 */
   E0_UP, E0_PGUP, 0, E0_LEFT, E0_OK, E0_RIGHT, E0_KPMINPLUS, E0_END,/* 0x48-0x4f */
   E0_DOWN, E0_PGDN, E0_INS, E0_DEL, 0, 0, 0, 0,	      /* 0x50-0x57 */
-  0, 0, 0, E0_MSLW, E0_MSRW, E0_MSTM, 0, 0,	      /* 0x58-0x5f */
-  0, 0, 0, 0, 0, 0, 0, 0,			      /* 0x60-0x67 */
+  0, 0, 0, E0_MSLW, E0_MSRW, E0_MSTM, E0_PWROFF, E0_SLEEP, /* 0x58-0x5f */
+  0, 0, 0, E0_WKUP, 0, 0, 0, 0,			      /* 0x60-0x67 */
   0, 0, 0, 0, 0, 0, 0, E0_MACRO,		      /* 0x68-0x6f */
   0, 0, 0, 0, 0, 0, 0, 0,			      /* 0x70-0x77 */
   0, 0, 0, 0, 0, 0, 0, 0			      /* 0x78-0x7f */