mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andries.Brouwer@cwi.nl
To: alan@lxorguk.ukuu.org.uk, andre@suse.com, linux-kernel@vger.kernel.org
Subject: [PATCH] unclip large disks
Date: Tue, 12 Feb 2002 01:02:54 GMT	[thread overview]
Message-ID: <UTC200202120102.BAA1073277.aeb@cwi.nl> (raw)

The purpose of CONFIG_IDEDISK_STROKE is to make the setmax
utility superfluous. However, I find that unclipping large
disks fails because idedisk_read_native_max_address_ext()
is called before probe_lba_addressing(), which means that
drive->addressing is not yet set, and the high order part
of the disk size is not read.
Thus, probe_lba_addressing() should be moved up in ide-disk.c,
for example

@@ -1323,6 +1318,8 @@
        if (id == NULL)
                return;

+       (void) probe_lba_addressing(drive, 1);
+
        /*
         * CompactFlash cards and their brethern look just like hard drives
         * to us, but they are removable and don't have a doorlock mechanism.
@@ -1414,7 +1411,6 @@
        drive->no_io_32bit = id->dword_io ? 1 : 0;
        if (drive->id->cfs_enable_2 & 0x3000)
                write_cache(drive, (id->cfs_enable_2 & 0x3000));
-       (void) probe_lba_addressing(drive, 1);
 }

 static int idedisk_cleanup (ide_drive_t *drive)

[your line numbers may differ]

Andries

[this was for some variant on linux-2.4.18-pre7-ac3,
but no doubt a similar patch applies to all kernels
with IDE patch]

                 reply	other threads:[~2002-02-12  1:04 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=UTC200202120102.BAA1073277.aeb@cwi.nl \
    --to=andries.brouwer@cwi.nl \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=andre@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®