mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] unclip large disks
@ 2002-02-12  1:02 Andries.Brouwer
  0 siblings, 0 replies; only message in thread
From: Andries.Brouwer @ 2002-02-12  1:02 UTC (permalink / raw)
  To: alan, andre, linux-kernel

The purpose of CONFIG_IDEDISK_STROKE is to make the setmax
utility superfluous. However, I find that unclipping large
disks fails because idedisk_read_native_max_address_ext()
is called before probe_lba_addressing(), which means that
drive->addressing is not yet set, and the high order part
of the disk size is not read.
Thus, probe_lba_addressing() should be moved up in ide-disk.c,
for example

@@ -1323,6 +1318,8 @@
        if (id == NULL)
                return;

+       (void) probe_lba_addressing(drive, 1);
+
        /*
         * CompactFlash cards and their brethern look just like hard drives
         * to us, but they are removable and don't have a doorlock mechanism.
@@ -1414,7 +1411,6 @@
        drive->no_io_32bit = id->dword_io ? 1 : 0;
        if (drive->id->cfs_enable_2 & 0x3000)
                write_cache(drive, (id->cfs_enable_2 & 0x3000));
-       (void) probe_lba_addressing(drive, 1);
 }

 static int idedisk_cleanup (ide_drive_t *drive)

[your line numbers may differ]

Andries

[this was for some variant on linux-2.4.18-pre7-ac3,
but no doubt a similar patch applies to all kernels
with IDE patch]

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2002-02-12  1:04 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-02-12  1:02 [PATCH] unclip large disks Andries.Brouwer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®