* Re: LVM/Device mapper breaks with -mm (was: Re: 2.5.66-mm1)
@ 2003-03-28 8:30 Andries.Brouwer
0 siblings, 0 replies; 11+ messages in thread
From: Andries.Brouwer @ 2003-03-28 8:30 UTC (permalink / raw)
To: Andries.Brouwer, davej; +Cc: Joel.Becker, erik, linux-kernel
From: Dave Jones <davej@codemonkey.org.uk>
> For example, struct umsdos_ioctl has twice dev_t followed
> by padding. Probably these should become unsigned longs.
> I'll send a patch later tonight.
>
> Is it used anywhere? That requires detective work.
> It is used by the utilities udosctl (a useless demo utility),
> umssync and umssetup. I do not know of any others.
> No doubt people will tell me what I overlooked.
> Less conservative people will tell me that umsdos has to
> be killed entirely.
Isn't it still horribly broken ? I remember Al putting it on
the "To be fixed later" burner, but never saw anything happen
to it after that asides from janitor style fixes.
Yes, umsdos is victim of bitrot.
Al broke it with his patch called MA37-break-umsdos-C3-pre3.
Afterwards people doing global changes failed to do them on
umsdos, so the amount of work required to get umsdos in the
shape it was before (working, but with races and other problems)
increases in time.
I failed to cc the list on the patch referred to above.
It is rather useless since umsdos is broken, but at least
prevents increased bitrot. Let me include it here.
Andries
diff -u --recursive --new-file -X /linux/dontdiff a/include/linux/umsdos_fs.h b/include/linux/umsdos_fs.h
--- a/include/linux/umsdos_fs.h Fri Nov 22 22:40:12 2002
+++ b/include/linux/umsdos_fs.h Wed Mar 26 22:31:14 2003
@@ -49,7 +49,7 @@
# else
# define Printk(x)
# endif
-#endif
+#endif /* __KERNEL__ */
struct umsdos_fake_info {
@@ -70,8 +70,7 @@
time_t atime; /* Access time */
time_t mtime; /* Last modification time */
time_t ctime; /* Creation time */
- dev_t rdev; /* major and minor number of a device */
- /* special file */
+ unsigned short rdev; /* major and minor of a device special file */
umode_t mode; /* Standard UNIX permissions bits + type of */
char spare[12]; /* unused bytes for future extensions */
/* file, see linux/stat.h */
@@ -129,34 +128,32 @@
struct umsdos_ioctl {
struct dirent dos_dirent;
struct umsdos_dirent umsdos_dirent;
- /* The following structure is used to exchange some data
- * with utilities (umsdos_progs/util/umsdosio.c). The first
- * releases were using struct stat from "sys/stat.h". This was
- * causing some problem for cross compilation of the kernel
- * Since I am not really using the structure stat, but only some field
- * of it, I have decided to replicate the structure here
- * for compatibility with the binaries out there
+ /* The following structure is used to exchange some data with
+ * utilities (umsdos_progs/util/umsdosio.c). The first releases
+ * were using struct stat from "sys/stat.h". This was causing
+ * some problem for cross compilation of the kernel.
+ * Since I am not really using the structure stat, but only
+ * some fields of it, I have decided to replicate the structure
+ * here for compatibility with the binaries out there.
* FIXME PTW 1998, this has probably changed
*/
struct {
- dev_t st_dev;
- unsigned short __pad1;
- ino_t st_ino;
- umode_t st_mode;
+ unsigned long st_dev;
+ ino_t st_ino; /* used */
+ umode_t st_mode; /* used */
nlink_t st_nlink;
__kernel_uid_t st_uid;
__kernel_gid_t st_gid;
- dev_t st_rdev;
- unsigned short __pad2;
- off_t st_size;
+ unsigned long st_rdev;
+ off_t st_size; /* used */
unsigned long st_blksize;
unsigned long st_blocks;
- time_t st_atime;
+ time_t st_atime; /* used */
unsigned long __unused1;
- time_t st_mtime;
+ time_t st_mtime; /* used */
unsigned long __unused2;
- time_t st_ctime;
+ time_t st_ctime; /* used */
unsigned long __unused3;
uid_t st_uid32;
gid_t st_gid32;
[all fields without comment /* used */ might just as well
be called dummy; in particular, only the size of st_dev,
st_rdev matters, the value is not used]
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: LVM/Device mapper breaks with -mm (was: Re: 2.5.66-mm1)
@ 2003-03-26 13:21 Shane Shrybman
0 siblings, 0 replies; 11+ messages in thread
From: Shane Shrybman @ 2003-03-26 13:21 UTC (permalink / raw)
To: linux-kernel
Hi,
Andrew Morton (akpm@digeo.com) wrote:
>
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.5/2.5.66/2.5.66-mm1/
LVM or device mapper seems to be broken in -mm. I've only tried the
following kernels so far:
2.5.64 - works
2.5.65-mm2 - doesn't work
2.5.66 - works
2.5.66-mm1 - doesn't work
Just another data point. LVM in -mm stopped working for me at
2.5.65-mm2, it did work in 2.5.65-mm1. 2.5.65-mm[234] did not work
either.
Regards,
Shane
^ permalink raw reply [flat|nested] 11+ messages in thread
* 2.5.66-mm1
@ 2003-03-26 9:38 Andrew Morton
2003-03-26 12:26 ` LVM/Device mapper breaks with -mm (was: Re: 2.5.66-mm1) Erik Hensema
0 siblings, 1 reply; 11+ messages in thread
From: Andrew Morton @ 2003-03-26 9:38 UTC (permalink / raw)
To: linux-kernel, linux-mm
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.5/2.5.66/2.5.66-mm1/
. The anticipatory scheduler is in wrapup mode now. It is pretty much in
its final form.
. The ext2 locking changes have been significantly redone.
The per-blockgroup data structures had to go. For a 4TB filesystem we
cannot even kmalloc that many pointers, let alone data structures.
So the per-blockgroup spinlocking has been replaced with hashed
spinlocking and the per-blockgroup accounting has been removed. A "per-cpu
counter" thing has been invented to amortise the locking cost of the
filesystem-wide counters.
. ext3 is now using spinlocking in its block allocator rather than a
filesystem-wide semaphore.
It is stability-tested but I have not yet performance tested this
closely. It does appear to have improved the context switch problem (and
the file fragmentation problem which the context switch problem causes).
But there's a way to go here.
Changes since 2.5.65-mm4:
linus.patch
Latest -bk
-nfsd-32-bit-dev_t-fixes.patch
-i2c-fix.patch
Merged
+kgdb-ga.patch
George Anzinger's gdb stub
+ppa-null-pointer-fix.patch
Might fix the parport scsi driver
+initcall-debug.patch
Debugging support for misbehaving initcalls
+posix-timers-64-bit-fix.patch
Timer fix for 64-bit machines
+slab-off-by-one-fix.patch
Slab was using too much memory.
+install_page-flush_cache_page.patch
Cache coherency bug in remap_file_pages()
+as-minor-tweaks.patch
+as-remove-stats.patch
Anticipaory scheduler tuning and clanups.
+posix-timer-double-expiration-fix.patch
Posix timers were sending timer expiry info twice.
+hugh-01-no-SWAP_ERROR.patch
+hugh-02-try_to_unmap-CONFIG_SWAP.patch
+hugh-03-add_to_swap_cache.patch
+hugh-04-page_convert_anon-ENOMEM.patch
+hugh-05-page_convert_anon-unlocking.patch
+hugh-06-wrap-below-vm_start.patch
+hugh-07-objrmap-page_table_lock.patch
+hugh-08-rmap-comments.patch
+hugh-09-tmpfs-truncation.patch
+hugh-10-tmpfs-atomics.patch
+hugh-11-fix-unuse_pmd-fixme.patch
+hugh-12-vm_enough_memory-double-counts.patch
Various vm/mm fixes and cleanups
+ext3-max-file-size-fix.patch
Allow ext3 to create files larger than 32GB (should be nearly 2TB)
-ext2-no-lock_super.patch
-ext2-ialloc-no-lock_super.patch
+ext2-no-lock_super-ng.patch
+ext2-ialloc-no-lock_super-ng.patch
Rework the ext2 block and inode allocator locking changes.
+dev_t-remove-B_FREE.patch
Remove B_FREE.
+tty_io-cleanup.patch
+page_to_pfn-in-blk_queue_bounce.patch
+init_inode_once-bloat-fix.patch
Cleanups and fixlets
+compound-page-warning-fix.patch
Fix a warning
+slab-cache-sizes-cleanup.patch
Unduplicate some tables in slab.
+stat_t-larger-dev_t.patch
Large dev_t fix.
+acpi-build-fix.patch
make acpi compile.
+sync_blockdev-on-final-close.patch
Only write out blockdev mappings on the final close.
+ext3-concurrent-block-inode-allocation.patch
+ext3-concurrent-block-allocation-fix-1.patch
Use spinlocking in the ext3 block allocator, not as fs-wide semaphore.
All 104 patches:
linus.patch
mm.patch
add -mmN to EXTRAVERSION
kgdb-ga.patch
kgdb stub for ia32 (George Anzinger's one)
ppa-null-pointer-fix.patch
initcall-debug.patch
initcall debugging support
posix-timers-64-bit-fix.patch
POSIX timers interface long/int cleanup
slab-off-by-one-fix.patch
slab: fix off-by-one in size calculation
config_spinline.patch
uninline spinlocks for profiling accuracy.
ppc64-reloc_hide.patch
ppc64-pci-patch.patch
Subject: pci patch
ppc64-aio-32bit-emulation.patch
32/64bit emulation for aio
ppc64-scruffiness.patch
Fix some PPC64 compile warnings
sym-do-160.patch
make the SYM driver do 160 MB/sec
install_page-flush_cache_page.patch
add flush_cache_page() to install_page()
config-PAGE_OFFSET.patch
Configurable kenrel/user memory split
ptrace-flush.patch
cache flushing in the ptrace code
buffer-debug.patch
buffer.c debugging
warn-null-wakeup.patch
ext3-truncate-ordered-pages.patch
ext3: explicitly free truncated pages
reiserfs_file_write-5.patch
rcu-stats.patch
RCU statistics reporting
ext3-journalled-data-assertion-fix.patch
Remove incorrect assertion from ext3
nfs-speedup.patch
nfs-oom-fix.patch
nfs oom fix
sk-allocation.patch
Subject: Re: nfs oom
nfs-more-oom-fix.patch
rpciod-atomic-allocations.patch
Make rcpiod use atomic allocations
linux-isp.patch
isp-update-1.patch
kblockd.patch
Create `kblockd' workqueue
as-iosched.patch
anticipatory I/O scheduler
as-np-reads-1.patch
AS: read-vs-read fixes
as-np-reads-2.patch
AS: more read-vs-read fixes
as-predict-data-direction.patch
as: predict direction of next IO
as-remove-frontmerge.patch
AS: remove frontmerge tunable
as-misc-cleanups.patch
AS: misc cleanups
as-minor-tweaks.patch
AS: tuning and tweaks
as-remove-stats.patch
AS: remove statistics
cfq-2.patch
CFQ scheduler, #2
unplug-use-kblockd.patch
Use kblockd for running request queues
fremap-all-mappings.patch
Make all executable mappings be nonlinear
objrmap-2.5.62-5.patch
object-based rmap
sched-2.5.64-D3.patch
sched-2.5.64-D3, more interactivity changes
scheduler-tunables.patch
scheduler tunables
show_task-free-stack-fix.patch
show_task() fix and cleanup
yellowfin-set_bit-fix.patch
yellowfin driver set_bit fix
htree-nfs-fix.patch
Fix ext3 htree / NFS compatibility problems
task_prio-fix.patch
simple task_prio() fix
slab_store_user-large-objects.patch
slab debug: perform redzoning against larger objects
pcmcia-2.patch
pcmcia-3b.patch
pcmcia-3.patch
pcmcia-4.patch
pcmcia-5.patch
pcmcia-6.patch
pcmcia-7b.patch
pcmcia-7.patch
pcmcia-8.patch
pcmcia-9.patch
pcmcia-10.patch
htree-nfs-fix-2.patch
htree nfs fix
posix-timer-double-expiration-fix.patch
posix timers: fix double-reporting of timer expiration
hugh-01-no-SWAP_ERROR.patch
swap 01/13 no SWAP_ERROR
hugh-02-try_to_unmap-CONFIG_SWAP.patch
Subject: [PATCH] swap 02/13 !CONFIG_SWAP try_to_unmap
hugh-03-add_to_swap_cache.patch
swap 03/13 add_to_swap_cache
hugh-04-page_convert_anon-ENOMEM.patch
swap 04/13 page_convert_anon -ENOMEM
hugh-05-page_convert_anon-unlocking.patch
swap 05/13 page_convert_anon unlocking
hugh-06-wrap-below-vm_start.patch
swap 06/13 wrap below vm_start
hugh-07-objrmap-page_table_lock.patch
swap 07/13 objrmap page_table_lock
hugh-08-rmap-comments.patch
swap 08/13 rmap comments
hugh-09-tmpfs-truncation.patch
swap 09/13 tmpfs truncation
hugh-10-tmpfs-atomics.patch
swap 10/13 tmpfs atomics
hugh-11-fix-unuse_pmd-fixme.patch
swap 11/13 fix unuse_pmd fixme
hugh-12-vm_enough_memory-double-counts.patch
swap 12/13 vm_enough_memory double counts
ext3-max-file-size-fix.patch
ext3: fix max file size
ext2-no-lock_super-ng.patch
ext2-ialloc-no-lock_super-ng.patch
linear-oops-fix-1.patch
md/linear oops fix
dev_t-32-bit.patch
[for playing only] change type of dev_t
dev_t-remove-B_FREE.patch
dev_t: eliminate B_FREE
dev_t-drm-warnings.patch
dev_t: fix drm printk warnings
sg-dev_t-fix.patch
32-bit dev_t fix for sg
oops-dump-preceding-code.patch
i386 oops output: dump preceding code
x86-clock-override-option.patch
x86 clock override boot option
tty_io-cleanup.patch
tty_io cleanup
page_to_pfn-in-blk_queue_bounce.patch
Subject: use page_to_pfn() in __blk_queue_bounce()
init_inode_once-bloat-fix.patch
Subject: init_inode_once() wants sizeof(struct hlist_head)
conntrack-use-after-free-fix.patch
fix use-after-free in ip_conntrack
VM_DONTEXPAND-fix.patch
honour VM_DONTEXPAND in vma merging
compound-page-warning-fix.patch
Fix 64bit warnings in mm/page_alloc.c
cdevname-irq-safety-fix.patch
make cdevname() callable from interrupts
register_chrdev_region-leak-fix.patch
register_chrdev_region() leak and race fix
slab-cache-sizes-cleanup.patch
slab: cache sizes cleanup
stat_t-larger-dev_t.patch
struct stat - support larger dev_t
acpi-build-fix.patch
ACPI build fix
sync_blockdev-on-final-close.patch
sync blockdevs on the final close only
ext3_mark_inode_dirty-speedup.patch
ext3_mark_inode_dirty() speedup
ext3_mark_inode_dirty-less-calls.patch
ext3_commit_write speedup
ext3-handle-cache.patch
ext3: create a slab cache for transaction handles
ext3-no-bkl.patch
journal_dirty_metadata-speedup.patch
journal_get_write_access-speedup.patch
ext3-concurrent-block-inode-allocation.patch
Subject: [PATCH] concurrent block/inode allocation for EXT3
ext3-concurrent-block-allocation-fix-1.patch
^ permalink raw reply [flat|nested] 11+ messages in thread
* LVM/Device mapper breaks with -mm (was: Re: 2.5.66-mm1)
2003-03-26 9:38 2.5.66-mm1 Andrew Morton
@ 2003-03-26 12:26 ` Erik Hensema
2003-03-26 13:48 ` Andries Brouwer
0 siblings, 1 reply; 11+ messages in thread
From: Erik Hensema @ 2003-03-26 12:26 UTC (permalink / raw)
To: linux-kernel
Andrew Morton (akpm@digeo.com) wrote:
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.5/2.5.66/2.5.66-mm1/
LVM or device mapper seems to be broken in -mm. I've only tried the
following kernels so far:
2.5.64 - works
2.5.65-mm2 - doesn't work
2.5.66 - works
2.5.66-mm1 - doesn't work
I'm getting these messages while setting up LVM from my bootscripts (I've
included the actual commands prefixed with a > ):
Remounting root file system (/) read/write for vgscan...
> mount -n -o remount,rw /
Removing old device inodes...
> rm /dev/system/* /dev/mapper/*
Setting up devices...
> /usr/local/sbin/devmap_mknod.sh
Creating /dev/mapper/control character device with major:10 minor:63.
Scanning for LVM volume groups...
> /usr/local/sbin/vgscan
Reading all physical volumes. This may take a while...
Found volume group "system" using metadata type lvm1
Activating LVM volume groups...
> /usr/local/sbin/vgchange -a y system
device-mapper: allocating minor 0.
device-mapper: allocating minor 1.
device-mapper: destroying md
device-mapper: destroying table
device-mapper: allocating minor 0.
device-mapper: destroying md
device-mapper: destroying table
1 logical volume(s) in volume group "system" now active
The only active volume is the most recently created volume.
On 2.5.6x-vanilla the output of vgchange is:
device-mapper: allocating minor 0.
device-mapper: allocating minor 1.
device-mapper: allocating minor 2.
3 logical volume(s) in volume group "system" now active
--
Erik Hensema <erik@hensema.net>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: LVM/Device mapper breaks with -mm (was: Re: 2.5.66-mm1)
2003-03-26 12:26 ` LVM/Device mapper breaks with -mm (was: Re: 2.5.66-mm1) Erik Hensema
@ 2003-03-26 13:48 ` Andries Brouwer
2003-03-26 14:33 ` Erik Hensema
0 siblings, 1 reply; 11+ messages in thread
From: Andries Brouwer @ 2003-03-26 13:48 UTC (permalink / raw)
To: erik; +Cc: linux-kernel
On Wed, Mar 26, 2003 at 12:26:37PM +0000, Erik Hensema wrote:
> Andrew Morton (akpm@digeo.com) wrote:
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.5/2.5.66/2.5.66-mm1/
> LVM or device mapper seems to be broken in -mm. I've only tried the
> following kernels so far:
> 2.5.64 - works
> 2.5.65-mm2 - doesn't work
> 2.5.66 - works
> 2.5.66-mm1 - doesn't work
Probably you are hit by
dev_t-32-bit.patch
[for playing only] change type of dev_t
This is hidden somewhat in the 100+ patches in -mm,
but the kernel is not quite ready yet - that is
why this is labeled "not to be applied, for
playing only". Mostly things work, but some stuff
related to lvm, md, dm, nfs, loop will break
because ioctls use structs with a dev_t field.
You can revert this single patch and probably all will be fine.
More interesting would be to apply
http://marc.theaimsgroup.com/?l=linux-kernel&m=103956089203199&w=3
if possible, and see whether that helps.
You can see some earlier discussion today under a subject
containing the word dm_ioctl.
Andries
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: LVM/Device mapper breaks with -mm (was: Re: 2.5.66-mm1)
2003-03-26 13:48 ` Andries Brouwer
@ 2003-03-26 14:33 ` Erik Hensema
2003-03-26 16:03 ` Andries Brouwer
0 siblings, 1 reply; 11+ messages in thread
From: Erik Hensema @ 2003-03-26 14:33 UTC (permalink / raw)
To: linux-kernel
Andries Brouwer (aebr@win.tue.nl) wrote:
> On Wed, Mar 26, 2003 at 12:26:37PM +0000, Erik Hensema wrote:
>> Andrew Morton (akpm@digeo.com) wrote:
>> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.5/2.5.66/2.5.66-mm1/
>
>> LVM or device mapper seems to be broken in -mm. I've only tried the
>> following kernels so far:
>> 2.5.64 - works
>> 2.5.65-mm2 - doesn't work
>> 2.5.66 - works
>> 2.5.66-mm1 - doesn't work
>
> Probably you are hit by
>
> dev_t-32-bit.patch
> [for playing only] change type of dev_t
[...]
> You can revert this single patch and probably all will be fine.
For now I've reverted this patch and LVM is working again.
> More interesting would be to apply
>
> http://marc.theaimsgroup.com/?l=linux-kernel&m=103956089203199&w=3
I'd rather not change the ioctl interface, since that would make dual
booting with 2.5-vanilla harder.
--
Erik Hensema <erik@hensema.net>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: LVM/Device mapper breaks with -mm (was: Re: 2.5.66-mm1)
2003-03-26 14:33 ` Erik Hensema
@ 2003-03-26 16:03 ` Andries Brouwer
2003-03-26 17:43 ` Joe Thornber
2003-03-26 18:47 ` Joel Becker
0 siblings, 2 replies; 11+ messages in thread
From: Andries Brouwer @ 2003-03-26 16:03 UTC (permalink / raw)
To: Erik Hensema; +Cc: linux-kernel
On Wed, Mar 26, 2003 at 03:33:26PM +0100, Erik Hensema wrote:
> > You can revert this single patch and probably all will be fine.
>
> For now I've reverted this patch and LVM is working again.
Good.
> > More interesting would be to apply
> >
> > http://marc.theaimsgroup.com/?l=linux-kernel&m=103956089203199&w=3
>
> I'd rather not change the ioctl interface, since that would make dual
> booting with 2.5-vanilla harder.
The ioctl has a version field:
struct dm_ioctl {
uint32_t version[3];
...
and the above patch changes version 1.6.0 into 2.0.0.
With sufficiently recent user space utilities all
should work: they can find out the interface version
using the DM_VERSION ioctl, and then adapt what
they send to the kernel.
(I don't know whether such up-to-date utilities exist.)
Andries
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: LVM/Device mapper breaks with -mm (was: Re: 2.5.66-mm1)
2003-03-26 16:03 ` Andries Brouwer
@ 2003-03-26 17:43 ` Joe Thornber
2003-03-26 18:47 ` Joel Becker
1 sibling, 0 replies; 11+ messages in thread
From: Joe Thornber @ 2003-03-26 17:43 UTC (permalink / raw)
To: Andries Brouwer; +Cc: Erik Hensema, linux-kernel
On Wednesday, March 26, 2003, at 04:03 PM, Andries Brouwer wrote:
> (I don't know whether such up-to-date utilities exist.)
Alasdair Kergon should be making a new release of the dm utilities in
the next couple of days. Once this has been done we will be free to
fix the broken ioctl interface in 2.5.
- Joe
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: LVM/Device mapper breaks with -mm (was: Re: 2.5.66-mm1)
2003-03-26 16:03 ` Andries Brouwer
2003-03-26 17:43 ` Joe Thornber
@ 2003-03-26 18:47 ` Joel Becker
2003-03-26 20:52 ` Andries Brouwer
1 sibling, 1 reply; 11+ messages in thread
From: Joel Becker @ 2003-03-26 18:47 UTC (permalink / raw)
To: Andries Brouwer; +Cc: Erik Hensema, linux-kernel
On Wed, Mar 26, 2003 at 05:03:50PM +0100, Andries Brouwer wrote:
> With sufficiently recent user space utilities all
> should work: they can find out the interface version
> using the DM_VERSION ioctl, and then adapt what
> they send to the kernel.
We need to start tracking down what userspace needs fixing
still. We also should iron out our representations. eg, hpa's
recommendation for 64bits, or the 12/20 split for 32bit, or etc.
Joel
--
Life's Little Instruction Book #451
"Don't be afraid to say, 'I'm sorry.'"
Joel Becker
Senior Member of Technical Staff
Oracle Corporation
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: LVM/Device mapper breaks with -mm (was: Re: 2.5.66-mm1)
2003-03-26 18:47 ` Joel Becker
@ 2003-03-26 20:52 ` Andries Brouwer
2003-03-26 21:12 ` Joel Becker
2003-03-28 2:08 ` Dave Jones
0 siblings, 2 replies; 11+ messages in thread
From: Andries Brouwer @ 2003-03-26 20:52 UTC (permalink / raw)
To: Joel Becker; +Cc: Erik Hensema, linux-kernel
On Wed, Mar 26, 2003 at 10:47:23AM -0800, Joel Becker wrote:
> We need to start tracking down what userspace needs fixing.
My current series of patches is for the ioctls that use a
structure with dev_t field. If someone has time to burn,
or has automated tools that can identify these, that would
be good.
There is a double audit: find these ioctls, and then find
the userspace tools that use them.
For example, struct umsdos_ioctl has twice dev_t followed
by padding. Probably these should become unsigned longs.
I'll send a patch later tonight.
Is it used anywhere? That requires detective work.
It is used by the utilities udosctl (a useless demo utility),
umssync and umssetup. I do not know of any others.
No doubt people will tell me what I overlooked.
Less conservative people will tell me that umsdos has to
be killed entirely.
In old posts and other letters I have mentioned some more ioctls.
The list is not long but they have to be examined one by one,
and in some cases correspondence with authors/maintainers
is required.
> We also should iron out our representations. eg, hpa's
> recommendation for 64bits, or the 12/20 split for 32bit, or etc.
There is no hurry. These changes are just editing a few lines
in kdev_t.h. I tend to prefer 64 bits, like hpa.
Maybe I should send another patch tonight, just for playing.
Andries
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: LVM/Device mapper breaks with -mm (was: Re: 2.5.66-mm1)
2003-03-26 20:52 ` Andries Brouwer
@ 2003-03-26 21:12 ` Joel Becker
2003-03-28 2:08 ` Dave Jones
1 sibling, 0 replies; 11+ messages in thread
From: Joel Becker @ 2003-03-26 21:12 UTC (permalink / raw)
To: Andries Brouwer; +Cc: Erik Hensema, linux-kernel
On Wed, Mar 26, 2003 at 09:52:28PM +0100, Andries Brouwer wrote:
> > We also should iron out our representations. eg, hpa's
> > recommendation for 64bits, or the 12/20 split for 32bit, or etc.
>
> There is no hurry. These changes are just editing a few lines
> in kdev_t.h. I tend to prefer 64 bits, like hpa.
> Maybe I should send another patch tonight, just for playing.
Please, I'd like that. It does actually matter, because glibc
and mknod (to name a couple) have to pass a proper dev_t for the new
format (glibc actually does an explicit conversion to 8:8 in
sysdeps/sysv/linux/xmkmod.c, which we need to fix to the proper
mapping).
Stuff like that.
Joel
--
"This is the end, beautiful friend.
This is the end, my only friend the end
Of our elaborate plans, the end
Of everything that stands, the end
No safety or surprise, the end
I'll never look into your eyes again."
Joel Becker
Senior Member of Technical Staff
Oracle Corporation
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: LVM/Device mapper breaks with -mm (was: Re: 2.5.66-mm1)
2003-03-26 20:52 ` Andries Brouwer
2003-03-26 21:12 ` Joel Becker
@ 2003-03-28 2:08 ` Dave Jones
1 sibling, 0 replies; 11+ messages in thread
From: Dave Jones @ 2003-03-28 2:08 UTC (permalink / raw)
To: Andries Brouwer; +Cc: Joel Becker, Erik Hensema, linux-kernel
On Wed, Mar 26, 2003 at 09:52:28PM +0100, Andries Brouwer wrote:
> For example, struct umsdos_ioctl has twice dev_t followed
> by padding. Probably these should become unsigned longs.
> I'll send a patch later tonight.
>
> Is it used anywhere? That requires detective work.
> It is used by the utilities udosctl (a useless demo utility),
> umssync and umssetup. I do not know of any others.
> No doubt people will tell me what I overlooked.
> Less conservative people will tell me that umsdos has to
> be killed entirely.
Isn't it still horribly broken ? I remember Al putting it on
the "To be fixed later" burner, but never saw anything happen
to it after that asides from janitor style fixes.
Dave
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2003-03-28 8:19 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-03-28 8:30 LVM/Device mapper breaks with -mm (was: Re: 2.5.66-mm1) Andries.Brouwer
-- strict thread matches above, loose matches on Subject: below --
2003-03-26 13:21 Shane Shrybman
2003-03-26 9:38 2.5.66-mm1 Andrew Morton
2003-03-26 12:26 ` LVM/Device mapper breaks with -mm (was: Re: 2.5.66-mm1) Erik Hensema
2003-03-26 13:48 ` Andries Brouwer
2003-03-26 14:33 ` Erik Hensema
2003-03-26 16:03 ` Andries Brouwer
2003-03-26 17:43 ` Joe Thornber
2003-03-26 18:47 ` Joel Becker
2003-03-26 20:52 ` Andries Brouwer
2003-03-26 21:12 ` Joel Becker
2003-03-28 2:08 ` Dave Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®