mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marco Scardovi <scardracs@disroot.org>
To: "Denis Benato" <denis.benato@linux.dev>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Liang Haowen" <nbg2974@gmail.com>
Cc: linux-leds@vger.kernel.org, Lee Jones <lee@kernel.org>,
	Pavel Machek <pavel@kernel.org>,
	"Martin K.  Petersen" <mkp@kernel.org>,
	linux-scsi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org, Armin Wolf <W_Armin@gmx.de>,
	Hans de Goede <hansg@kernel.org>,
	"Derek J.  Clark" <derekjohn.clark@gmail.com>,
	Ahmed Yaseen <yaseen@ghoul.dev>
Subject: Re: [RFC v7 0/1] leds: asus-aura-scsi: Add ASUS Aura RGB LED driver for ROG NVMe enclosures
Date: Wed, 23 Sep 2026 17:11:24 +0200	[thread overview]
Message-ID: <UuqOxFagT_OBL0l5ZYtfKg@disroot.org> (raw)
In-Reply-To: <202609240122.ReplyDenis.lhw@gmail.com>

In data mercoledì 23 settembre 2026 14:59:36 Ora legale dell’Europa centrale, 
Liang Haowen ha scritto:
> Hi Denis,
> 
> Thanks for the context.
> 
> I have read Marco's Dynamic Lighting class series (PR #17). The
> direct frame and palette interfaces map cleanly onto what the Arion
> needs: its colour tables are just small RGB frames, and the
> enclosure firmware effects map onto the class effect controls. I
> will coordinate with him on using it for the LED side, on top of
> the verified SCSI handling this series carries.
> 
> On the open review items: the next revision will isolate the DMA
> buffer into its own cacheline (a real issue on non-coherent
> architectures, as the bot notes), and I will take the time to get
> the full pass right instead of rushing again.

Hi everyone,

as for now please consider the new interface as a far from done one: it has
basic functions and works good on my laptop but, that means it is tested
only on my device using kernel 7.2.y. If you have time and want to test it
out/give feedbacks they are more than welcomed (tbh I've yet to address
these given by @Dereck due to personal reasons but I promise I'll work
on them too asap).

@Liang if you look into it there is a basic version of SCSI for your device
using the new interface: if you want to look at it feel free to do so/suggest
changes: I'll probably drop it in a future rebase to make the patchset
smaller (then again I'll have to do countless threads here in lore for leds, 
hid, wmi, etc etc etc so it will take months).

Best regards,
Marco




  reply	other threads:[~2026-09-23 15:11 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-23 10:30 Liang Haowen
2026-09-23 10:30 ` [RFC v7 1/1] " Liang Haowen
2026-09-23 10:45   ` Lee Jones
2026-09-23 11:19     ` Liang Haowen
2026-09-23 10:41 ` [RFC v7 0/1] " Ilpo Järvinen
2026-09-23 12:35   ` Denis Benato
2026-09-23 12:59     ` Liang Haowen
2026-09-23 15:11       ` Marco Scardovi [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-09-01 14:26 [PATCH RFC 0/1] leds: add ASUS Aura SCSI " Liang Haowen
2026-09-01 14:34 ` [PATCH RFC 1/1] " Liang Haowen
2026-09-03 12:00   ` [PATCH RFC v2 1/1] leds: asus-aura-scsi: Add ASUS Aura RGB LED " Liang Haowen
     [not found]     ` <20260903161357.GX2133376@google.com>
2026-09-04 12:30       ` [PATCH RFC v3 0/1] " Liang Haowen
2026-09-04 12:30         ` [PATCH RFC v3 1/1] " Liang Haowen
     [not found]           ` <20260904131503.355C41F00A3E@smtp.kernel.org>
     [not found]             ` <20260910093232.GO2133376@google.com>
2026-09-15 12:48               ` [PATCH RFC v4 0/1] " Liang Haowen
2026-09-15 12:49                 ` [PATCH RFC v4 1/1] " Liang Haowen
     [not found]                   ` <20260915130050.E8CDB1F000FF@smtp.kernel.org>
     [not found]                     ` <20260916104305.GM11487@google.com>
2026-09-16 12:15                       ` [PATCH RFC v5 0/1] " Liang Haowen
2026-09-16 12:15                         ` [PATCH RFC v5 1/1] " Liang Haowen
     [not found]                           ` <20260916122740.921E51F000FF@smtp.kernel.org>
     [not found]                             ` <20260916130602.GS11487@google.com>
2026-09-16 14:22                               ` [PATCH RFC v6 0/1] " Liang Haowen
2026-09-16 14:22                                 ` [PATCH RFC v6 1/1] " Liang Haowen
     [not found]                                   ` <20260916143832.520721F000FF@smtp.kernel.org>
     [not found]                                     ` <20260917112840.GJ1605367@google.com>
2026-09-17 11:49                                       ` Liang Haowen
2026-09-23  9:45                                   ` Lee Jones
2026-09-23 10:18                                     ` Liang Haowen
     [not found]                                       ` <20260923102812.2353292-1-nbg2974@gmail.com>
2026-09-23 10:12                                   ` Ilpo Järvinen
2026-09-16 14:23                               ` [PATCH RFC v5 " Liang Haowen
2026-09-16 12:15                       ` [PATCH RFC v4 " Liang Haowen
2026-09-15 12:49               ` [PATCH RFC v3 " Liang Haowen
2026-09-03 12:00   ` [PATCH RFC v2 0/1] " Liang Haowen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=UuqOxFagT_OBL0l5ZYtfKg@disroot.org \
    --to=scardracs@disroot.org \
    --cc=W_Armin@gmx.de \
    --cc=denis.benato@linux.dev \
    --cc=derekjohn.clark@gmail.com \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mkp@kernel.org \
    --cc=nbg2974@gmail.com \
    --cc=pavel@kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=yaseen@ghoul.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®