From: Greg KH <gregkh@linuxfoundation.org>
To: Joe Perches <joe@perches.com>
Cc: Tiezhu Yang <yangtiezhu@loongson.cn>,
Andrew Morton <akpm@linux-foundation.org>,
Andy Whitcroft <apw@canonical.com>,
Sasha Levin <sashal@kernel.org>,
linux-kernel@vger.kernel.org, Xuefeng Li <lixuefeng@loongson.cn>
Subject: Re: [PATCH RESEND] checkpatch: Do not check git commit description style when backport the upstream commit
Date: Wed, 25 Nov 2020 08:17:52 +0100 [thread overview]
Message-ID: <X74FIJqhOgRrEGYv@kroah.com> (raw)
In-Reply-To: <a102bb51a8ebde2e22d9527fb00a2c1f64c6e69f.camel@perches.com>
On Tue, Nov 24, 2020 at 08:24:15PM -0800, Joe Perches wrote:
> On Wed, 2020-11-25 at 12:08 +0800, Tiezhu Yang wrote:
> > On 11/25/2020 11:51 AM, Joe Perches wrote:
> > > On Wed, 2020-11-25 at 11:35 +0800, Tiezhu Yang wrote:
> > > > When backport the upstream commit to the internal LTS kernel version,
> > > > we usually use the following description [1] [2]:
> > > >
> > > > [ Upstream commit cc6528bc9a0c901c83b8220a2e2617f3354d6dd9 ]
> > > > or
> > > > commit c51f8f88d705e06bd696d7510aff22b33eb8e638 upstream.
> > > Internal to what?
> > >
> > > If it's your own internal build system, I think you should
> > > keep your own local patch to checkpatch.
> > >
> > > I don't see why the kernel version should accept it.
> > >
> > > Is this style used by anyone else?
> >
> > AFAIK, this style is only used in the stable tree, for example:
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-5.9.y&id=c68a9ca7ca33f1020cca97e4e935c2154bec37c7
>
> Greg?/Sasha?
>
> https://lore.kernel.org/lkml/995e0acb-c219-ea00-f078-7582516e25de@loongson.cn/T/#m2f3d87bd985bf3d4d7b63f1fa4f0490baa01119b
>
> Is this in your scripts?
My scripts put this into a patch when applying it to the stable tree,
and so do Sasha's. I don't know why checkpatch would care about this as
that's not used for this workflow at all.
> Is this something you want/use?
I wouldn't use it, and I doubt anyone else would.
thanks,
greg k-h
prev parent reply other threads:[~2020-11-25 7:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 3:35 Tiezhu Yang
2020-11-25 3:51 ` Joe Perches
2020-11-25 4:08 ` Tiezhu Yang
2020-11-25 4:22 ` Joe Perches
2020-11-25 4:24 ` Joe Perches
2020-11-25 7:17 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X74FIJqhOgRrEGYv@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=sashal@kernel.org \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®