* [PATCH] drm: bridge: dw-hdmi: Remove redundant null check before clk_disable_unprepare
@ 2020-11-27 9:23 Xu Wang
2020-12-20 18:05 ` Laurent Pinchart
0 siblings, 1 reply; 2+ messages in thread
From: Xu Wang @ 2020-11-27 9:23 UTC (permalink / raw)
To: a.hajda, narmstrong, Laurent.pinchart, jonas, jernej.skrabec,
airlied, daniel, sam, boris.brezillon, victor.liu
Cc: dri-devel, linux-kernel
Because clk_disable_unprepare() already checked NULL clock parameter,
so the additional check is unnecessary, just remove them.
Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
index 0c79a9ba48bb..dda4fa9a1a08 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
@@ -3440,8 +3440,7 @@ struct dw_hdmi *dw_hdmi_probe(struct platform_device *pdev,
err_iahb:
clk_disable_unprepare(hdmi->iahb_clk);
- if (hdmi->cec_clk)
- clk_disable_unprepare(hdmi->cec_clk);
+ clk_disable_unprepare(hdmi->cec_clk);
err_isfr:
clk_disable_unprepare(hdmi->isfr_clk);
err_res:
@@ -3465,8 +3464,7 @@ void dw_hdmi_remove(struct dw_hdmi *hdmi)
clk_disable_unprepare(hdmi->iahb_clk);
clk_disable_unprepare(hdmi->isfr_clk);
- if (hdmi->cec_clk)
- clk_disable_unprepare(hdmi->cec_clk);
+ clk_disable_unprepare(hdmi->cec_clk);
if (hdmi->i2c)
i2c_del_adapter(&hdmi->i2c->adap);
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drm: bridge: dw-hdmi: Remove redundant null check before clk_disable_unprepare
2020-11-27 9:23 [PATCH] drm: bridge: dw-hdmi: Remove redundant null check before clk_disable_unprepare Xu Wang
@ 2020-12-20 18:05 ` Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2020-12-20 18:05 UTC (permalink / raw)
To: Xu Wang
Cc: a.hajda, narmstrong, jonas, jernej.skrabec, airlied, daniel, sam,
boris.brezillon, victor.liu, dri-devel, linux-kernel
Hi Xu Wang,
Thank you for the patch.
On Fri, Nov 27, 2020 at 09:23:32AM +0000, Xu Wang wrote:
> Because clk_disable_unprepare() already checked NULL clock parameter,
> so the additional check is unnecessary, just remove them.
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> index 0c79a9ba48bb..dda4fa9a1a08 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> @@ -3440,8 +3440,7 @@ struct dw_hdmi *dw_hdmi_probe(struct platform_device *pdev,
>
> err_iahb:
> clk_disable_unprepare(hdmi->iahb_clk);
> - if (hdmi->cec_clk)
> - clk_disable_unprepare(hdmi->cec_clk);
> + clk_disable_unprepare(hdmi->cec_clk);
> err_isfr:
> clk_disable_unprepare(hdmi->isfr_clk);
> err_res:
> @@ -3465,8 +3464,7 @@ void dw_hdmi_remove(struct dw_hdmi *hdmi)
>
> clk_disable_unprepare(hdmi->iahb_clk);
> clk_disable_unprepare(hdmi->isfr_clk);
> - if (hdmi->cec_clk)
> - clk_disable_unprepare(hdmi->cec_clk);
> + clk_disable_unprepare(hdmi->cec_clk);
>
> if (hdmi->i2c)
> i2c_del_adapter(&hdmi->i2c->adap);
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-20 18:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-27 9:23 [PATCH] drm: bridge: dw-hdmi: Remove redundant null check before clk_disable_unprepare Xu Wang
2020-12-20 18:05 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome