* [PATCH] ath10k: Remove redundant assignment to changed_flags
@ 2023-02-07 5:24 Jiapeng Chong
2023-02-07 17:25 ` Simon Horman
2023-02-22 10:04 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Jiapeng Chong @ 2023-02-07 5:24 UTC (permalink / raw)
To: kvalo
Cc: davem, edumazet, kuba, pabeni, ath10k, linux-wireless, netdev,
linux-kernel, Jiapeng Chong, Abaci Robot
Variable changed_flags is assigned, but is not effectively used, so
delete it.
drivers/net/wireless/ath/ath10k/mac.c:6024:22: warning: parameter 'changed_flags' set but not used.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3963
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/net/wireless/ath/ath10k/mac.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index ec8d5b29bc72..7675858f069b 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -6030,7 +6030,6 @@ static void ath10k_configure_filter(struct ieee80211_hw *hw,
mutex_lock(&ar->conf_mutex);
- changed_flags &= SUPPORTED_FILTERS;
*total_flags &= SUPPORTED_FILTERS;
ar->filter_flags = *total_flags;
--
2.20.1.7.g153144c
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ath10k: Remove redundant assignment to changed_flags
2023-02-07 5:24 [PATCH] ath10k: Remove redundant assignment to changed_flags Jiapeng Chong
@ 2023-02-07 17:25 ` Simon Horman
2023-02-22 10:04 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2023-02-07 17:25 UTC (permalink / raw)
To: Jiapeng Chong
Cc: kvalo, davem, edumazet, kuba, pabeni, ath10k, linux-wireless,
netdev, linux-kernel, Abaci Robot
On Tue, Feb 07, 2023 at 01:24:10PM +0800, Jiapeng Chong wrote:
> Variable changed_flags is assigned, but is not effectively used, so
> delete it.
>
> drivers/net/wireless/ath/ath10k/mac.c:6024:22: warning: parameter 'changed_flags' set but not used.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3963
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ath10k: Remove redundant assignment to changed_flags
2023-02-07 5:24 [PATCH] ath10k: Remove redundant assignment to changed_flags Jiapeng Chong
2023-02-07 17:25 ` Simon Horman
@ 2023-02-22 10:04 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2023-02-22 10:04 UTC (permalink / raw)
To: Jiapeng Chong
Cc: davem, edumazet, kuba, pabeni, ath10k, linux-wireless, netdev,
linux-kernel, Jiapeng Chong, Abaci Robot
Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote:
> Variable changed_flags is assigned, but is not effectively used, so
> delete it.
>
> drivers/net/wireless/ath/ath10k/mac.c:6024:22: warning: parameter 'changed_flags' set but not used.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3963
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> Reviewed-by: Simon Horman <simon.horman@corigine.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Patch applied to ath-next branch of ath.git, thanks.
7c4c511f74ba wifi: ath10k: Remove redundant assignment to changed_flags
--
https://patchwork.kernel.org/project/linux-wireless/patch/20230207052410.26337-1-jiapeng.chong@linux.alibaba.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-22 10:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-07 5:24 [PATCH] ath10k: Remove redundant assignment to changed_flags Jiapeng Chong
2023-02-07 17:25 ` Simon Horman
2023-02-22 10:04 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®