From: Borislav Petkov <bp@alien8.de>
To: Tony Luck <tony.luck@intel.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] RAS: Fix the trace_show() function to output trace_count
Date: Mon, 17 Oct 2022 12:36:16 +0200 [thread overview]
Message-ID: <Y00wIFEN9h9YPGe1@zn.tnic> (raw)
In-Reply-To: <20221005194644.311204-1-tony.luck@intel.com>
On Wed, Oct 05, 2022 at 12:46:44PM -0700, Tony Luck wrote:
> static int trace_show(struct seq_file *m, void *v)
> {
> - return atomic_read(&trace_count);
> + seq_printf(m, "%d\n", atomic_read(&trace_count));
Still misleading:
$ cat /sys/kernel/debug/ras/daemon_active
1
and it is 1 and not 0 because:
[ 13.177644] trace_open: trace_count: 1, comm: cat
[ 13.178675] trace_release: trace_count: 0, comm: cat
we toggle trace_count when we read it.
I don't know, maybe we should teach RAS daemons to ->write() into that
file their name and PID so that the trace_count counts *only* the RAS
daemons not any reader...
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2022-10-17 10:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 16:16 [PATCH] " Tony Luck
2022-10-05 18:17 ` Borislav Petkov
2022-10-05 19:46 ` [PATCH v2] " Tony Luck
2022-10-17 10:36 ` Borislav Petkov [this message]
2022-10-17 16:09 ` Luck, Tony
2022-10-17 19:40 ` Borislav Petkov
2022-10-18 14:36 ` Tony Luck
2022-10-18 16:05 ` Borislav Petkov
2022-10-18 16:59 ` [PATCH v3] RAS: Fix return value from show_trace() Tony Luck
2022-10-31 18:15 ` [tip: ras/core] " tip-bot2 for Tony Luck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y00wIFEN9h9YPGe1@zn.tnic \
--to=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®