From: Borislav Petkov <bp@alien8.de>
To: Tony Luck <tony.luck@intel.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RAS: Fix the trace_show() function to output trace_count
Date: Wed, 5 Oct 2022 20:17:07 +0200 [thread overview]
Message-ID: <Yz3KI5qY70rvJV63@zn.tnic> (raw)
In-Reply-To: <20221005161645.309068-1-tony.luck@intel.com>
On Wed, Oct 05, 2022 at 09:16:45AM -0700, Tony Luck wrote:
> The /sys/kernel/debug/ras/daemon_active is used to indicate to some
> kernel code whether there is a user mode consumer of RAS trace events
> to decide whether to print to the console.
>
> The intent was that reading daemon_active would give the same indication
> to users. But the code is broken and does not display anything.
Huh, looking at that Fixes commit, it says:
"One can track which daemon opens it via "lsof
/path/to/debugfs/ras/daemon_active"."
# lsof /sys/kernel/debug/ras/daemon_active
COMMAND PID USER FD TYPE DEVICE SIZE/OFF NODE NAME
tail 13339 root 3r REG 0,6 0 27 /sys/kernel/debug/ras/daemon_active
So it works as advertized I'd say.
> Add a seq_printf() to output the current value of the trace_count.
Now, if you want to cat that file, that's a different story.
:-)
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2022-10-05 18:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 16:16 Tony Luck
2022-10-05 18:17 ` Borislav Petkov [this message]
2022-10-05 19:46 ` [PATCH v2] " Tony Luck
2022-10-17 10:36 ` Borislav Petkov
2022-10-17 16:09 ` Luck, Tony
2022-10-17 19:40 ` Borislav Petkov
2022-10-18 14:36 ` Tony Luck
2022-10-18 16:05 ` Borislav Petkov
2022-10-18 16:59 ` [PATCH v3] RAS: Fix return value from show_trace() Tony Luck
2022-10-31 18:15 ` [tip: ras/core] " tip-bot2 for Tony Luck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yz3KI5qY70rvJV63@zn.tnic \
--to=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®