From: Nathan Chancellor <nathan@kernel.org>
To: Miguel Ojeda <ojeda@kernel.org>
Cc: Andrey Konovalov <andreyknvl@gmail.com>,
Marco Elver <elver@google.com>, Kees Cook <keescook@chromium.org>,
Arnd Bergmann <arnd@arndb.de>,
Andrew Morton <akpm@linux-foundation.org>,
Kumar Kartikeya Dwivedi <memxor@gmail.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Uros Bizjak <ubizjak@gmail.com>,
Dan Li <ashimida@linux.alibaba.com>,
Alexander Potapenko <glider@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] compiler-gcc: remove attribute support check for `__no_sanitize_address__`
Date: Fri, 21 Oct 2022 14:18:12 -0700 [thread overview]
Message-ID: <Y1MMlE3A2Gdw599+@dev-arch.thelio-3990X> (raw)
In-Reply-To: <20221021115956.9947-2-ojeda@kernel.org>
On Fri, Oct 21, 2022 at 01:59:53PM +0200, Miguel Ojeda wrote:
> The attribute was added in GCC 4.8, while the minimum GCC version
> supported by the kernel is GCC 5.1.
>
> Therefore, remove the check.
>
> Link: https://godbolt.org/z/84v56vcn8
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
> include/linux/compiler-gcc.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
> index b9530d3515ac..bfce7f4d0978 100644
> --- a/include/linux/compiler-gcc.h
> +++ b/include/linux/compiler-gcc.h
> @@ -82,11 +82,7 @@
> #define __noscs __attribute__((__no_sanitize__("shadow-call-stack")))
> #endif
>
> -#if __has_attribute(__no_sanitize_address__)
> #define __no_sanitize_address __attribute__((__no_sanitize_address__))
> -#else
> -#define __no_sanitize_address
> -#endif
>
> #if defined(__SANITIZE_THREAD__) && __has_attribute(__no_sanitize_thread__)
> #define __no_sanitize_thread __attribute__((__no_sanitize_thread__))
> --
> 2.38.1
>
>
next prev parent reply other threads:[~2022-10-21 21:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 11:59 [PATCH 1/5] compiler-gcc: be consistent with underscores use for `no_sanitize` Miguel Ojeda
2022-10-21 11:59 ` [PATCH 2/5] compiler-gcc: remove attribute support check for `__no_sanitize_address__` Miguel Ojeda
2022-10-21 16:11 ` Kees Cook
2022-10-21 21:18 ` Nathan Chancellor [this message]
2022-10-21 11:59 ` [PATCH 3/5] compiler-gcc: remove attribute support check for `__no_sanitize_thread__` Miguel Ojeda
2022-10-21 14:55 ` Marco Elver
2022-10-21 16:11 ` Kees Cook
2022-10-21 21:18 ` Nathan Chancellor
2022-10-21 11:59 ` [PATCH 4/5] compiler-gcc: remove attribute support check for `__no_sanitize_undefined__` Miguel Ojeda
2022-10-21 16:11 ` Kees Cook
2022-10-21 21:19 ` Nathan Chancellor
2022-10-21 11:59 ` [PATCH 5/5] compiler-gcc: document minimum version for `__no_sanitize_coverage__` Miguel Ojeda
2022-10-21 14:55 ` Marco Elver
2022-10-21 16:11 ` Kees Cook
2022-10-21 21:20 ` Nathan Chancellor
2022-10-21 16:11 ` [PATCH 1/5] compiler-gcc: be consistent with underscores use for `no_sanitize` Kees Cook
2022-10-21 21:17 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1MMlE3A2Gdw599+@dev-arch.thelio-3990X \
--to=nathan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=arnd@arndb.de \
--cc=ashimida@linux.alibaba.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=memxor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=ojeda@kernel.org \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®