* [PATCH] staging: iio: frequency: ad9834: Use div64_ul instead of do_div
@ 2022-10-27 21:47 Deepak R Varma
2022-10-28 10:11 ` Sa, Nuno
0 siblings, 1 reply; 2+ messages in thread
From: Deepak R Varma @ 2022-10-27 21:47 UTC (permalink / raw)
To: Lars-Peter Clausen, Michael Hennerich, Jonathan Cameron,
Greg Kroah-Hartman, linux-iio, linux-staging, linux-kernel
do_div() does a 64-by-32 division. Here the divisor is an unsigned long
which on some platforms is 64 bit wide. So use div64_ul instead of do_div
to avoid a possible truncation. Issue identified using the
coccicheck tool.
Signed-off-by: Deepak R Varma <drv@mailo.com>
---
drivers/staging/iio/frequency/ad9834.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/iio/frequency/ad9834.c b/drivers/staging/iio/frequency/ad9834.c
index 285df0e489a6..3917a76e7976 100644
--- a/drivers/staging/iio/frequency/ad9834.c
+++ b/drivers/staging/iio/frequency/ad9834.c
@@ -102,8 +102,7 @@ static unsigned int ad9834_calc_freqreg(unsigned long mclk, unsigned long fout)
{
unsigned long long freqreg = (u64)fout * (u64)BIT(AD9834_FREQ_BITS);
- do_div(freqreg, mclk);
- return freqreg;
+ return div64_ul(freqreg, mclk);
}
static int ad9834_write_frequency(struct ad9834_state *st,
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread* RE: [PATCH] staging: iio: frequency: ad9834: Use div64_ul instead of do_div
2022-10-27 21:47 [PATCH] staging: iio: frequency: ad9834: Use div64_ul instead of do_div Deepak R Varma
@ 2022-10-28 10:11 ` Sa, Nuno
0 siblings, 0 replies; 2+ messages in thread
From: Sa, Nuno @ 2022-10-28 10:11 UTC (permalink / raw)
To: Deepak R Varma, Lars-Peter Clausen, Hennerich, Michael,
Jonathan Cameron, Greg Kroah-Hartman, linux-iio, linux-staging,
linux-kernel
> -----Original Message-----
> From: Deepak R Varma <drv@mailo.com>
> Sent: Thursday, October 27, 2022 11:48 PM
> To: Lars-Peter Clausen <lars@metafoo.de>; Hennerich, Michael
> <Michael.Hennerich@analog.com>; Jonathan Cameron <jic23@kernel.org>;
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>; linux-
> iio@vger.kernel.org; linux-staging@lists.linux.dev; linux-
> kernel@vger.kernel.org
> Subject: [PATCH] staging: iio: frequency: ad9834: Use div64_ul instead of
> do_div
>
> [External]
>
> do_div() does a 64-by-32 division. Here the divisor is an unsigned long
> which on some platforms is 64 bit wide. So use div64_ul instead of do_div
> to avoid a possible truncation. Issue identified using the
> coccicheck tool.
>
> Signed-off-by: Deepak R Varma <drv@mailo.com>
> ---
Reviewed-by: Nuno Sá <nuno.sa@analog.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-28 10:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-27 21:47 [PATCH] staging: iio: frequency: ad9834: Use div64_ul instead of do_div Deepak R Varma
2022-10-28 10:11 ` Sa, Nuno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®