From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <chao@kernel.org>
Cc: Yangtao Li <frank.li@vivo.com>,
linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] f2fs: fix to f2fs_handle_critical_error when errors=remount-ro
Date: Thu, 27 Oct 2022 20:17:54 -0700 [thread overview]
Message-ID: <Y1tJ4uKBa0ItHCBw@google.com> (raw)
In-Reply-To: <85b6be9b-5c5b-ace0-8084-4bd52ef64996@kernel.org>
On 10/28, Chao Yu wrote:
> On 2022/10/28 10:33, Yangtao Li wrote:
> > > It won't pollute global namespace since it's a static function just be used in f2fs/super.c...
> >
> > emm, I think it would be nice to see the f2fs_record_error_work symbol
> > in the stack, it can be explicitly a function of f2fs. personal opinion for reference only.
>
> Oh, yes, let me update in original patch as well.
Chao,
It seems there're multiple bugs. Please apply this as well.
https://lore.kernel.org/linux-f2fs-devel/20221027180416.3786792-1-jaegeuk@kernel.org/T/#u
>
> >
> > > Do you mind letting me merge these two patches into original patch?
> > > since original patch is still in dev branch, rather than mainline.
> >
> > Glad to see, if resend.
>
> Thanks, :)
>
> >
> > > I guess it needs to stop ckpt thread as well...
> >
> > agree, :)
> >
> > Thanks,
next prev parent reply other threads:[~2022-10-28 3:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 12:08 [PATCH 1/3] f2fs: rename flush_error_work() to f2fs_record_error_work() Yangtao Li
2022-10-27 12:08 ` [PATCH 2/3] f2fs: export f2fs_stop_flush_thread() for external use Yangtao Li
2022-10-27 12:08 ` [PATCH 3/3] f2fs: fix to f2fs_handle_critical_error when errors=remount-ro Yangtao Li
2022-10-27 13:31 ` Chao Yu
2022-10-28 2:33 ` Yangtao Li
2022-10-28 2:43 ` Chao Yu
2022-10-28 3:17 ` Jaegeuk Kim [this message]
2022-10-28 3:38 ` Chao Yu
2022-10-27 13:24 ` [PATCH 1/3] f2fs: rename flush_error_work() to f2fs_record_error_work() Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1tJ4uKBa0ItHCBw@google.com \
--to=jaegeuk@kernel.org \
--cc=chao@kernel.org \
--cc=frank.li@vivo.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®