From: Chao Yu <chao@kernel.org>
To: Yangtao Li <frank.li@vivo.com>, jaegeuk@kernel.org
Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] f2fs: fix to f2fs_handle_critical_error when errors=remount-ro
Date: Thu, 27 Oct 2022 21:31:05 +0800 [thread overview]
Message-ID: <ab2f3576-bedd-8c27-5549-f9ff5462aee3@kernel.org> (raw)
In-Reply-To: <20221027120807.6337-3-frank.li@vivo.com>
On 2022/10/27 20:08, Yangtao Li wrote:
> When a fatal error occurs in the file system and it is
> remounted to ro mode, the flush thread needs to be stopped.
>
> Fixes: d81ab30e85a5 ("f2fs: support errors=remount-ro|continue|panic mountoption")
Do you mind letting me merge these two patches into original patch?
since original patch is still in dev branch, rather than mainline.
I guess it needs to stop ckpt thread as well...
Thanks,
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> ---
> fs/f2fs/super.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index fc220b5c5599..3a1238a82dc9 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -4017,6 +4017,7 @@ void f2fs_handle_critical_error(struct f2fs_sb_info *sbi, unsigned char reason,
>
> f2fs_stop_gc_thread(sbi);
> f2fs_stop_discard_thread(sbi);
> + f2fs_stop_flush_thread(sbi);
> }
>
> static void f2fs_record_error_work(struct work_struct *work)
next prev parent reply other threads:[~2022-10-27 13:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 12:08 [PATCH 1/3] f2fs: rename flush_error_work() to f2fs_record_error_work() Yangtao Li
2022-10-27 12:08 ` [PATCH 2/3] f2fs: export f2fs_stop_flush_thread() for external use Yangtao Li
2022-10-27 12:08 ` [PATCH 3/3] f2fs: fix to f2fs_handle_critical_error when errors=remount-ro Yangtao Li
2022-10-27 13:31 ` Chao Yu [this message]
2022-10-28 2:33 ` Yangtao Li
2022-10-28 2:43 ` Chao Yu
2022-10-28 3:17 ` Jaegeuk Kim
2022-10-28 3:38 ` Chao Yu
2022-10-27 13:24 ` [PATCH 1/3] f2fs: rename flush_error_work() to f2fs_record_error_work() Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab2f3576-bedd-8c27-5549-f9ff5462aee3@kernel.org \
--to=chao@kernel.org \
--cc=frank.li@vivo.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®