From: Mark Brown <broonie@kernel.org>
To: Juan Alfonso Reyes Ajenjo <jareyes@gmv.com>
Cc: "Liam Girdwood" <lgirdwood@gmail.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"\"Martin Povišer\"" <povik+lin@cutebit.org>,
"Charles Keepax" <ckeepax@opensource.cirrus.com>,
"Fabio Estevam" <festevam@denx.de>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Gustavo Plaza Roma" <gplaza@gmv.com>
Subject: Re: [PATCH] Fix tas2562 volume table values
Date: Thu, 3 Nov 2022 13:24:00 +0000 [thread overview]
Message-ID: <Y2PA8Bo59YDKvlRG@sirena.org.uk> (raw)
In-Reply-To: <VI1PR07MB5839C95198DD090316E87B78BA389@VI1PR07MB5839.eurprd07.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 1243 bytes --]
On Thu, Nov 03, 2022 at 01:03:01PM +0000, Juan Alfonso Reyes Ajenjo wrote:
> This patch fixes -90dB value (0x84a3 instead of 0x695b)
> This patch adds missing -20dB value (0x06666666)
> float_vol_db_lookup must have 56 values as volume is from 0 to 55 (0-110dB)
>
> Signed-off-by: Juan Alfonso Reyes Ajenjo jareyes@gmv.com<mailto:jareyes@gmv.com>
> Signed-off-by: Gustavo Plaza Roma gplaza@gmv.com<mailto:gplaza@gmv.com>
It looks like this got mangled a bit by your mail client - the signoffs
are rather confused and...
> static const unsigned int float_vol_db_lookup[] = {
> 0x00000d43, 0x000010b2, 0x00001505, 0x00001a67, 0x00002151,
> 0x000029f1, 0x000034cd, 0x00004279, 0x000053af, 0x0000695b,
> -0x0000695b, 0x0000a6fa, 0x0000d236, 0x000108a4, 0x00014d2a,
> +0x000084a3, 0x0000a6fa, 0x0000d236, 0x000108a4, 0x00014d2a,
> 0x0001a36e, 0x00021008, 0x000298c0, 0x000344df, 0x00041d8f,
...there's what looks like a lot of whitespace damage which means the
tooling won't be able to understand it. I usually recommend git
send-email for sending patches, it will avoid most issues.
Also I'd expect Juan's signoff to be last if it's him sending the patch
(possibly Gustavo should be a Co-developed-by or something?).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next parent reply other threads:[~2022-11-03 13:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <VI1PR07MB5839C95198DD090316E87B78BA389@VI1PR07MB5839.eurprd07.prod.outlook.com>
2022-11-03 13:24 ` Mark Brown [this message]
[not found] ` <VI1PR07MB583938C86519E34431A248F2BA389@VI1PR07MB5839.eurprd07.prod.outlook.com>
2022-11-03 14:28 ` Mark Brown
2022-11-05 9:39 Juan Alfonso Reyes Ajenjo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2PA8Bo59YDKvlRG@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=festevam@denx.de \
--cc=gplaza@gmv.com \
--cc=jareyes@gmv.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=povik+lin@cutebit.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome