Re: [PATCH] Fix tas2562 volume table values

Re: [PATCH] Fix tas2562 volume table values

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 1243 bytes --]

On Thu, Nov 03, 2022 at 01:03:01PM +0000, Juan Alfonso Reyes Ajenjo wrote:
> This patch fixes -90dB value (0x84a3 instead of 0x695b)
> This patch adds missing -20dB value (0x06666666)
> float_vol_db_lookup must have 56 values as volume is from 0 to 55 (0-110dB)
> 
> Signed-off-by: Juan Alfonso Reyes Ajenjo jareyes@gmv.com<mailto:jareyes@gmv.com>
> Signed-off-by: Gustavo Plaza Roma gplaza@gmv.com<mailto:gplaza@gmv.com>

It looks like this got mangled a bit by your mail client - the signoffs
are rather confused and...

> static const unsigned int float_vol_db_lookup[] = {
> 0x00000d43, 0x000010b2, 0x00001505, 0x00001a67, 0x00002151,
> 0x000029f1, 0x000034cd, 0x00004279, 0x000053af, 0x0000695b,
> -0x0000695b, 0x0000a6fa, 0x0000d236, 0x000108a4, 0x00014d2a,
> +0x000084a3, 0x0000a6fa, 0x0000d236, 0x000108a4, 0x00014d2a,
> 0x0001a36e, 0x00021008, 0x000298c0, 0x000344df, 0x00041d8f,

...there's what looks like a lot of whitespace damage which means the
tooling won't be able to understand it.  I usually recommend git
send-email for sending patches, it will avoid most issues.

Also I'd expect Juan's signoff to be last if it's him sending the patch
(possibly Gustavo should be a Co-developed-by or something?).

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] Fix tas2562 volume table values

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 390 bytes --]

On Thu, Nov 03, 2022 at 02:22:52PM +0000, Juan Alfonso Reyes Ajenjo wrote:
> Sorry,
> maybe outlook is doing some weird things. I will try again with send-email as suggested.

Yeah, I'm not sure Outlook is able to cope with sending patches without
mangling things - I'm not aware of anyone using it successfully.  The
nearest it gets is sending as an attachment but that's really not good.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[PATCH] Fix tas2562 volume table values

[Juan Alfonso Reyes Ajenjo]

This patch fixes -90dB value (0x84a3 instead of 0x695b)
This patch adds missing -20dB value (0x06666666)
float_vol_db_lookup must have 56 values as volume is from 0 to 55 (0-110dB)

Co-developed-by: Gustavo Plaza Roma <gplazar03@gmail.com>
Signed-off-by: Gustavo Plaza Roma <gplazar03@gmail.com>
Signed-off-by: Juan Alfonso Reyes Ajenjo <juanalfonso.reyes@gmail.com>
---
 sound/soc/codecs/tas2562.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/sound/soc/codecs/tas2562.c b/sound/soc/codecs/tas2562.c
index b486d0b..acbdf77 100644
--- a/sound/soc/codecs/tas2562.c
+++ b/sound/soc/codecs/tas2562.c
@@ -33,15 +33,16 @@
 static const unsigned int float_vol_db_lookup[] = {
 0x00000d43, 0x000010b2, 0x00001505, 0x00001a67, 0x00002151,
 0x000029f1, 0x000034cd, 0x00004279, 0x000053af, 0x0000695b,
-0x0000695b, 0x0000a6fa, 0x0000d236, 0x000108a4, 0x00014d2a,
+0x000084a3, 0x0000a6fa, 0x0000d236, 0x000108a4, 0x00014d2a,
 0x0001a36e, 0x00021008, 0x000298c0, 0x000344df, 0x00041d8f,
 0x00052e5a, 0x000685c8, 0x00083621, 0x000a566d, 0x000d03a7,
 0x0010624d, 0x0014a050, 0x0019f786, 0x0020b0bc, 0x0029279d,
 0x0033cf8d, 0x004139d3, 0x00521d50, 0x00676044, 0x0082248a,
 0x00a3d70a, 0x00ce4328, 0x0103ab3d, 0x0146e75d, 0x019b8c27,
 0x02061b89, 0x028c423f, 0x03352529, 0x0409c2b0, 0x05156d68,
-0x080e9f96, 0x0a24b062, 0x0cc509ab, 0x10137987, 0x143d1362,
-0x197a967f, 0x2013739e, 0x28619ae9, 0x32d64617, 0x40000000
+0x06666666, 0x080e9f96, 0x0a24b062, 0x0cc509ab, 0x10137987,
+0x143d1362, 0x197a967f, 0x2013739e, 0x28619ae9, 0x32d64617,
+0x40000000
 };
 
 struct tas2562_data {
-- 
2.7.4