* [PATCH 0/4] r8a779g0: add TMU support
@ 2022-11-03 20:55 Wolfram Sang
2022-11-03 20:55 ` [PATCH 1/4] clk: renesas: r8a779g0: Add TMU and SASYNCRT clocks Wolfram Sang
` (3 more replies)
0 siblings, 4 replies; 11+ messages in thread
From: Wolfram Sang @ 2022-11-03 20:55 UTC (permalink / raw)
To: linux-renesas-soc; +Cc: Wolfram Sang, devicetree, linux-clk, linux-kernel
Here are the clk and DTS changes to enable TMU timers on the R-Car V4H
based WhiteHawk board. Tested with the 'clocksource-switch' selftest.
Nothing special, very similar to S4-8. Happy hacking!
Wolfram Sang (4):
clk: renesas: r8a779g0: Add TMU and SASYNCRT clocks
arm64: dts: renesas: r8a779g0: Add TMU nodes
arm64: dts: renesas: white-hawk-cpu: sort RWDT entry correctly
TEST: arm64: dts: renesas: white-hawk-cpu: Enable TMU
.../dts/renesas/r8a779g0-white-hawk-cpu.dtsi | 24 ++++++-
arch/arm64/boot/dts/renesas/r8a779g0.dtsi | 65 +++++++++++++++++++
drivers/clk/renesas/r8a779g0-cpg-mssr.c | 6 ++
3 files changed, 93 insertions(+), 2 deletions(-)
--
2.35.1
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH 1/4] clk: renesas: r8a779g0: Add TMU and SASYNCRT clocks 2022-11-03 20:55 [PATCH 0/4] r8a779g0: add TMU support Wolfram Sang @ 2022-11-03 20:55 ` Wolfram Sang 2022-11-07 16:27 ` Geert Uytterhoeven 2022-11-03 20:55 ` [PATCH 2/4] arm64: dts: renesas: r8a779g0: Add TMU nodes Wolfram Sang ` (2 subsequent siblings) 3 siblings, 1 reply; 11+ messages in thread From: Wolfram Sang @ 2022-11-03 20:55 UTC (permalink / raw) To: linux-renesas-soc Cc: Wolfram Sang, Geert Uytterhoeven, Michael Turquette, Stephen Boyd, linux-clk, linux-kernel Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- drivers/clk/renesas/r8a779g0-cpg-mssr.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/clk/renesas/r8a779g0-cpg-mssr.c b/drivers/clk/renesas/r8a779g0-cpg-mssr.c index 5cc0dc9149bc..7f0b4f75ff4d 100644 --- a/drivers/clk/renesas/r8a779g0-cpg-mssr.c +++ b/drivers/clk/renesas/r8a779g0-cpg-mssr.c @@ -130,6 +130,7 @@ static const struct cpg_core_clk r8a779g0_core_clks[] __initconst = { DEF_FIXED("s0d4_hsc", R8A779G0_CLK_S0D4_HSC, CLK_S0_HSC, 4, 1), DEF_FIXED("cl16m_hsc", R8A779G0_CLK_CL16M_HSC, CLK_S0_HSC, 48, 1), DEF_FIXED("s0d2_cc", R8A779G0_CLK_S0D2_CC, CLK_S0, 2, 1), + DEF_FIXED("sasyncrt", R8A779G0_CLK_SASYNCRT, CLK_PLL5_DIV4, 48, 1), DEF_FIXED("sasyncperd1",R8A779G0_CLK_SASYNCPERD1, CLK_SASYNCPER,1, 1), DEF_FIXED("sasyncperd2",R8A779G0_CLK_SASYNCPERD2, CLK_SASYNCPER,2, 1), DEF_FIXED("sasyncperd4",R8A779G0_CLK_SASYNCPERD4, CLK_SASYNCPER,4, 1), @@ -185,6 +186,11 @@ static const struct mssr_mod_clk r8a779g0_mod_clks[] __initconst = { DEF_MOD("sdhi", 706, R8A779G0_CLK_SD0), DEF_MOD("sydm0", 709, R8A779G0_CLK_S0D6_PER), DEF_MOD("sydm1", 710, R8A779G0_CLK_S0D6_PER), + DEF_MOD("tmu0", 713, R8A779G0_CLK_SASYNCRT), + DEF_MOD("tmu1", 714, R8A779G0_CLK_SASYNCPERD2), + DEF_MOD("tmu2", 715, R8A779G0_CLK_SASYNCPERD2), + DEF_MOD("tmu3", 716, R8A779G0_CLK_SASYNCPERD2), + DEF_MOD("tmu4", 717, R8A779G0_CLK_SASYNCPERD2), DEF_MOD("tpu0", 718, R8A779G0_CLK_SASYNCPERD4), DEF_MOD("wdt1:wdt0", 907, R8A779G0_CLK_R), DEF_MOD("pfc0", 915, R8A779G0_CLK_CL16M), -- 2.35.1 ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/4] clk: renesas: r8a779g0: Add TMU and SASYNCRT clocks 2022-11-03 20:55 ` [PATCH 1/4] clk: renesas: r8a779g0: Add TMU and SASYNCRT clocks Wolfram Sang @ 2022-11-07 16:27 ` Geert Uytterhoeven 0 siblings, 0 replies; 11+ messages in thread From: Geert Uytterhoeven @ 2022-11-07 16:27 UTC (permalink / raw) To: Wolfram Sang Cc: linux-renesas-soc, Geert Uytterhoeven, Michael Turquette, Stephen Boyd, linux-clk, linux-kernel On Thu, Nov 3, 2022 at 9:55 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue in renesas-clk-for-v6.2. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 2/4] arm64: dts: renesas: r8a779g0: Add TMU nodes 2022-11-03 20:55 [PATCH 0/4] r8a779g0: add TMU support Wolfram Sang 2022-11-03 20:55 ` [PATCH 1/4] clk: renesas: r8a779g0: Add TMU and SASYNCRT clocks Wolfram Sang @ 2022-11-03 20:55 ` Wolfram Sang 2022-11-07 16:29 ` Geert Uytterhoeven 2022-11-03 20:55 ` [PATCH 3/4] arm64: dts: renesas: white-hawk-cpu: sort RWDT entry correctly Wolfram Sang 2022-11-03 20:55 ` [PATCH 4/4] TEST: arm64: dts: renesas: white-hawk-cpu: Enable TMU Wolfram Sang 3 siblings, 1 reply; 11+ messages in thread From: Wolfram Sang @ 2022-11-03 20:55 UTC (permalink / raw) To: linux-renesas-soc Cc: Wolfram Sang, Geert Uytterhoeven, Magnus Damm, Rob Herring, Krzysztof Kozlowski, devicetree, linux-kernel Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- arch/arm64/boot/dts/renesas/r8a779g0.dtsi | 65 +++++++++++++++++++++++ 1 file changed, 65 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a779g0.dtsi b/arch/arm64/boot/dts/renesas/r8a779g0.dtsi index 8141ffc38a08..fbab9817cc8c 100644 --- a/arch/arm64/boot/dts/renesas/r8a779g0.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a779g0.dtsi @@ -251,6 +251,71 @@ intc_ex: interrupt-controller@e61c0000 { resets = <&cpg 611>; }; + tmu0: timer@e61e0000 { + compatible = "renesas,tmu-r8a779g0", "renesas,tmu"; + reg = <0 0xe61e0000 0 0x30>; + interrupts = <GIC_SPI 289 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 290 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 291 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 713>; + clock-names = "fck"; + power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>; + resets = <&cpg 713>; + status = "disabled"; + }; + + tmu1: timer@e6fc0000 { + compatible = "renesas,tmu-r8a779g0", "renesas,tmu"; + reg = <0 0xe6fc0000 0 0x30>; + interrupts = <GIC_SPI 292 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 293 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 294 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 714>; + clock-names = "fck"; + power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>; + resets = <&cpg 714>; + status = "disabled"; + }; + + tmu2: timer@e6fd0000 { + compatible = "renesas,tmu-r8a779g0", "renesas,tmu"; + reg = <0 0xe6fd0000 0 0x30>; + interrupts = <GIC_SPI 296 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 297 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 298 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 715>; + clock-names = "fck"; + power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>; + resets = <&cpg 715>; + status = "disabled"; + }; + + tmu3: timer@e6fe0000 { + compatible = "renesas,tmu-r8a779g0", "renesas,tmu"; + reg = <0 0xe6fe0000 0 0x30>; + interrupts = <GIC_SPI 300 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 301 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 302 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 716>; + clock-names = "fck"; + power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>; + resets = <&cpg 716>; + status = "disabled"; + }; + + tmu4: timer@ffc00000 { + compatible = "renesas,tmu-r8a779g0", "renesas,tmu"; + reg = <0 0xffc00000 0 0x30>; + interrupts = <GIC_SPI 304 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 305 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 306 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 717>; + clock-names = "fck"; + power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>; + resets = <&cpg 717>; + status = "disabled"; + }; + i2c0: i2c@e6500000 { compatible = "renesas,i2c-r8a779g0", "renesas,rcar-gen4-i2c"; -- 2.35.1 ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/4] arm64: dts: renesas: r8a779g0: Add TMU nodes 2022-11-03 20:55 ` [PATCH 2/4] arm64: dts: renesas: r8a779g0: Add TMU nodes Wolfram Sang @ 2022-11-07 16:29 ` Geert Uytterhoeven 0 siblings, 0 replies; 11+ messages in thread From: Geert Uytterhoeven @ 2022-11-07 16:29 UTC (permalink / raw) To: Wolfram Sang Cc: linux-renesas-soc, Magnus Damm, Rob Herring, Krzysztof Kozlowski, devicetree, linux-kernel On Thu, Nov 3, 2022 at 9:55 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue in renesas-devel for v6.2. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 3/4] arm64: dts: renesas: white-hawk-cpu: sort RWDT entry correctly 2022-11-03 20:55 [PATCH 0/4] r8a779g0: add TMU support Wolfram Sang 2022-11-03 20:55 ` [PATCH 1/4] clk: renesas: r8a779g0: Add TMU and SASYNCRT clocks Wolfram Sang 2022-11-03 20:55 ` [PATCH 2/4] arm64: dts: renesas: r8a779g0: Add TMU nodes Wolfram Sang @ 2022-11-03 20:55 ` Wolfram Sang 2022-11-03 21:00 ` Krzysztof Kozlowski 2022-11-04 8:57 ` Geert Uytterhoeven 2022-11-03 20:55 ` [PATCH 4/4] TEST: arm64: dts: renesas: white-hawk-cpu: Enable TMU Wolfram Sang 3 siblings, 2 replies; 11+ messages in thread From: Wolfram Sang @ 2022-11-03 20:55 UTC (permalink / raw) To: linux-renesas-soc Cc: Wolfram Sang, Geert Uytterhoeven, Magnus Damm, Rob Herring, Krzysztof Kozlowski, devicetree, linux-kernel Fixes: 495e36c3a313 ("arm64: dts: renesas: white-hawk-cpu: Enable watchdog timer") Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi b/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi index bb4dd08781ca..c10740aee9f6 100644 --- a/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi @@ -271,11 +271,11 @@ user@1200000 { }; }; -&scif_clk { - clock-frequency = <24000000>; -}; - &rwdt { timeout-sec = <60>; status = "okay"; }; + +&scif_clk { + clock-frequency = <24000000>; +}; -- 2.35.1 ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 3/4] arm64: dts: renesas: white-hawk-cpu: sort RWDT entry correctly 2022-11-03 20:55 ` [PATCH 3/4] arm64: dts: renesas: white-hawk-cpu: sort RWDT entry correctly Wolfram Sang @ 2022-11-03 21:00 ` Krzysztof Kozlowski 2022-11-04 11:14 ` Wolfram Sang 2022-11-04 8:57 ` Geert Uytterhoeven 1 sibling, 1 reply; 11+ messages in thread From: Krzysztof Kozlowski @ 2022-11-03 21:00 UTC (permalink / raw) To: Wolfram Sang, linux-renesas-soc Cc: Geert Uytterhoeven, Magnus Damm, Rob Herring, Krzysztof Kozlowski, devicetree, linux-kernel On 03/11/2022 16:55, Wolfram Sang wrote: You need to describe the bug and its impact to justify Fixes tag (thus AUTOSEL backporting). > Fixes: 495e36c3a313 ("arm64: dts: renesas: white-hawk-cpu: Enable watchdog timer") But I doubt that there is a bug here. Style (like order of things) is not a bug. > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi b/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi > index bb4dd08781ca..c10740aee9f6 100644 > --- a/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi > @@ -271,11 +271,11 @@ user@1200000 { > }; > }; > > -&scif_clk { > - clock-frequency = <24000000>; > -}; > - > &rwdt { > timeout-sec = <60>; > status = "okay"; > }; > + > +&scif_clk { > + clock-frequency = <24000000>; > +}; Best regards, Krzysztof ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 3/4] arm64: dts: renesas: white-hawk-cpu: sort RWDT entry correctly 2022-11-03 21:00 ` Krzysztof Kozlowski @ 2022-11-04 11:14 ` Wolfram Sang 2022-11-04 12:21 ` Geert Uytterhoeven 0 siblings, 1 reply; 11+ messages in thread From: Wolfram Sang @ 2022-11-04 11:14 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: linux-renesas-soc, Geert Uytterhoeven, Magnus Damm, Rob Herring, Krzysztof Kozlowski, devicetree, linux-kernel [-- Attachment #1: Type: text/plain, Size: 187 bytes --] > But I doubt that there is a bug here. Style (like order of things) is > not a bug. Okay, I'll be more strict next time. Geert, could you kindly drop the Fixes tag or shall I resend? [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 3/4] arm64: dts: renesas: white-hawk-cpu: sort RWDT entry correctly 2022-11-04 11:14 ` Wolfram Sang @ 2022-11-04 12:21 ` Geert Uytterhoeven 0 siblings, 0 replies; 11+ messages in thread From: Geert Uytterhoeven @ 2022-11-04 12:21 UTC (permalink / raw) To: Wolfram Sang, Krzysztof Kozlowski, linux-renesas-soc, Geert Uytterhoeven, Magnus Damm, Rob Herring, Krzysztof Kozlowski, devicetree, linux-kernel Hi Wolfram, On Fri, Nov 4, 2022 at 12:15 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > > But I doubt that there is a bug here. Style (like order of things) is > > not a bug. > > Okay, I'll be more strict next time. Geert, could you kindly drop the > Fixes tag or shall I resend? Consider it done, no need to resend. BTW, I guess the stable machinery will pick it up anyway... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 3/4] arm64: dts: renesas: white-hawk-cpu: sort RWDT entry correctly 2022-11-03 20:55 ` [PATCH 3/4] arm64: dts: renesas: white-hawk-cpu: sort RWDT entry correctly Wolfram Sang 2022-11-03 21:00 ` Krzysztof Kozlowski @ 2022-11-04 8:57 ` Geert Uytterhoeven 1 sibling, 0 replies; 11+ messages in thread From: Geert Uytterhoeven @ 2022-11-04 8:57 UTC (permalink / raw) To: Wolfram Sang Cc: linux-renesas-soc, Magnus Damm, Rob Herring, Krzysztof Kozlowski, devicetree, linux-kernel On Thu, Nov 3, 2022 at 9:55 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > Fixes: 495e36c3a313 ("arm64: dts: renesas: white-hawk-cpu: Enable watchdog timer") > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue in renesas-devel for v6.2. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 4/4] TEST: arm64: dts: renesas: white-hawk-cpu: Enable TMU 2022-11-03 20:55 [PATCH 0/4] r8a779g0: add TMU support Wolfram Sang ` (2 preceding siblings ...) 2022-11-03 20:55 ` [PATCH 3/4] arm64: dts: renesas: white-hawk-cpu: sort RWDT entry correctly Wolfram Sang @ 2022-11-03 20:55 ` Wolfram Sang 3 siblings, 0 replies; 11+ messages in thread From: Wolfram Sang @ 2022-11-03 20:55 UTC (permalink / raw) To: linux-renesas-soc Cc: Wolfram Sang, Geert Uytterhoeven, Magnus Damm, Rob Herring, Krzysztof Kozlowski, devicetree, linux-kernel This patch enables TMU{0|1|2|3|4} on the WhiteHawk board. Only for testing, not for upstream! Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- .../dts/renesas/r8a779g0-white-hawk-cpu.dtsi | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi b/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi index c10740aee9f6..976e37ea0d7b 100644 --- a/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi @@ -279,3 +279,23 @@ &rwdt { &scif_clk { clock-frequency = <24000000>; }; + +&tmu0 { + status = "okay"; +}; + +&tmu1 { + status = "okay"; +}; + +&tmu2 { + status = "okay"; +}; + +&tmu3 { + status = "okay"; +}; + +&tmu4 { + status = "okay"; +}; -- 2.35.1 ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2022-11-07 16:31 UTC | newest] Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-11-03 20:55 [PATCH 0/4] r8a779g0: add TMU support Wolfram Sang 2022-11-03 20:55 ` [PATCH 1/4] clk: renesas: r8a779g0: Add TMU and SASYNCRT clocks Wolfram Sang 2022-11-07 16:27 ` Geert Uytterhoeven 2022-11-03 20:55 ` [PATCH 2/4] arm64: dts: renesas: r8a779g0: Add TMU nodes Wolfram Sang 2022-11-07 16:29 ` Geert Uytterhoeven 2022-11-03 20:55 ` [PATCH 3/4] arm64: dts: renesas: white-hawk-cpu: sort RWDT entry correctly Wolfram Sang 2022-11-03 21:00 ` Krzysztof Kozlowski 2022-11-04 11:14 ` Wolfram Sang 2022-11-04 12:21 ` Geert Uytterhoeven 2022-11-04 8:57 ` Geert Uytterhoeven 2022-11-03 20:55 ` [PATCH 4/4] TEST: arm64: dts: renesas: white-hawk-cpu: Enable TMU Wolfram Sang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®