From: Luis Chamberlain <mcgrof@kernel.org>
To: Nick Alcock <nick.alcock@oracle.com>,
Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
arnd@arndb.de, akpm@linux-foundation.org, eugene.loh@oracle.com,
kris.van.hees@oracle.com, mcgrof@kernel.org
Subject: Re: [PATCH v9 1/8] kbuild: bring back tristate.conf
Date: Wed, 9 Nov 2022 19:56:07 -0800 [thread overview]
Message-ID: <Y2x2V7QoGQXbzycc@bombadil.infradead.org> (raw)
In-Reply-To: <20221109134132.9052-2-nick.alcock@oracle.com>
On Wed, Nov 09, 2022 at 01:41:25PM +0000, Nick Alcock wrote:
> tristate.conf was dropped because it is not needed to build a
> modules.builtin (although dropping it introduces a few false positives
> into modules.builtin support), and doing so avoids one round of
> recursion through the build tree to build it. But kallmodsyms support
> requires building a mapping from object file name to built-in module
> name for all builtin modules: this seems to me impossible to accomplish
> without parsing all makefiles under the influence of tristate.conf,
> since the makefiles are the only place this mapping is recorded.
>
> So bring it back for this purpose. (Thanks to the refactoring in
> the 5.16 timeframe, this is basically a reimplementation of commit
> 8b41fc4454e36fbfdbb23f940d023d4dece2de29 rather than a simple
> reversion.)
>
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> Reviewed-by: Victor Erminpour <victor.erminpour@oracle.com>
> Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>
I don't see the need, see the review of next patch.
Luis
next prev parent reply other threads:[~2022-11-10 3:56 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 13:41 [PATCH PING v9] kallsyms: reliable symbol->address lookup with /proc/kallmodsyms Nick Alcock
2022-11-09 13:41 ` [PATCH v9 1/8] kbuild: bring back tristate.conf Nick Alcock
2022-11-10 3:56 ` Luis Chamberlain [this message]
2022-11-09 13:41 ` [PATCH v9 2/8] kbuild: add modules_thick.builtin Nick Alcock
2022-11-10 3:58 ` Luis Chamberlain
2022-11-11 13:47 ` Nick Alcock
2022-11-11 14:03 ` Nick Alcock
2022-11-11 15:12 ` Luis Chamberlain
2022-11-14 17:49 ` Nick Alcock
2022-11-15 21:21 ` Luis Chamberlain
2022-11-21 15:21 ` Nick Alcock
2022-11-21 19:12 ` Luis Chamberlain
2022-11-21 19:18 ` Luis Chamberlain
2022-11-21 21:14 ` Nick Alcock
2022-11-09 13:41 ` [PATCH v9 3/8] kbuild: generate an address ranges map at vmlinux link time Nick Alcock
2022-11-13 3:02 ` Luis Chamberlain
2022-11-14 16:48 ` Nick Alcock
2022-11-15 21:22 ` Luis Chamberlain
2022-11-16 16:06 ` Nick Alcock
2022-11-09 13:41 ` [PATCH v9 4/8] kallsyms: introduce sections needed to map symbols to built-in modules Nick Alcock
2022-11-13 3:15 ` Luis Chamberlain
2022-11-14 17:04 ` Nick Alcock
2022-11-15 11:47 ` Leizhen (ThunderTown)
2022-11-15 13:25 ` Nick Alcock
2022-11-15 19:58 ` Luis Chamberlain
2022-11-15 20:36 ` Luis Chamberlain
2022-11-09 13:41 ` [PATCH v9 5/8] kallsyms: optimize .kallsyms_modules* Nick Alcock
2022-11-09 13:41 ` [PATCH v9 6/8] kallsyms: distinguish text symbols fully using object file names Nick Alcock
2022-11-09 13:41 ` [PATCH v9 7/8] kallsyms: add /proc/kallmodsyms for text symbol disambiguation Nick Alcock
2022-11-13 3:26 ` Luis Chamberlain
2022-11-14 16:57 ` Nick Alcock
2022-11-15 21:24 ` Luis Chamberlain
2022-11-09 13:41 ` [PATCH v9 8/8] perf: proof-of-concept kallmodsyms support Nick Alcock
-- strict thread matches above, loose matches on Subject: below --
2022-10-27 19:57 [PATCH v9] kallsyms: reliable symbol->address lookup with /proc/kallmodsyms Nick Alcock
2022-10-27 19:57 ` [PATCH v9 1/8] kbuild: bring back tristate.conf Nick Alcock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2x2V7QoGQXbzycc@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=eugene.loh@oracle.com \
--cc=kris.van.hees@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nick.alcock@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®