From: Borislav Petkov <bp@alien8.de>
To: Ravi Bangoria <ravi.bangoria@amd.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
nslusarek@gmx.net, Linus Torvalds <torvalds@linux-foundation.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf: Fix sys_perf_event_open() race against self
Date: Thu, 17 Nov 2022 12:59:06 +0100 [thread overview]
Message-ID: <Y3YiCkjsa3NLIpq6@zn.tnic> (raw)
In-Reply-To: <68df3063-3fa2-9332-1705-631716589450@amd.com>
On Thu, Nov 17, 2022 at 04:29:31PM +0530, Ravi Bangoria wrote:
> I do agree that more tests are always better. Though, this simple program
> was to test a _specific race condition_ which no longer exists in kernel.
> So even if we add it, what would it test?
It would make sure that race doesn't happen again. Or are you saying it
will never ever happen so no need? Because we never ever rewrite the
kernel?
Lemme save us some time: this test is dirt cheap. It is good to have so
that multithreaded sys_perf_event_open() is exercised. And once it is
there, someone else might have a look at it and improve it more or reuse
it for another test.
And there are no downsides.
If you're still not convinced, lemme know and I'll turn it into a proper
patch and submit it.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2022-11-17 11:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 18:38 Peter Zijlstra
2022-05-23 10:33 ` Ravi Bangoria
2022-11-16 22:30 ` Borislav Petkov
2022-11-17 10:33 ` Ravi Bangoria
2022-11-17 10:40 ` Borislav Petkov
2022-11-17 10:59 ` Ravi Bangoria
2022-11-17 11:59 ` Borislav Petkov [this message]
2022-11-17 13:38 ` Ravi Bangoria
2022-05-23 10:48 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3YiCkjsa3NLIpq6@zn.tnic \
--to=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=nslusarek@gmx.net \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome