* [PATCH] crypto: qat - fix error return code in adf_probe
@ 2022-11-21 11:27 Wang Yufen
2022-11-21 11:51 ` Giovanni Cabiddu
2022-12-02 10:18 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Wang Yufen @ 2022-11-21 11:27 UTC (permalink / raw)
To: giovanni.cabiddu, herbert, davem, marco.chiappero
Cc: tomaszx.kowalik, qat-linux, linux-crypto, linux-kernel, Wang Yufen
Fix to return a negative error code -EINVAL instead of 0.
Fixes: 0cec19c761e5 ("crypto: qat - add support for compression for 4xxx")
Signed-off-by: Wang Yufen <wangyufen@huawei.com>
---
drivers/crypto/qat/qat_4xxx/adf_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/crypto/qat/qat_4xxx/adf_drv.c b/drivers/crypto/qat/qat_4xxx/adf_drv.c
index 2f21256..670a58b2 100644
--- a/drivers/crypto/qat/qat_4xxx/adf_drv.c
+++ b/drivers/crypto/qat/qat_4xxx/adf_drv.c
@@ -261,6 +261,7 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
hw_data->accel_capabilities_mask = hw_data->get_accel_cap(accel_dev);
if (!hw_data->accel_capabilities_mask) {
dev_err(&pdev->dev, "Failed to get capabilities mask.\n");
+ ret = -EINVAL;
goto out_err;
}
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] crypto: qat - fix error return code in adf_probe
2022-11-21 11:27 [PATCH] crypto: qat - fix error return code in adf_probe Wang Yufen
@ 2022-11-21 11:51 ` Giovanni Cabiddu
2022-12-02 10:18 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Giovanni Cabiddu @ 2022-11-21 11:51 UTC (permalink / raw)
To: Wang Yufen
Cc: herbert, davem, marco.chiappero, tomaszx.kowalik, qat-linux,
linux-crypto, linux-kernel
On Mon, Nov 21, 2022 at 07:27:34PM +0800, Wang Yufen wrote:
> Fix to return a negative error code -EINVAL instead of 0.
>
> Fixes: 0cec19c761e5 ("crypto: qat - add support for compression for 4xxx")
> Signed-off-by: Wang Yufen <wangyufen@huawei.com>
Acked-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] crypto: qat - fix error return code in adf_probe
2022-11-21 11:27 [PATCH] crypto: qat - fix error return code in adf_probe Wang Yufen
2022-11-21 11:51 ` Giovanni Cabiddu
@ 2022-12-02 10:18 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2022-12-02 10:18 UTC (permalink / raw)
To: Wang Yufen
Cc: giovanni.cabiddu, davem, marco.chiappero, tomaszx.kowalik,
qat-linux, linux-crypto, linux-kernel
On Mon, Nov 21, 2022 at 07:27:34PM +0800, Wang Yufen wrote:
> Fix to return a negative error code -EINVAL instead of 0.
>
> Fixes: 0cec19c761e5 ("crypto: qat - add support for compression for 4xxx")
> Signed-off-by: Wang Yufen <wangyufen@huawei.com>
> ---
> drivers/crypto/qat/qat_4xxx/adf_drv.c | 1 +
> 1 file changed, 1 insertion(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-02 10:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-21 11:27 [PATCH] crypto: qat - fix error return code in adf_probe Wang Yufen
2022-11-21 11:51 ` Giovanni Cabiddu
2022-12-02 10:18 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®