From: Andrew Lunn <andrew@lunn.ch>
To: Hariprasad Kelam <hkelam@marvell.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com,
edumazet@google.com, sgoutham@marvell.com, lcherian@marvell.com,
gakula@marvell.com, jerinj@marvell.com, sbhatta@marvell.com
Subject: Re: [net-next PATCH V2 3/4] octeontx2-pf: ethtool: Implement get_fec_stats
Date: Tue, 29 Nov 2022 19:45:30 +0100 [thread overview]
Message-ID: <Y4ZTSh7/xCJVosyW@lunn.ch> (raw)
In-Reply-To: <20221129051409.20034-4-hkelam@marvell.com>
On Tue, Nov 29, 2022 at 10:44:08AM +0530, Hariprasad Kelam wrote:
> The current implementation is such that FEC statistics are reported as
> part of ethtool statistics that is the user can fetch them from the
> below command
>
> "ethtool -S eth0"
>
> Fec Corrected Errors:
> Fec Uncorrected Errors:
>
> This patch removes this logic
What might break the ABI, if anybody is using these statistics, or has
a dumb parser and just looks at entry 42 which is now a different
entry.
So i think you need to keep these two, and additionally report them
the correct way via get_fec_stats.
Andrew
next prev parent reply other threads:[~2022-11-29 18:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 5:14 [net-next PATCH V2 0/4] CN10KB MAC block support Hariprasad Kelam
2022-11-29 5:14 ` [net-next PATCH V2 1/4] octeontx2-af: Support variable number of lmacs Hariprasad Kelam
2022-11-29 5:14 ` [net-next PATCH V2 2/4] octeontx2-af: cn10kb: Add RPM_USX MAC support Hariprasad Kelam
2022-11-29 5:14 ` [net-next PATCH V2 3/4] octeontx2-pf: ethtool: Implement get_fec_stats Hariprasad Kelam
2022-11-29 18:45 ` Andrew Lunn [this message]
2022-11-30 8:54 ` Hariprasad Kelam
2022-11-29 5:14 ` [net-next PATCH V2 4/4] octeontx2-af: Add FEC stats for RPM/RPM_USX block Hariprasad Kelam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4ZTSh7/xCJVosyW@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=jerinj@marvell.com \
--cc=kuba@kernel.org \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®