From: Leon Romanovsky <leon@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, Jason Gunthorpe <jgg@nvidia.com>,
Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
Christoph Hellwig <hch@infradead.org>,
linux-rdma@vger.kernel.org, Jeff Dike <jdike@addtoit.com>,
Richard Weinberger <richard@nod.at>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Johannes Berg <johannes@sipsolutions.net>,
linux-um@lists.infradead.org
Subject: Re: [PATCH v2] infiniband: disable IB HW for UML
Date: Sun, 4 Dec 2022 15:21:53 +0200 [thread overview]
Message-ID: <Y4ye8YOWk0V/BqKL@unreal> (raw)
In-Reply-To: <20221202211940.29111-1-rdunlap@infradead.org>
On Fri, Dec 02, 2022 at 01:19:40PM -0800, Randy Dunlap wrote:
> Disable all of drivers/infiniband/hw/ for UML builds until someone
> needs it and provides patches to support it.
>
> This prevents build errors in hw/qib/qib_wc_x86_64.c.
>
> Fixes: 68f5d3f3b654 ("um: add PCI over virtio emulation driver")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Suggested-by: Leon Romanovsky <leon@kernel.org>
> Cc: Jason Gunthorpe <jgg@nvidia.com>
> Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
> Cc: Christoph Hellwig <hch@infradead.org>
> Cc: linux-rdma@vger.kernel.org
> Cc: Jeff Dike <jdike@addtoit.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com>
> Cc: Johannes Berg <johannes@sipsolutions.net>
> Cc: linux-um@lists.infradead.org
> ---
> v2: just disable infiniband/hw/, not all of infiniband.
>
> drivers/infiniband/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
I added rdmavt to the mix and applied.
https://lore.kernel.org/linux-rdma/20221130200958.25305-1-rdunlap@infradead.org/
diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig
index 6ee97c898231..a5827d11e934 100644
--- a/drivers/infiniband/Kconfig
+++ b/drivers/infiniband/Kconfig
@@ -95,8 +95,8 @@ source "drivers/infiniband/hw/qedr/Kconfig"
source "drivers/infiniband/hw/qib/Kconfig"
source "drivers/infiniband/hw/usnic/Kconfig"
source "drivers/infiniband/hw/vmw_pvrdma/Kconfig"
-endif # !UML
source "drivers/infiniband/sw/rdmavt/Kconfig"
+endif # !UML
source "drivers/infiniband/sw/rxe/Kconfig"
source "drivers/infiniband/sw/siw/Kconfig"
endif
(END)
>
> diff -- a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig
> --- a/drivers/infiniband/Kconfig
> +++ b/drivers/infiniband/Kconfig
> @@ -78,6 +78,7 @@ config INFINIBAND_VIRT_DMA
> def_bool !HIGHMEM
>
> if INFINIBAND_USER_ACCESS || !INFINIBAND_USER_ACCESS
> +if !UML
> source "drivers/infiniband/hw/bnxt_re/Kconfig"
> source "drivers/infiniband/hw/cxgb4/Kconfig"
> source "drivers/infiniband/hw/efa/Kconfig"
> @@ -94,6 +95,7 @@ source "drivers/infiniband/hw/qedr/Kconf
> source "drivers/infiniband/hw/qib/Kconfig"
> source "drivers/infiniband/hw/usnic/Kconfig"
> source "drivers/infiniband/hw/vmw_pvrdma/Kconfig"
> +endif # !UML
> source "drivers/infiniband/sw/rdmavt/Kconfig"
> source "drivers/infiniband/sw/rxe/Kconfig"
> source "drivers/infiniband/sw/siw/Kconfig"
next prev parent reply other threads:[~2022-12-04 13:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 21:19 Randy Dunlap
2022-12-04 13:21 ` Leon Romanovsky [this message]
2022-12-04 16:10 ` Randy Dunlap
2022-12-04 13:23 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4ye8YOWk0V/BqKL@unreal \
--to=leon@kernel.org \
--cc=anton.ivanov@cambridgegreys.com \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=hch@infradead.org \
--cc=jdike@addtoit.com \
--cc=jgg@nvidia.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=rdunlap@infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®