* [PATCH v2] infiniband: disable IB HW for UML
@ 2022-12-02 21:19 Randy Dunlap
2022-12-04 13:21 ` Leon Romanovsky
2022-12-04 13:23 ` Leon Romanovsky
0 siblings, 2 replies; 4+ messages in thread
From: Randy Dunlap @ 2022-12-02 21:19 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Leon Romanovsky, Jason Gunthorpe,
Dennis Dalessandro, Christoph Hellwig, linux-rdma, Jeff Dike,
Richard Weinberger, Anton Ivanov, Johannes Berg, linux-um
Disable all of drivers/infiniband/hw/ for UML builds until someone
needs it and provides patches to support it.
This prevents build errors in hw/qib/qib_wc_x86_64.c.
Fixes: 68f5d3f3b654 ("um: add PCI over virtio emulation driver")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Suggested-by: Leon Romanovsky <leon@kernel.org>
Cc: Jason Gunthorpe <jgg@nvidia.com>
Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: linux-rdma@vger.kernel.org
Cc: Jeff Dike <jdike@addtoit.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com>
Cc: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-um@lists.infradead.org
---
v2: just disable infiniband/hw/, not all of infiniband.
drivers/infiniband/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff -- a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig
--- a/drivers/infiniband/Kconfig
+++ b/drivers/infiniband/Kconfig
@@ -78,6 +78,7 @@ config INFINIBAND_VIRT_DMA
def_bool !HIGHMEM
if INFINIBAND_USER_ACCESS || !INFINIBAND_USER_ACCESS
+if !UML
source "drivers/infiniband/hw/bnxt_re/Kconfig"
source "drivers/infiniband/hw/cxgb4/Kconfig"
source "drivers/infiniband/hw/efa/Kconfig"
@@ -94,6 +95,7 @@ source "drivers/infiniband/hw/qedr/Kconf
source "drivers/infiniband/hw/qib/Kconfig"
source "drivers/infiniband/hw/usnic/Kconfig"
source "drivers/infiniband/hw/vmw_pvrdma/Kconfig"
+endif # !UML
source "drivers/infiniband/sw/rdmavt/Kconfig"
source "drivers/infiniband/sw/rxe/Kconfig"
source "drivers/infiniband/sw/siw/Kconfig"
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] infiniband: disable IB HW for UML
2022-12-02 21:19 [PATCH v2] infiniband: disable IB HW for UML Randy Dunlap
@ 2022-12-04 13:21 ` Leon Romanovsky
2022-12-04 16:10 ` Randy Dunlap
2022-12-04 13:23 ` Leon Romanovsky
1 sibling, 1 reply; 4+ messages in thread
From: Leon Romanovsky @ 2022-12-04 13:21 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, Jason Gunthorpe, Dennis Dalessandro,
Christoph Hellwig, linux-rdma, Jeff Dike, Richard Weinberger,
Anton Ivanov, Johannes Berg, linux-um
On Fri, Dec 02, 2022 at 01:19:40PM -0800, Randy Dunlap wrote:
> Disable all of drivers/infiniband/hw/ for UML builds until someone
> needs it and provides patches to support it.
>
> This prevents build errors in hw/qib/qib_wc_x86_64.c.
>
> Fixes: 68f5d3f3b654 ("um: add PCI over virtio emulation driver")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Suggested-by: Leon Romanovsky <leon@kernel.org>
> Cc: Jason Gunthorpe <jgg@nvidia.com>
> Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
> Cc: Christoph Hellwig <hch@infradead.org>
> Cc: linux-rdma@vger.kernel.org
> Cc: Jeff Dike <jdike@addtoit.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com>
> Cc: Johannes Berg <johannes@sipsolutions.net>
> Cc: linux-um@lists.infradead.org
> ---
> v2: just disable infiniband/hw/, not all of infiniband.
>
> drivers/infiniband/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
I added rdmavt to the mix and applied.
https://lore.kernel.org/linux-rdma/20221130200958.25305-1-rdunlap@infradead.org/
diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig
index 6ee97c898231..a5827d11e934 100644
--- a/drivers/infiniband/Kconfig
+++ b/drivers/infiniband/Kconfig
@@ -95,8 +95,8 @@ source "drivers/infiniband/hw/qedr/Kconfig"
source "drivers/infiniband/hw/qib/Kconfig"
source "drivers/infiniband/hw/usnic/Kconfig"
source "drivers/infiniband/hw/vmw_pvrdma/Kconfig"
-endif # !UML
source "drivers/infiniband/sw/rdmavt/Kconfig"
+endif # !UML
source "drivers/infiniband/sw/rxe/Kconfig"
source "drivers/infiniband/sw/siw/Kconfig"
endif
(END)
>
> diff -- a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig
> --- a/drivers/infiniband/Kconfig
> +++ b/drivers/infiniband/Kconfig
> @@ -78,6 +78,7 @@ config INFINIBAND_VIRT_DMA
> def_bool !HIGHMEM
>
> if INFINIBAND_USER_ACCESS || !INFINIBAND_USER_ACCESS
> +if !UML
> source "drivers/infiniband/hw/bnxt_re/Kconfig"
> source "drivers/infiniband/hw/cxgb4/Kconfig"
> source "drivers/infiniband/hw/efa/Kconfig"
> @@ -94,6 +95,7 @@ source "drivers/infiniband/hw/qedr/Kconf
> source "drivers/infiniband/hw/qib/Kconfig"
> source "drivers/infiniband/hw/usnic/Kconfig"
> source "drivers/infiniband/hw/vmw_pvrdma/Kconfig"
> +endif # !UML
> source "drivers/infiniband/sw/rdmavt/Kconfig"
> source "drivers/infiniband/sw/rxe/Kconfig"
> source "drivers/infiniband/sw/siw/Kconfig"
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] infiniband: disable IB HW for UML
2022-12-04 13:21 ` Leon Romanovsky
@ 2022-12-04 16:10 ` Randy Dunlap
0 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2022-12-04 16:10 UTC (permalink / raw)
To: Leon Romanovsky
Cc: linux-kernel, Jason Gunthorpe, Dennis Dalessandro,
Christoph Hellwig, linux-rdma, Jeff Dike, Richard Weinberger,
Anton Ivanov, Johannes Berg, linux-um
On 12/4/22 05:21, Leon Romanovsky wrote:
> On Fri, Dec 02, 2022 at 01:19:40PM -0800, Randy Dunlap wrote:
>> Disable all of drivers/infiniband/hw/ for UML builds until someone
>> needs it and provides patches to support it.
>>
>> This prevents build errors in hw/qib/qib_wc_x86_64.c.
>>
>> Fixes: 68f5d3f3b654 ("um: add PCI over virtio emulation driver")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Suggested-by: Leon Romanovsky <leon@kernel.org>
>> Cc: Jason Gunthorpe <jgg@nvidia.com>
>> Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
>> Cc: Christoph Hellwig <hch@infradead.org>
>> Cc: linux-rdma@vger.kernel.org
>> Cc: Jeff Dike <jdike@addtoit.com>
>> Cc: Richard Weinberger <richard@nod.at>
>> Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com>
>> Cc: Johannes Berg <johannes@sipsolutions.net>
>> Cc: linux-um@lists.infradead.org
>> ---
>> v2: just disable infiniband/hw/, not all of infiniband.
>>
>> drivers/infiniband/Kconfig | 2 ++
>> 1 file changed, 2 insertions(+)
>
> I added rdmavt to the mix and applied.
Sounds good. Thanks.
> https://lore.kernel.org/linux-rdma/20221130200958.25305-1-rdunlap@infradead.org/
>
> diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig
> index 6ee97c898231..a5827d11e934 100644
> --- a/drivers/infiniband/Kconfig
> +++ b/drivers/infiniband/Kconfig
> @@ -95,8 +95,8 @@ source "drivers/infiniband/hw/qedr/Kconfig"
> source "drivers/infiniband/hw/qib/Kconfig"
> source "drivers/infiniband/hw/usnic/Kconfig"
> source "drivers/infiniband/hw/vmw_pvrdma/Kconfig"
> -endif # !UML
> source "drivers/infiniband/sw/rdmavt/Kconfig"
> +endif # !UML
> source "drivers/infiniband/sw/rxe/Kconfig"
> source "drivers/infiniband/sw/siw/Kconfig"
> endif
> (END)
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] infiniband: disable IB HW for UML
2022-12-02 21:19 [PATCH v2] infiniband: disable IB HW for UML Randy Dunlap
2022-12-04 13:21 ` Leon Romanovsky
@ 2022-12-04 13:23 ` Leon Romanovsky
1 sibling, 0 replies; 4+ messages in thread
From: Leon Romanovsky @ 2022-12-04 13:23 UTC (permalink / raw)
To: linux-kernel, Randy Dunlap
Cc: Jason Gunthorpe, Christoph Hellwig, Anton Ivanov, Jeff Dike,
Johannes Berg, Richard Weinberger, linux-um, linux-rdma,
Dennis Dalessandro
On Fri, 2 Dec 2022 13:19:40 -0800, Randy Dunlap wrote:
> Disable all of drivers/infiniband/hw/ for UML builds until someone
> needs it and provides patches to support it.
>
> This prevents build errors in hw/qib/qib_wc_x86_64.c.
>
>
Applied, thanks!
[1/1] infiniband: disable IB HW for UML
https://git.kernel.org/rdma/rdma/c/323a74fc20f53c
Best regards,
--
Leon Romanovsky <leon@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-12-04 16:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-02 21:19 [PATCH v2] infiniband: disable IB HW for UML Randy Dunlap
2022-12-04 13:21 ` Leon Romanovsky
2022-12-04 16:10 ` Randy Dunlap
2022-12-04 13:23 ` Leon Romanovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®