From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jianglei Nie <niejianglei2021@163.com>
Cc: ojeda@kernel.org, geert+renesas@glider.be,
linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v3] auxdisplay: hd44780: Fix potential memory leak in hd44780_remove()
Date: Mon, 12 Dec 2022 11:59:55 +0200 [thread overview]
Message-ID: <Y5b7m/aijyJEuyoI@smile.fi.intel.com> (raw)
In-Reply-To: <20221129081542.5890-1-niejianglei2021@163.com>
On Tue, Nov 29, 2022 at 04:15:42PM +0800, Jianglei Nie wrote:
> hd44780_probe() allocates a memory chunk for hd with kzalloc() and
> makes "lcd->drvdata->hd44780" point to it. When we call hd44780_remove(),
> we should release all relevant memory and resource. But "lcd->drvdata
> ->hd44780" is not released, which will lead to a memory leak.
>
> We should release the "lcd->drvdata->hd44780" in hd44780_remove() to fix
> the memory leak bug.
Miguel, can this be somehow moved forward?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-12-12 10:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 8:15 Jianglei Nie
2022-12-12 9:59 ` Andy Shevchenko [this message]
2022-12-13 17:36 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5b7m/aijyJEuyoI@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=niejianglei2021@163.com \
--cc=ojeda@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®