* [PATCH v3] auxdisplay: hd44780: Fix potential memory leak in hd44780_remove()
@ 2022-11-29 8:15 Jianglei Nie
2022-12-12 9:59 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Jianglei Nie @ 2022-11-29 8:15 UTC (permalink / raw)
To: ojeda, andriy.shevchenko, geert+renesas
Cc: linux-kernel, Jianglei Nie, kernel test robot
hd44780_probe() allocates a memory chunk for hd with kzalloc() and
makes "lcd->drvdata->hd44780" point to it. When we call hd44780_remove(),
we should release all relevant memory and resource. But "lcd->drvdata
->hd44780" is not released, which will lead to a memory leak.
We should release the "lcd->drvdata->hd44780" in hd44780_remove() to fix
the memory leak bug.
Fixes: 718e05ed92ec ("auxdisplay: Introduce hd44780_common.[ch]")
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Jianglei Nie <niejianglei2021@163.com>
---
drivers/auxdisplay/hd44780.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/auxdisplay/hd44780.c b/drivers/auxdisplay/hd44780.c
index 8b2a0eb3f32a..d56a5d508ccd 100644
--- a/drivers/auxdisplay/hd44780.c
+++ b/drivers/auxdisplay/hd44780.c
@@ -322,8 +322,10 @@ static int hd44780_probe(struct platform_device *pdev)
static int hd44780_remove(struct platform_device *pdev)
{
struct charlcd *lcd = platform_get_drvdata(pdev);
+ struct hd44780_common *hdc = lcd->drvdata;
charlcd_unregister(lcd);
+ kfree(hdc->hd44780);
kfree(lcd->drvdata);
kfree(lcd);
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] auxdisplay: hd44780: Fix potential memory leak in hd44780_remove()
2022-11-29 8:15 [PATCH v3] auxdisplay: hd44780: Fix potential memory leak in hd44780_remove() Jianglei Nie
@ 2022-12-12 9:59 ` Andy Shevchenko
2022-12-13 17:36 ` Miguel Ojeda
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2022-12-12 9:59 UTC (permalink / raw)
To: Jianglei Nie; +Cc: ojeda, geert+renesas, linux-kernel, kernel test robot
On Tue, Nov 29, 2022 at 04:15:42PM +0800, Jianglei Nie wrote:
> hd44780_probe() allocates a memory chunk for hd with kzalloc() and
> makes "lcd->drvdata->hd44780" point to it. When we call hd44780_remove(),
> we should release all relevant memory and resource. But "lcd->drvdata
> ->hd44780" is not released, which will lead to a memory leak.
>
> We should release the "lcd->drvdata->hd44780" in hd44780_remove() to fix
> the memory leak bug.
Miguel, can this be somehow moved forward?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] auxdisplay: hd44780: Fix potential memory leak in hd44780_remove()
2022-12-12 9:59 ` Andy Shevchenko
@ 2022-12-13 17:36 ` Miguel Ojeda
0 siblings, 0 replies; 3+ messages in thread
From: Miguel Ojeda @ 2022-12-13 17:36 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Jianglei Nie, ojeda, geert+renesas, linux-kernel, kernel test robot
On Mon, Dec 12, 2022 at 11:00 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Miguel, can this be somehow moved forward?
Thanks for the ping -- queued!
Cheers,
Miguel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-13 17:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-29 8:15 [PATCH v3] auxdisplay: hd44780: Fix potential memory leak in hd44780_remove() Jianglei Nie
2022-12-12 9:59 ` Andy Shevchenko
2022-12-13 17:36 ` Miguel Ojeda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®