* [PATCH] fpga: stratix10-soc: Fix return value check in s10_ops_write_init()
@ 2022-11-26 7:14 Zheng Yongjun
2022-11-29 1:26 ` Russ Weight
0 siblings, 1 reply; 3+ messages in thread
From: Zheng Yongjun @ 2022-11-26 7:14 UTC (permalink / raw)
To: mdf, hao.wu, yilun.xu, linux-fpga, linux-kernel; +Cc: trix
In case of error, the function stratix10_svc_allocate_memory()
returns ERR_PTR() and never returns NULL. The NULL test in the
return value check should be replaced with IS_ERR().
Fixes: e7eef1d7633a ("fpga: add intel stratix10 soc fpga manager driver")
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
drivers/fpga/stratix10-soc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c
index 357cea58ec98..f7f01982a512 100644
--- a/drivers/fpga/stratix10-soc.c
+++ b/drivers/fpga/stratix10-soc.c
@@ -213,9 +213,9 @@ static int s10_ops_write_init(struct fpga_manager *mgr,
/* Allocate buffers from the service layer's pool. */
for (i = 0; i < NUM_SVC_BUFS; i++) {
kbuf = stratix10_svc_allocate_memory(priv->chan, SVC_BUF_SIZE);
- if (!kbuf) {
+ if (IS_ERR(kbuf)) {
s10_free_buffers(mgr);
- ret = -ENOMEM;
+ ret = PTR_ERR(kbuf);
goto init_done;
}
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] fpga: stratix10-soc: Fix return value check in s10_ops_write_init()
2022-11-26 7:14 [PATCH] fpga: stratix10-soc: Fix return value check in s10_ops_write_init() Zheng Yongjun
@ 2022-11-29 1:26 ` Russ Weight
2022-12-30 2:34 ` Xu Yilun
0 siblings, 1 reply; 3+ messages in thread
From: Russ Weight @ 2022-11-29 1:26 UTC (permalink / raw)
To: Zheng Yongjun, mdf, hao.wu, yilun.xu, linux-fpga, linux-kernel; +Cc: trix
On 11/25/22 23:14, Zheng Yongjun wrote:
> In case of error, the function stratix10_svc_allocate_memory()
> returns ERR_PTR() and never returns NULL. The NULL test in the
> return value check should be replaced with IS_ERR().
>
> Fixes: e7eef1d7633a ("fpga: add intel stratix10 soc fpga manager driver")
Reviewed-by: Russ Weight <russell.h.weight@intel.com>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
> drivers/fpga/stratix10-soc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c
> index 357cea58ec98..f7f01982a512 100644
> --- a/drivers/fpga/stratix10-soc.c
> +++ b/drivers/fpga/stratix10-soc.c
> @@ -213,9 +213,9 @@ static int s10_ops_write_init(struct fpga_manager *mgr,
> /* Allocate buffers from the service layer's pool. */
> for (i = 0; i < NUM_SVC_BUFS; i++) {
> kbuf = stratix10_svc_allocate_memory(priv->chan, SVC_BUF_SIZE);
> - if (!kbuf) {
> + if (IS_ERR(kbuf)) {
> s10_free_buffers(mgr);
> - ret = -ENOMEM;
> + ret = PTR_ERR(kbuf);
> goto init_done;
> }
>
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] fpga: stratix10-soc: Fix return value check in s10_ops_write_init()
2022-11-29 1:26 ` Russ Weight
@ 2022-12-30 2:34 ` Xu Yilun
0 siblings, 0 replies; 3+ messages in thread
From: Xu Yilun @ 2022-12-30 2:34 UTC (permalink / raw)
To: Russ Weight; +Cc: Zheng Yongjun, mdf, hao.wu, linux-fpga, linux-kernel, trix
On 2022-11-28 at 17:26:23 -0800, Russ Weight wrote:
>
>
> On 11/25/22 23:14, Zheng Yongjun wrote:
> > In case of error, the function stratix10_svc_allocate_memory()
> > returns ERR_PTR() and never returns NULL. The NULL test in the
> > return value check should be replaced with IS_ERR().
> >
> > Fixes: e7eef1d7633a ("fpga: add intel stratix10 soc fpga manager driver")
>
> Reviewed-by: Russ Weight <russell.h.weight@intel.com>
> > Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
Acked-by: Xu Yilun <yilun.xu@intel.com>
Applied to for-6.2 and Cc: stable@vger.kernel.org
> > ---
> > drivers/fpga/stratix10-soc.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c
> > index 357cea58ec98..f7f01982a512 100644
> > --- a/drivers/fpga/stratix10-soc.c
> > +++ b/drivers/fpga/stratix10-soc.c
> > @@ -213,9 +213,9 @@ static int s10_ops_write_init(struct fpga_manager *mgr,
> > /* Allocate buffers from the service layer's pool. */
> > for (i = 0; i < NUM_SVC_BUFS; i++) {
> > kbuf = stratix10_svc_allocate_memory(priv->chan, SVC_BUF_SIZE);
> > - if (!kbuf) {
> > + if (IS_ERR(kbuf)) {
> > s10_free_buffers(mgr);
> > - ret = -ENOMEM;
> > + ret = PTR_ERR(kbuf);
> > goto init_done;
> > }
> >
> > --
> > 2.17.1
> >
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-30 2:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-26 7:14 [PATCH] fpga: stratix10-soc: Fix return value check in s10_ops_write_init() Zheng Yongjun
2022-11-29 1:26 ` Russ Weight
2022-12-30 2:34 ` Xu Yilun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®