From: Borislav Petkov <bp@alien8.de>
To: Zeng Heng <zengheng4@huawei.com>
Cc: Ingo Molnar <mingo@kernel.org>,
michael.roth@amd.com, hpa@zytor.com, tglx@linutronix.de,
sathyanarayanan.kuppuswamy@linux.intel.com,
kirill.shutemov@linux.intel.com, jroedel@suse.de,
keescook@chromium.org, mingo@redhat.com,
dave.hansen@linux.intel.com, brijesh.singh@amd.com,
linux-kernel@vger.kernel.org, x86@kernel.org,
liwei391@huawei.com
Subject: Re: [PATCH -v2] x86/boot/compressed: Register dummy NMI handler in EFI boot loader, to avoid kdump crashes
Date: Tue, 10 Jan 2023 17:09:10 +0100 [thread overview]
Message-ID: <Y72NphKcBMQho02u@zn.tnic> (raw)
In-Reply-To: <Y71goW5qTW5dZKcv@zn.tnic>
On Tue, Jan 10, 2023 at 01:57:05PM +0100, Borislav Petkov wrote:
> I'm doubtful now as you're injecting errors so you're not really in #MC context
> but in this contrived context which is actually an NMI one. So we need to think
> about how to fix this case.
I did some more thinking:
*if* this really is a real issue - and not some silly qemu games - then
native_machine_crash_shutdown() does all the cleanup before the kdump kernel is
started.
Any NMI clearing, maybe using iret_to_self() etc, #MC resetting etc should
happen there and not anywhere else.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2023-01-10 16:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 10:27 [PATCH] x86/boot/compressed: Register NMI handler in EFI boot loader Zeng Heng
2023-01-10 10:59 ` Ingo Molnar
2023-01-10 12:01 ` [PATCH -v2] x86/boot/compressed: Register dummy NMI handler in EFI boot loader, to avoid kdump crashes Ingo Molnar
2023-01-10 12:11 ` Borislav Petkov
2023-01-10 12:17 ` Borislav Petkov
2023-01-10 12:34 ` Ingo Molnar
2023-01-10 12:46 ` Borislav Petkov
2023-01-10 12:50 ` Zeng Heng
2023-01-10 12:32 ` Zeng Heng
2023-01-10 12:57 ` Borislav Petkov
2023-01-10 13:42 ` Zeng Heng
2023-01-10 16:09 ` Borislav Petkov [this message]
2023-01-12 2:07 ` Zeng Heng
2023-01-10 14:53 ` Borislav Petkov
2023-01-11 3:46 ` Zeng Heng
2023-01-10 14:06 ` Zeng Heng
2023-01-10 11:41 ` [tip: x86/boot] " tip-bot2 for Zeng Heng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y72NphKcBMQho02u@zn.tnic \
--to=bp@alien8.de \
--cc=brijesh.singh@amd.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jroedel@suse.de \
--cc=keescook@chromium.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liwei391@huawei.com \
--cc=michael.roth@amd.com \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=zengheng4@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®