mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Zeng Heng <zengheng4@huawei.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Ingo Molnar <mingo@kernel.org>, <michael.roth@amd.com>,
	<hpa@zytor.com>, <tglx@linutronix.de>,
	<sathyanarayanan.kuppuswamy@linux.intel.com>,
	<kirill.shutemov@linux.intel.com>, <jroedel@suse.de>,
	<keescook@chromium.org>, <mingo@redhat.com>,
	<dave.hansen@linux.intel.com>, <brijesh.singh@amd.com>,
	<linux-kernel@vger.kernel.org>, <x86@kernel.org>,
	<liwei391@huawei.com>
Subject: Re: [PATCH -v2] x86/boot/compressed: Register dummy NMI handler in EFI boot loader, to avoid kdump crashes
Date: Wed, 11 Jan 2023 11:46:40 +0800	[thread overview]
Message-ID: <fb27e5cf-9056-3698-9e6f-9386f9cdf991@huawei.com> (raw)
In-Reply-To: <Y7174pEWZ8IzCdQ9@zn.tnic>


On 2023/1/10 22:53, Borislav Petkov wrote:
> On Tue, Jan 10, 2023 at 08:32:07PM +0800, Zeng Heng wrote:
>> And here is the context of mce-inject:
>>
>> #0  relocate_kernel () at arch/x86/kernel/relocate_kernel_64.S:55
>> #1  0xffffffff81a57fc2 in machine_kexec (image=0xffff888101ef8400)
>>      at arch/x86/kernel/machine_kexec_64.c:391
> Before we continue with this any further: are you doing this "exercise" in
> qemu/kvm and nothing of that is happening on real hardware?

Real hardware and QEMU both can reproduce the issue.

Here is description about NMI from Intel 64 and IA-32 Architectures 
Software Developer's Manual in chapter 6.7.1:

While an NMI interrupt handler is executing, the processor blocks 
delivery of subsequent NMIs until the next execu\x02tion of the IRET 
instruction. This blocking of NMIs prevents nested execution of the NMI 
handler. It is recommended that the NMI interrupt handler be accessed 
through an interrupt gate to disable maskable hardware interrupts (see 
Section 6.8.1, “Masking Maskable Hardware Interrupts”).


  reply	other threads:[~2023-01-11  3:46 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-10 10:27 [PATCH] x86/boot/compressed: Register NMI handler in EFI boot loader Zeng Heng
2023-01-10 10:59 ` Ingo Molnar
2023-01-10 12:01   ` [PATCH -v2] x86/boot/compressed: Register dummy NMI handler in EFI boot loader, to avoid kdump crashes Ingo Molnar
2023-01-10 12:11     ` Borislav Petkov
2023-01-10 12:17       ` Borislav Petkov
2023-01-10 12:34         ` Ingo Molnar
2023-01-10 12:46           ` Borislav Petkov
2023-01-10 12:50           ` Zeng Heng
2023-01-10 12:32       ` Zeng Heng
2023-01-10 12:57         ` Borislav Petkov
2023-01-10 13:42           ` Zeng Heng
2023-01-10 16:09           ` Borislav Petkov
2023-01-12  2:07             ` Zeng Heng
2023-01-10 14:53         ` Borislav Petkov
2023-01-11  3:46           ` Zeng Heng [this message]
2023-01-10 14:06     ` Zeng Heng
2023-01-10 11:41 ` [tip: x86/boot] " tip-bot2 for Zeng Heng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fb27e5cf-9056-3698-9e6f-9386f9cdf991@huawei.com \
    --to=zengheng4@huawei.com \
    --cc=bp@alien8.de \
    --cc=brijesh.singh@amd.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=jroedel@suse.de \
    --cc=keescook@chromium.org \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liwei391@huawei.com \
    --cc=michael.roth@amd.com \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®