From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Sylvain Petinot <sylvain.petinot@foss.st.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH v1 1/1] media: i2c: st-vgxy61: Use asm intead of asm-generic
Date: Wed, 4 Jan 2023 12:20:08 +0200 [thread overview]
Message-ID: <Y7VS2LuKGVQkcyrU@smile.fi.intel.com> (raw)
In-Reply-To: <b2ad42cb-fe09-73f5-8d7d-ac4f22817bac@foss.st.com>
On Wed, Jan 04, 2023 at 10:27:14AM +0100, Benjamin Mugnier wrote:
> On 1/3/23 15:52, Andy Shevchenko wrote:
...
> > -#include <asm-generic/unaligned.h>
> > #include <linux/clk.h>
> > #include <linux/delay.h>
> > #include <linux/gpio/consumer.h>
> > @@ -15,6 +14,9 @@
> > #include <linux/pm_runtime.h>
> > #include <linux/regulator/consumer.h>
> > #include <linux/units.h>
> > +
> > +#include <asm/unaligned.h>
> Any particular reason not to keep the alphabetical sort ?
It's kept in an order in each of the groups of headers.
The main rule here is to go from most generic headers to the particular ones.
asm/* are definitely more particular than linux/* ones.
> > #include <media/mipi-csi2.h>
> > #include <media/v4l2-async.h>
> > #include <media/v4l2-ctrls.h>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-01-04 10:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 14:52 Andy Shevchenko
2023-01-04 9:27 ` Benjamin Mugnier
2023-01-04 10:20 ` Andy Shevchenko [this message]
2023-01-04 13:22 ` Benjamin Mugnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7VS2LuKGVQkcyrU@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=benjamin.mugnier@foss.st.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sylvain.petinot@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®