* [PATCH] media: platform: ti: Add missing check for devm_regulator_get
@ 2023-01-04 8:55 Jiasheng Jiang
2023-01-04 12:25 ` Laurent Pinchart
0 siblings, 1 reply; 2+ messages in thread
From: Jiasheng Jiang @ 2023-01-04 8:55 UTC (permalink / raw)
To: laurent.pinchart, mchehab; +Cc: linux-media, linux-kernel, Jiasheng Jiang
Add check for the return value of devm_regulator_get since it may return
error pointer.
Fixes: 448de7e7850b ("[media] omap3isp: OMAP3 ISP core")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
drivers/media/platform/ti/omap3isp/isp.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/media/platform/ti/omap3isp/isp.c b/drivers/media/platform/ti/omap3isp/isp.c
index 1d40bb59ff81..e7327e38482d 100644
--- a/drivers/media/platform/ti/omap3isp/isp.c
+++ b/drivers/media/platform/ti/omap3isp/isp.c
@@ -2307,7 +2307,16 @@ static int isp_probe(struct platform_device *pdev)
/* Regulators */
isp->isp_csiphy1.vdd = devm_regulator_get(&pdev->dev, "vdd-csiphy1");
+ if (IS_ERR(isp->isp_csiphy1.vdd)) {
+ ret = PTR_ERR(isp->isp_csiphy1.vdd);
+ goto error;
+ }
+
isp->isp_csiphy2.vdd = devm_regulator_get(&pdev->dev, "vdd-csiphy2");
+ if (IS_ERR(isp->isp_csiphy2.vdd)) {
+ ret = PTR_ERR(isp->isp_csiphy2.vdd);
+ goto error;
+ }
/* Clocks
*
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] media: platform: ti: Add missing check for devm_regulator_get
2023-01-04 8:55 [PATCH] media: platform: ti: Add missing check for devm_regulator_get Jiasheng Jiang
@ 2023-01-04 12:25 ` Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2023-01-04 12:25 UTC (permalink / raw)
To: Jiasheng Jiang; +Cc: mchehab, linux-media, linux-kernel
Hi Jiasheng,
Thank you for the patch.
On Wed, Jan 04, 2023 at 04:55:37PM +0800, Jiasheng Jiang wrote:
> Add check for the return value of devm_regulator_get since it may return
> error pointer.
>
> Fixes: 448de7e7850b ("[media] omap3isp: OMAP3 ISP core")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/platform/ti/omap3isp/isp.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/media/platform/ti/omap3isp/isp.c b/drivers/media/platform/ti/omap3isp/isp.c
> index 1d40bb59ff81..e7327e38482d 100644
> --- a/drivers/media/platform/ti/omap3isp/isp.c
> +++ b/drivers/media/platform/ti/omap3isp/isp.c
> @@ -2307,7 +2307,16 @@ static int isp_probe(struct platform_device *pdev)
>
> /* Regulators */
> isp->isp_csiphy1.vdd = devm_regulator_get(&pdev->dev, "vdd-csiphy1");
> + if (IS_ERR(isp->isp_csiphy1.vdd)) {
> + ret = PTR_ERR(isp->isp_csiphy1.vdd);
> + goto error;
> + }
> +
> isp->isp_csiphy2.vdd = devm_regulator_get(&pdev->dev, "vdd-csiphy2");
> + if (IS_ERR(isp->isp_csiphy2.vdd)) {
> + ret = PTR_ERR(isp->isp_csiphy2.vdd);
> + goto error;
> + }
>
> /* Clocks
> *
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-04 12:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-04 8:55 [PATCH] media: platform: ti: Add missing check for devm_regulator_get Jiasheng Jiang
2023-01-04 12:25 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®