From: Tejun Heo <tj@kernel.org>
To: "Michal Koutný" <mkoutny@suse.com>
Cc: Yann Droneaud <ydroneaud@opteya.com>,
Josef Bacik <josef@toxicpanda.com>, Jens Axboe <axboe@kernel.dk>,
cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blk-iocost: don't make all constants unsigned long long
Date: Wed, 4 Jan 2023 12:15:06 -1000 [thread overview]
Message-ID: <Y7X6ajqnPrtFAL0C@slm.duckdns.org> (raw)
In-Reply-To: <20221222135855.GC20830@blackbody.suse.cz>
On Thu, Dec 22, 2022 at 02:58:55PM +0100, Michal Koutný wrote:
> On Tue, Dec 20, 2022 at 09:18:19PM +0100, Yann Droneaud <ydroneaud@opteya.com> wrote:
> > +enum {
> > /* switch iff the conditions are met for longer than this */
> > AUTOP_CYCLE_NSEC = 10LLU * NSEC_PER_SEC,
> > +};
>
> This looks gratuitous.
>
> What about indivudial #defines with typed literals instead of the "lazy
> splitting"?
enums are so much better for debugging and tracing. This is a gcc caused
problem where there's no other way to generate the same code between two gcc
versions without splitting the enum definitions. I'm kinda baffled that this
is what they chose to do but can't think of a better way to work around it.
Thanks.
--
tejun
next prev parent reply other threads:[~2023-01-04 22:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-20 20:18 Yann Droneaud
2022-12-22 13:58 ` Michal Koutný
2023-01-04 22:15 ` Tejun Heo [this message]
2023-01-04 22:17 ` Tejun Heo
2023-01-04 22:16 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7X6ajqnPrtFAL0C@slm.duckdns.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkoutny@suse.com \
--cc=ydroneaud@opteya.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®