From: "Michal Koutný" <mkoutny@suse.com>
To: Yann Droneaud <ydroneaud@opteya.com>
Cc: Tejun Heo <tj@kernel.org>, Josef Bacik <josef@toxicpanda.com>,
Jens Axboe <axboe@kernel.dk>,
cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blk-iocost: don't make all constants unsigned long long
Date: Thu, 22 Dec 2022 14:58:55 +0100 [thread overview]
Message-ID: <20221222135855.GC20830@blackbody.suse.cz> (raw)
In-Reply-To: <20221220201819.1497577-1-ydroneaud@opteya.com>
[-- Attachment #1: Type: text/plain, Size: 338 bytes --]
On Tue, Dec 20, 2022 at 09:18:19PM +0100, Yann Droneaud <ydroneaud@opteya.com> wrote:
> +enum {
> /* switch iff the conditions are met for longer than this */
> AUTOP_CYCLE_NSEC = 10LLU * NSEC_PER_SEC,
> +};
This looks gratuitous.
What about indivudial #defines with typed literals instead of the "lazy
splitting"?
Regards,
Michal
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2022-12-22 13:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-20 20:18 Yann Droneaud
2022-12-22 13:58 ` Michal Koutný [this message]
2023-01-04 22:15 ` Tejun Heo
2023-01-04 22:17 ` Tejun Heo
2023-01-04 22:16 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221222135855.GC20830@blackbody.suse.cz \
--to=mkoutny@suse.com \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=ydroneaud@opteya.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®