* [PATCH] test_kmod: stop kernel-doc warnings
@ 2023-01-02 21:16 Randy Dunlap
2023-01-04 19:52 ` Luis Chamberlain
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2023-01-02 21:16 UTC (permalink / raw)
To: linux-kernel; +Cc: Randy Dunlap, Luis Chamberlain, linux-modules
Use kernel-doc notation to prevent warnings:
lib/test_kmod.c:58: warning: contents before sections
lib/test_kmod.c:94: warning: cannot understand function prototype: 'struct kmod_test_device_info '
lib/test_kmod.c:119: warning: cannot understand function prototype: 'struct kmod_test_device '
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
---
lib/test_kmod.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff -- a/lib/test_kmod.c b/lib/test_kmod.c
--- a/lib/test_kmod.c
+++ b/lib/test_kmod.c
@@ -51,12 +51,11 @@ static int num_test_devs;
/**
* enum kmod_test_case - linker table test case
- *
- * If you add a test case, please be sure to review if you need to se
- * @need_mod_put for your tests case.
- *
* @TEST_KMOD_DRIVER: stress tests request_module()
* @TEST_KMOD_FS_TYPE: stress tests get_fs_type()
+ *
+ * If you add a test case, please be sure to review if you need to set
+ * @need_mod_put for your tests case.
*/
enum kmod_test_case {
__TEST_KMOD_INVALID = 0,
@@ -78,7 +77,7 @@ struct test_config {
struct kmod_test_device;
/**
- * kmod_test_device_info - thread info
+ * struct kmod_test_device_info - thread info
*
* @ret_sync: return value if request_module() is used, sync request for
* @TEST_KMOD_DRIVER
@@ -101,7 +100,7 @@ struct kmod_test_device_info {
};
/**
- * kmod_test_device - test device to help test kmod
+ * struct kmod_test_device - test device to help test kmod
*
* @dev_idx: unique ID for test device
* @config: configuration for the test
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] test_kmod: stop kernel-doc warnings
2023-01-02 21:16 [PATCH] test_kmod: stop kernel-doc warnings Randy Dunlap
@ 2023-01-04 19:52 ` Luis Chamberlain
0 siblings, 0 replies; 2+ messages in thread
From: Luis Chamberlain @ 2023-01-04 19:52 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-kernel, linux-modules
On Mon, Jan 02, 2023 at 01:16:05PM -0800, Randy Dunlap wrote:
> Use kernel-doc notation to prevent warnings:
>
> lib/test_kmod.c:58: warning: contents before sections
> lib/test_kmod.c:94: warning: cannot understand function prototype: 'struct kmod_test_device_info '
> lib/test_kmod.c:119: warning: cannot understand function prototype: 'struct kmod_test_device '
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: linux-modules@vger.kernel.org
Applied onto modules-next, thanks!
Luis
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-04 19:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-02 21:16 [PATCH] test_kmod: stop kernel-doc warnings Randy Dunlap
2023-01-04 19:52 ` Luis Chamberlain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®