From: Sam Ravnborg <sam@ravnborg.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
linux-kernel@vger.kernel.org, patches@lists.linux.dev,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
yangcong <yangcong5@huaqin.corp-partner.google.com>,
Douglas Anderson <dianders@chromium.org>,
Jitao Shi <jitao.shi@mediatek.com>,
Rob Clark <robdclark@chromium.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Subject: Re: [PATCH] drm/panel: boe-tv101wum-nl6: Ensure DSI writes succeed during disable
Date: Fri, 13 Jan 2023 15:52:09 +0100 [thread overview]
Message-ID: <Y8FwGTWeYtX0j8MX@ravnborg.org> (raw)
In-Reply-To: <CAE-0n50QOv_+j1Pe19xKj4Cx2Y5_Ak5Kt68UBJuZt10D-jQ44g@mail.gmail.com>
Hi Stephen,
On Tue, Jan 10, 2023 at 11:29:41AM -0800, Stephen Boyd wrote:
> Quoting Sam Ravnborg (2023-01-07 12:28:41)
>
> >
> > For this case we could ask ourself if the display needs to enter sleep
> > mode right before we disable the regulator. But if the regulator is
> > fixed, so the disable has no effect, this seems OK.
>
> What do you mean by fixed?
What I tried to say here is if we have a fixed regulator - or in others
words a supply voltage we cannot turn off, then entering sleep mode is
important to reduce power consumption.
But any sane design where power consumption is a concern will have the
possibility to turn off the power anyway.
>
> >
> > Please fix the unprepare to not jump out early, on top of or together
> > with the other fix.
>
> After this patch the unprepare only bails out early if the bool
> 'prepared' flag isn't set.
OK, then everything is fine.
Sam
next prev parent reply other threads:[~2023-01-13 15:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 3:01 Stephen Boyd
2023-01-07 20:28 ` Sam Ravnborg
2023-01-10 19:29 ` Stephen Boyd
2023-01-13 14:52 ` Sam Ravnborg [this message]
2023-01-13 20:49 ` Stephen Boyd
2023-01-18 18:24 ` Stephen Boyd
2023-01-13 16:27 ` Dave Stevenson
2023-01-13 21:12 ` Stephen Boyd
2023-01-16 14:11 ` Dave Stevenson
2023-01-18 4:50 ` Stephen Boyd
2023-01-18 21:34 ` Doug Anderson
2023-01-27 0:52 ` Doug Anderson
2023-01-31 21:27 ` Doug Anderson
2023-02-01 11:02 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8FwGTWeYtX0j8MX@ravnborg.org \
--to=sam@ravnborg.org \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jitao.shi@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=patches@lists.linux.dev \
--cc=robdclark@chromium.org \
--cc=swboyd@chromium.org \
--cc=thierry.reding@gmail.com \
--cc=yangcong5@huaqin.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®