* [PATCH] block: Remove mm.h from bvec.h
@ 2023-01-31 5:01 Matthew Wilcox (Oracle)
2023-01-31 9:00 ` Christoph Hellwig
2023-01-31 18:02 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Matthew Wilcox (Oracle) @ 2023-01-31 5:01 UTC (permalink / raw)
To: linux-kernel, Jens Axboe, linux-block; +Cc: Matthew Wilcox (Oracle)
This was originally added for the definition of nth_page(), but we no
longer use nth_page() in this header, so we can drop the heavyweight
mm.h now.
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
include/linux/bvec.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/bvec.h b/include/linux/bvec.h
index 35c25dff651a..7939b345ee7f 100644
--- a/include/linux/bvec.h
+++ b/include/linux/bvec.h
@@ -12,7 +12,6 @@
#include <linux/errno.h>
#include <linux/limits.h>
#include <linux/minmax.h>
-#include <linux/mm.h>
#include <linux/types.h>
struct page;
--
2.35.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] block: Remove mm.h from bvec.h
2023-01-31 5:01 [PATCH] block: Remove mm.h from bvec.h Matthew Wilcox (Oracle)
@ 2023-01-31 9:00 ` Christoph Hellwig
2023-01-31 18:02 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2023-01-31 9:00 UTC (permalink / raw)
To: Matthew Wilcox (Oracle); +Cc: linux-kernel, Jens Axboe, linux-block
On Tue, Jan 31, 2023 at 05:01:32AM +0000, Matthew Wilcox (Oracle) wrote:
> This was originally added for the definition of nth_page(), but we no
> longer use nth_page() in this header, so we can drop the heavyweight
> mm.h now.
I'm for this, but I'd really prefer to have this survive the build bot
for a few days and random builds as there could be users that are
missing the explicit include by now. And someone the buildbot seems
down or overloaded lately :(
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] block: Remove mm.h from bvec.h
2023-01-31 5:01 [PATCH] block: Remove mm.h from bvec.h Matthew Wilcox (Oracle)
2023-01-31 9:00 ` Christoph Hellwig
@ 2023-01-31 18:02 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2023-01-31 18:02 UTC (permalink / raw)
To: linux-kernel, linux-block, Matthew Wilcox (Oracle)
On Tue, 31 Jan 2023 05:01:32 +0000, Matthew Wilcox (Oracle) wrote:
> This was originally added for the definition of nth_page(), but we no
> longer use nth_page() in this header, so we can drop the heavyweight
> mm.h now.
>
>
Applied, thanks!
[1/1] block: Remove mm.h from bvec.h
commit: 2d97930d74b12467fd5f48d8560e48c1cf5edcb1
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-31 18:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-31 5:01 [PATCH] block: Remove mm.h from bvec.h Matthew Wilcox (Oracle)
2023-01-31 9:00 ` Christoph Hellwig
2023-01-31 18:02 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®