From: Mark Brown <broonie@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: David Rau <david.rau.zg@renesas.com>,
"perex@perex.cz" <perex@perex.cz>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"tiwai@suse.com" <tiwai@suse.com>,
"support.opensource@diasemi.com" <support.opensource@diasemi.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: da7219: Fix pole orientation detection on OMTP headsets when playing music
Date: Tue, 31 Jan 2023 12:08:53 +0000 [thread overview]
Message-ID: <Y9kE1cSUg2CQM5vq@sirena.org.uk> (raw)
In-Reply-To: <38f09c4d-70d1-f65f-6e9b-4ad84eda4059@roeck-us.net>
[-- Attachment #1: Type: text/plain, Size: 835 bytes --]
On Mon, Jan 30, 2023 at 10:16:06PM -0800, Guenter Roeck wrote:
> On 1/30/23 19:58, David Rau wrote:
> > Thanks for the kind feedback.
> > Would you please let me know what kinds of environment such error appears you ever meet?
> > Ex: da7219_aad->gnd_switch_delay = ?
> We are seeing the problem on various Chromebooks.
> Never mind, though. I really don't have time to keep arguing about this.
> I would have assumed that it is obvious that a long msleep() in an
> interrupt handler is not appropriate, but obviously I was wrong.
This is a threaded interrupt handler so it's a bit less clear that it's
meaningfully different to just disabling the interrupt for debounce or
whatever. Not to say it's ideal.
> I'll see if I can implement a downstream fix.
If you implement something I don't see a reason not to post it upstream.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-01-31 12:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 5:07 David Rau
2022-12-01 13:24 ` Mark Brown
2023-01-17 19:56 ` Guenter Roeck
2023-01-19 11:02 ` David Rau
2023-01-19 16:12 ` Guenter Roeck
2023-01-31 3:58 ` David Rau
2023-01-31 6:16 ` Guenter Roeck
2023-01-31 12:08 ` Mark Brown [this message]
2023-02-02 15:51 ` Guenter Roeck
2023-02-02 17:04 ` Mark Brown
2023-02-02 18:39 ` Guenter Roeck
2023-02-02 19:36 ` Mark Brown
2023-02-04 15:42 ` Guenter Roeck
2023-02-06 5:38 ` David Rau
2023-02-06 14:04 ` Guenter Roeck
2023-02-07 2:42 ` David Rau
2023-02-07 2:48 ` Guenter Roeck
2023-02-08 18:04 ` Guenter Roeck
2023-02-09 3:05 ` David Rau
2023-02-09 3:32 ` Guenter Roeck
2023-02-06 13:37 ` Mark Brown
2023-02-06 1:05 ` David Rau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9kE1cSUg2CQM5vq@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=david.rau.zg@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=perex@perex.cz \
--cc=support.opensource@diasemi.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®