From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Helen Koike <helen.koike@collabora.com>
Cc: linux-media@vger.kernel.org, hverkuil@xs4all.nl,
hans.verkuil@cisco.com, kernel@collabora.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] media: doc: pixfmt-yuv: Fix 4:4:4 subsampling info
Date: Mon, 25 Jan 2021 16:15:17 +0200 [thread overview]
Message-ID: <YA7SdYmQrw/BsPJp@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20210125141029.16481-1-helen.koike@collabora.com>
Hi Helen,
Thank you for the patch.
On Mon, Jan 25, 2021 at 11:10:29AM -0300, Helen Koike wrote:
> YUV 4:4:4 is not subsampled, fix this in the docs.
>
> Fixes: da785536e007 ("media: doc: pixfmt-yuv: Move all semi-planar YUV formats to common file")
> Signed-off-by: Helen Koike <helen.koike@collabora.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Changes in v2:
>
> - s/No sub-sampling/The chroma plane is not subsampled/ (Laurent)
> - Fixed description regarding the number of bytes (Laurent)
> ---
> Documentation/userspace-api/media/v4l/pixfmt-yuv-planar.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/userspace-api/media/v4l/pixfmt-yuv-planar.rst b/Documentation/userspace-api/media/v4l/pixfmt-yuv-planar.rst
> index 7d4d39201a3f..1e0db602cc1b 100644
> --- a/Documentation/userspace-api/media/v4l/pixfmt-yuv-planar.rst
> +++ b/Documentation/userspace-api/media/v4l/pixfmt-yuv-planar.rst
> @@ -396,9 +396,9 @@ number of lines as the luma plane.
> NV24 and NV42
> -------------
>
> -Semi-planar YUV 4:4:4 formats. The chroma plane is subsampled by 2 in the
> -horizontal direction. Chroma lines contain half the number of pixels and the
> -same number of bytes as luma lines, and the chroma plane contains the same
> +Semi-planar YUV 4:4:4 formats. The chroma plane is not subsampled.
> +Chroma lines contain the same number of pixels and twice the
> +number of bytes as luma lines, and the chroma plane contains the same
> number of lines as the luma plane.
>
> .. flat-table:: Sample 4x4 NV24 Image
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2021-01-26 2:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 14:10 Helen Koike
2021-01-25 14:15 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YA7SdYmQrw/BsPJp@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=hans.verkuil@cisco.com \
--cc=helen.koike@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®