From: Greg KH <gregkh@linuxfoundation.org>
To: Kumar Kartikeya Dwivedi <memxor@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH v3] staging: emxx_udc: Make incorrectly defined global static
Date: Sun, 7 Feb 2021 10:18:01 +0100 [thread overview]
Message-ID: <YB+wSYgNABzNWFfb@kroah.com> (raw)
In-Reply-To: <20210207085911.270746-1-memxor@gmail.com>
On Sun, Feb 07, 2021 at 02:29:12PM +0530, Kumar Kartikeya Dwivedi wrote:
> The global gpio_desc pointer and int vbus_irq were defined in the header,
> instead put the definitions in the translation unit and make them static as
> there's only a single consumer, and these symbols shouldn't pollute the
> global namespace.
>
> This fixes the following sparse warnings for this driver:
> drivers/staging/emxx_udc/emxx_udc.c: note: in included file:
> drivers/staging/emxx_udc/emxx_udc.h:23:18: warning: symbol 'vbus_gpio' was not
> declared. Should it be static? drivers/staging/emxx_udc/emxx_udc.h:24:5:
> warning: symbol 'vbus_irq' was not declared. Should it be static?
>
> Signed-off-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
> ---
> Changes in v1:
> Switch to variable with static linkage instead of extern
> Changes in v2:
> Resend a versioned patch
> Changes in v3:
> Include version changelog below the marker
Much better, thanks, now queued up.
greg k-h
next prev parent reply other threads:[~2021-02-07 9:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-07 0:00 [PATCH] staging: emxx_udc: Fix incorrectly defined global Kumar Kartikeya Dwivedi
2021-02-07 6:34 ` Stephen Rothwell
2021-02-07 7:38 ` Kumar Kartikeya Dwivedi
2021-02-07 8:33 ` Greg KH
2021-02-07 8:46 ` [PATCH v2] staging: emxx_udc: Make incorrectly defined global static Kumar Kartikeya Dwivedi
2021-02-07 8:51 ` Greg KH
2021-02-07 8:59 ` [PATCH v3] " Kumar Kartikeya Dwivedi
2021-02-07 9:18 ` Greg KH [this message]
2021-02-08 10:18 ` [PATCH] staging: emxx_udc: Fix incorrectly defined global Geert Uytterhoeven
2021-02-07 8:31 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YB+wSYgNABzNWFfb@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=memxor@gmail.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®