mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Kumar Kartikeya Dwivedi <memxor@gmail.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: emxx_udc: Fix incorrectly defined global
Date: Sun, 7 Feb 2021 09:33:26 +0100	[thread overview]
Message-ID: <YB+l1t/k4VuSw3B9@kroah.com> (raw)
In-Reply-To: <20210207073827.7l7h3475tqgxxfte@apollo>

On Sun, Feb 07, 2021 at 01:08:27PM +0530, Kumar Kartikeya Dwivedi wrote:
> On Sun, Feb 07, 2021 at 12:04:41PM IST, Stephen Rothwell wrote:
> > 
> > Given that drivers/staging/emxx_udc/emxx_udc.h is only included by
> > drivers/staging/emxx_udc/emxx_udc.c, shouldn't these variables just be
> > declared static in emxx_udc.c and removed from emxx_udc.h?
> >
> 
> Either would be correct. I went this way because it was originally trying to
> (incorrectly) define a global variable instead. I guess they can be static now
> and when more users are added, the linkage can be adjusted as needed.
> 
> Here's another version of the patch:

<snip>

Please resend in the proper format that a second version of a patch
should be in (the documentation describes how to do this.)

thanks,

greg k-h

  reply	other threads:[~2021-02-07  8:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-07  0:00 Kumar Kartikeya Dwivedi
2021-02-07  6:34 ` Stephen Rothwell
2021-02-07  7:38   ` Kumar Kartikeya Dwivedi
2021-02-07  8:33     ` Greg KH [this message]
2021-02-07  8:46       ` [PATCH v2] staging: emxx_udc: Make incorrectly defined global static Kumar Kartikeya Dwivedi
2021-02-07  8:51         ` Greg KH
2021-02-07  8:59           ` [PATCH v3] " Kumar Kartikeya Dwivedi
2021-02-07  9:18             ` Greg KH
2021-02-08 10:18     ` [PATCH] staging: emxx_udc: Fix incorrectly defined global Geert Uytterhoeven
2021-02-07  8:31 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YB+l1t/k4VuSw3B9@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=memxor@gmail.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®