mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH -next] usb: gadget: Remove unused including <linux/version.h>
@ 2021-01-25 12:41 Zou Wei
  2021-01-26 17:39 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Zou Wei @ 2021-01-25 12:41 UTC (permalink / raw)
  To: balbi, gregkh, joel, andrew, benh, sashal
  Cc: rentao.bupt, linux-usb, linux-arm-kernel, linux-aspeed,
	linux-kernel, Zou Wei

Fix the following versioncheck warning:

drivers/usb/gadget/udc/aspeed-vhub/hub.c:33:1: unused including <linux/version.h>

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
 drivers/usb/gadget/udc/aspeed-vhub/hub.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/aspeed-vhub/hub.c b/drivers/usb/gadget/udc/aspeed-vhub/hub.c
index 396a7d8..b192d57 100644
--- a/drivers/usb/gadget/udc/aspeed-vhub/hub.c
+++ b/drivers/usb/gadget/udc/aspeed-vhub/hub.c
@@ -30,7 +30,6 @@
 #include <linux/regmap.h>
 #include <linux/dma-mapping.h>
 #include <linux/bcd.h>
-#include <linux/version.h>
 #include <linux/usb.h>
 #include <linux/usb/hcd.h>
 
-- 
2.6.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] usb: gadget: Remove unused including <linux/version.h>
  2021-01-25 12:41 [PATCH -next] usb: gadget: Remove unused including <linux/version.h> Zou Wei
@ 2021-01-26 17:39 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2021-01-26 17:39 UTC (permalink / raw)
  To: Zou Wei
  Cc: balbi, joel, andrew, benh, sashal, rentao.bupt, linux-usb,
	linux-arm-kernel, linux-aspeed, linux-kernel

On Mon, Jan 25, 2021 at 08:41:32PM +0800, Zou Wei wrote:
> Fix the following versioncheck warning:
> 
> drivers/usb/gadget/udc/aspeed-vhub/hub.c:33:1: unused including <linux/version.h>
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
>  drivers/usb/gadget/udc/aspeed-vhub/hub.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/udc/aspeed-vhub/hub.c b/drivers/usb/gadget/udc/aspeed-vhub/hub.c
> index 396a7d8..b192d57 100644
> --- a/drivers/usb/gadget/udc/aspeed-vhub/hub.c
> +++ b/drivers/usb/gadget/udc/aspeed-vhub/hub.c
> @@ -30,7 +30,6 @@
>  #include <linux/regmap.h>
>  #include <linux/dma-mapping.h>
>  #include <linux/bcd.h>
> -#include <linux/version.h>
>  #include <linux/usb.h>
>  #include <linux/usb/hcd.h>

You didn't test this patch either :(

Your script is not correct...

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-01-26 18:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-25 12:41 [PATCH -next] usb: gadget: Remove unused including <linux/version.h> Zou Wei
2021-01-26 17:39 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®