From: Andrew Lunn <andrew@lunn.ch>
To: Prasanna Vengateshan <prasanna.vengateshan@microchip.com>
Cc: olteanv@gmail.com, netdev@vger.kernel.org, robh+dt@kernel.org,
kuba@kernel.org, vivien.didelot@gmail.com, f.fainelli@gmail.com,
davem@davemloft.net, UNGLinuxDriver@microchip.com,
Woojung.Huh@microchip.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH net-next 4/8] net: dsa: microchip: add support for phylink management
Date: Fri, 29 Jan 2021 02:12:06 +0100 [thread overview]
Message-ID: <YBNg5iRtKp9Twqpe@lunn.ch> (raw)
In-Reply-To: <20210128064112.372883-5-prasanna.vengateshan@microchip.com>
> + /* For T1 PHY */
> + if (lan937x_is_internal_t1_phy_port(dev, port)) {
> + phylink_set(mask, 100baseT_Full);
> + phylink_set_port_modes(mask);
Since this is a T1 PHY, you should be using 100baseT1_Full.
This might be the first user of this for phylink, so please test this
actually works.
Andrew
next prev parent reply other threads:[~2021-01-29 1:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 6:41 [PATCH net-next 0/8] net: dsa: microchip: DSA driver support for LAN937x switch Prasanna Vengateshan
2021-01-28 6:41 ` [PATCH net-next 1/8] dt-bindings: net: dsa: dt bindings for microchip lan937x Prasanna Vengateshan
2021-01-30 2:02 ` Vladimir Oltean
2021-02-10 11:46 ` Prasanna Vengateshan Varadharajan
2021-02-10 18:57 ` Andrew Lunn
2021-02-09 19:35 ` Rob Herring
2021-01-28 6:41 ` [PATCH net-next 2/8] net: dsa: tag_ksz: add tag handling for Microchip LAN937x Prasanna Vengateshan
2021-01-28 18:03 ` Andrew Lunn
2021-01-30 2:27 ` Vladimir Oltean
2021-02-10 11:55 ` Prasanna Vengateshan Varadharajan
2021-01-28 6:41 ` [PATCH net-next 3/8] net: dsa: microchip: add DSA support for microchip lan937x Prasanna Vengateshan
2021-01-29 1:07 ` Andrew Lunn
2021-02-05 12:48 ` Prasanna Vengateshan Varadharajan
2021-02-05 13:27 ` Andrew Lunn
2021-03-15 6:25 ` Prasanna Vengateshan Varadharajan
2021-01-28 6:41 ` [PATCH net-next 4/8] net: dsa: microchip: add support for phylink management Prasanna Vengateshan
2021-01-29 1:12 ` Andrew Lunn [this message]
2021-01-28 6:41 ` [PATCH net-next 5/8] net: dsa: microchip: add support for ethtool port counters Prasanna Vengateshan
2021-01-28 6:41 ` [PATCH net-next 6/8] net: dsa: microchip: add support for port mirror operations Prasanna Vengateshan
2021-01-28 6:41 ` [PATCH net-next 7/8] net: dsa: microchip: add support for fdb and mdb management Prasanna Vengateshan
2021-01-28 6:41 ` [PATCH net-next 8/8] net: dsa: microchip: add support for vlan operations Prasanna Vengateshan
2021-01-28 17:55 ` [PATCH net-next 0/8] net: dsa: microchip: DSA driver support for LAN937x switch Florian Fainelli
2021-01-30 2:09 ` Vladimir Oltean
2021-02-02 1:25 ` Woojung.Huh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBNg5iRtKp9Twqpe@lunn.ch \
--to=andrew@lunn.ch \
--cc=UNGLinuxDriver@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=prasanna.vengateshan@microchip.com \
--cc=robh+dt@kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®