* [PATCH] misc: pvpanic: sysfs_emit uses should have a newline
@ 2021-01-29 19:08 Joe Perches
2021-02-01 1:56 ` [External] " zhenwei pi
0 siblings, 1 reply; 4+ messages in thread
From: Joe Perches @ 2021-01-29 19:08 UTC (permalink / raw)
To: zhenwei pi; +Cc: Paolo Bonzini, Greg Kroah-Hartman, LKML
Add newline terminations to the sysfs_emit uses added by -next
commit 8d6da6575ffe ("misc: pvpanic: introduce events device attribue")
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/misc/pvpanic.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c
index b1e4922a7fda..9f350e05ef68 100644
--- a/drivers/misc/pvpanic.c
+++ b/drivers/misc/pvpanic.c
@@ -25,13 +25,13 @@ static unsigned int events;
static ssize_t capability_show(struct device *dev,
struct device_attribute *attr, char *buf)
{
- return sysfs_emit(buf, "%x", capability);
+ return sysfs_emit(buf, "%x\n", capability);
}
static DEVICE_ATTR_RO(capability);
static ssize_t events_show(struct device *dev, struct device_attribute *attr, char *buf)
{
- return sysfs_emit(buf, "%x", events);
+ return sysfs_emit(buf, "%x\n", events);
}
static ssize_t events_store(struct device *dev, struct device_attribute *attr,
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [External] [PATCH] misc: pvpanic: sysfs_emit uses should have a newline
2021-01-29 19:08 [PATCH] misc: pvpanic: sysfs_emit uses should have a newline Joe Perches
@ 2021-02-01 1:56 ` zhenwei pi
2021-02-03 14:57 ` Greg Kroah-Hartman
0 siblings, 1 reply; 4+ messages in thread
From: zhenwei pi @ 2021-02-01 1:56 UTC (permalink / raw)
To: Joe Perches; +Cc: Greg Kroah-Hartman, LKML
On 1/30/21 3:08 AM, Joe Perches wrote:
> Add newline terminations to the sysfs_emit uses added by -next
> commit 8d6da6575ffe ("misc: pvpanic: introduce events device attribue")
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> drivers/misc/pvpanic.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c
> index b1e4922a7fda..9f350e05ef68 100644
> --- a/drivers/misc/pvpanic.c
> +++ b/drivers/misc/pvpanic.c
> @@ -25,13 +25,13 @@ static unsigned int events;
> static ssize_t capability_show(struct device *dev,
> struct device_attribute *attr, char *buf)
> {
> - return sysfs_emit(buf, "%x", capability);
> + return sysfs_emit(buf, "%x\n", capability);
> }
> static DEVICE_ATTR_RO(capability);
>
> static ssize_t events_show(struct device *dev, struct device_attribute *attr, char *buf)
> {
> - return sysfs_emit(buf, "%x", events);
> + return sysfs_emit(buf, "%x\n", events);
> }
>
> static ssize_t events_store(struct device *dev, struct device_attribute *attr,
>
>
Hi, Greg is the maintainer of this driver.
--
zhenwei pi
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [External] [PATCH] misc: pvpanic: sysfs_emit uses should have a newline
2021-02-01 1:56 ` [External] " zhenwei pi
@ 2021-02-03 14:57 ` Greg Kroah-Hartman
2021-02-04 1:58 ` zhenwei pi
0 siblings, 1 reply; 4+ messages in thread
From: Greg Kroah-Hartman @ 2021-02-03 14:57 UTC (permalink / raw)
To: zhenwei pi; +Cc: Joe Perches, LKML
On Mon, Feb 01, 2021 at 09:56:57AM +0800, zhenwei pi wrote:
> On 1/30/21 3:08 AM, Joe Perches wrote:
> > Add newline terminations to the sysfs_emit uses added by -next
> > commit 8d6da6575ffe ("misc: pvpanic: introduce events device attribue")
> >
> > Signed-off-by: Joe Perches <joe@perches.com>
> > ---
> > drivers/misc/pvpanic.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c
> > index b1e4922a7fda..9f350e05ef68 100644
> > --- a/drivers/misc/pvpanic.c
> > +++ b/drivers/misc/pvpanic.c
> > @@ -25,13 +25,13 @@ static unsigned int events;
> > static ssize_t capability_show(struct device *dev,
> > struct device_attribute *attr, char *buf)
> > {
> > - return sysfs_emit(buf, "%x", capability);
> > + return sysfs_emit(buf, "%x\n", capability);
> > }
> > static DEVICE_ATTR_RO(capability);
> > static ssize_t events_show(struct device *dev, struct device_attribute *attr, char *buf)
> > {
> > - return sysfs_emit(buf, "%x", events);
> > + return sysfs_emit(buf, "%x\n", events);
> > }
> > static ssize_t events_store(struct device *dev, struct device_attribute *attr,
> >
> >
>
> Hi, Greg is the maintainer of this driver.
No I am not:
$ ./scripts/get_maintainer.pl drivers/misc/pvpanic.c
Arnd Bergmann <arnd@arndb.de> (supporter:CHAR and MISC DRIVERS)
Greg Kroah-Hartman <gregkh@linuxfoundation.org> (supporter:CHAR and MISC DRIVERS)
linux-kernel@vger.kernel.org (open list)
As the developer of this driver, it would be great if you
could review the change and provide a "Signed-off-by" line that I can
use to accept this patch.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] misc: pvpanic: sysfs_emit uses should have a newline
2021-02-03 14:57 ` Greg Kroah-Hartman
@ 2021-02-04 1:58 ` zhenwei pi
0 siblings, 0 replies; 4+ messages in thread
From: zhenwei pi @ 2021-02-04 1:58 UTC (permalink / raw)
To: Joe Perches; +Cc: Greg Kroah-Hartman, LKML
On 2/3/21 10:57 PM, Greg Kroah-Hartman wrote:
> On Mon, Feb 01, 2021 at 09:56:57AM +0800, zhenwei pi wrote:
>> On 1/30/21 3:08 AM, Joe Perches wrote:
>>> Add newline terminations to the sysfs_emit uses added by -next
>>> commit 8d6da6575ffe ("misc: pvpanic: introduce events device attribue")
>>>
>>> Signed-off-by: Joe Perches <joe@perches.com>
>>> ---
>>> drivers/misc/pvpanic.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c
>>> index b1e4922a7fda..9f350e05ef68 100644
>>> --- a/drivers/misc/pvpanic.c
>>> +++ b/drivers/misc/pvpanic.c
>>> @@ -25,13 +25,13 @@ static unsigned int events;
>>> static ssize_t capability_show(struct device *dev,
>>> struct device_attribute *attr, char *buf)
>>> {
>>> - return sysfs_emit(buf, "%x", capability);
>>> + return sysfs_emit(buf, "%x\n", capability);
>>> }
>>> static DEVICE_ATTR_RO(capability);
>>> static ssize_t events_show(struct device *dev, struct device_attribute *attr, char *buf)
>>> {
>>> - return sysfs_emit(buf, "%x", events);
>>> + return sysfs_emit(buf, "%x\n", events);
>>> }
>>> static ssize_t events_store(struct device *dev, struct device_attribute *attr,
>>>
>>>
>>
>> Hi, Greg is the maintainer of this driver.
>
> No I am not:
> $ ./scripts/get_maintainer.pl drivers/misc/pvpanic.c
> Arnd Bergmann <arnd@arndb.de> (supporter:CHAR and MISC DRIVERS)
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> (supporter:CHAR and MISC DRIVERS)
> linux-kernel@vger.kernel.org (open list)
>
> As the developer of this driver, it would be great if you
> could review the change and provide a "Signed-off-by" line that I can
> use to accept this patch.
>
> thanks,
>
> greg k-h
>
Commit 8d6da6575ffe ("misc: pvpanic: introduce events device attribue")
is not merged into upstream currently, so this change should not affect
the up layer users. It looks good to me.
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
--
zhenwei pi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-04 1:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-29 19:08 [PATCH] misc: pvpanic: sysfs_emit uses should have a newline Joe Perches
2021-02-01 1:56 ` [External] " zhenwei pi
2021-02-03 14:57 ` Greg Kroah-Hartman
2021-02-04 1:58 ` zhenwei pi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®