* [PATCH] perf metricgroup: remove unneeded semicolon
@ 2021-02-01 7:41 Yang Li
2021-02-16 7:34 ` Namhyung Kim
0 siblings, 1 reply; 3+ messages in thread
From: Yang Li @ 2021-02-01 7:41 UTC (permalink / raw)
To: peterz
Cc: mingo, acme, mark.rutland, alexander.shishkin, jolsa, namhyung,
linux-kernel, Yang Li
Eliminate the following coccicheck warning:
./tools/perf/util/metricgroup.c:382:3-4: Unneeded semicolon
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
tools/perf/util/metricgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c
index e6d3452..26c990e 100644
--- a/tools/perf/util/metricgroup.c
+++ b/tools/perf/util/metricgroup.c
@@ -379,7 +379,7 @@ static int metricgroup__setup_events(struct list_head *groups,
metric_refs[i].metric_expr = ref->metric_expr;
i++;
}
- };
+ }
expr->metric_refs = metric_refs;
expr->metric_expr = m->metric_expr;
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] perf metricgroup: remove unneeded semicolon
2021-02-01 7:41 [PATCH] perf metricgroup: remove unneeded semicolon Yang Li
@ 2021-02-16 7:34 ` Namhyung Kim
2021-02-17 18:20 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 3+ messages in thread
From: Namhyung Kim @ 2021-02-16 7:34 UTC (permalink / raw)
To: Yang Li
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, linux-kernel
Hello,
On Mon, Feb 1, 2021 at 4:41 PM Yang Li <yang.lee@linux.alibaba.com> wrote:
>
> Eliminate the following coccicheck warning:
> ./tools/perf/util/metricgroup.c:382:3-4: Unneeded semicolon
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks,
Namhyung
> ---
> tools/perf/util/metricgroup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c
> index e6d3452..26c990e 100644
> --- a/tools/perf/util/metricgroup.c
> +++ b/tools/perf/util/metricgroup.c
> @@ -379,7 +379,7 @@ static int metricgroup__setup_events(struct list_head *groups,
> metric_refs[i].metric_expr = ref->metric_expr;
> i++;
> }
> - };
> + }
>
> expr->metric_refs = metric_refs;
> expr->metric_expr = m->metric_expr;
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] perf metricgroup: remove unneeded semicolon
2021-02-16 7:34 ` Namhyung Kim
@ 2021-02-17 18:20 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2021-02-17 18:20 UTC (permalink / raw)
To: Namhyung Kim
Cc: Yang Li, Peter Zijlstra, Ingo Molnar, Mark Rutland,
Alexander Shishkin, Jiri Olsa, linux-kernel
Em Tue, Feb 16, 2021 at 04:34:25PM +0900, Namhyung Kim escreveu:
> Hello,
>
> On Mon, Feb 1, 2021 at 4:41 PM Yang Li <yang.lee@linux.alibaba.com> wrote:
> >
> > Eliminate the following coccicheck warning:
> > ./tools/perf/util/metricgroup.c:382:3-4: Unneeded semicolon
> >
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
>
> Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks, applied.
- Arnaldo
> Thanks,
> Namhyung
>
> > ---
> > tools/perf/util/metricgroup.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c
> > index e6d3452..26c990e 100644
> > --- a/tools/perf/util/metricgroup.c
> > +++ b/tools/perf/util/metricgroup.c
> > @@ -379,7 +379,7 @@ static int metricgroup__setup_events(struct list_head *groups,
> > metric_refs[i].metric_expr = ref->metric_expr;
> > i++;
> > }
> > - };
> > + }
> >
> > expr->metric_refs = metric_refs;
> > expr->metric_expr = m->metric_expr;
> > --
> > 1.8.3.1
> >
--
- Arnaldo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-17 18:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-01 7:41 [PATCH] perf metricgroup: remove unneeded semicolon Yang Li
2021-02-16 7:34 ` Namhyung Kim
2021-02-17 18:20 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome