mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johannes Weiner <hannes@cmpxchg.org>
To: Chengming Zhou <zhouchengming@bytedance.com>
Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
	vincent.guittot@linaro.org, rostedt@goodmis.org,
	dietmar.eggemann@arm.com, linux-kernel@vger.kernel.org,
	songmuchun@bytedance.com
Subject: Re: [PATCH] psi: Add PSI_CPU_FULL state
Date: Mon, 8 Feb 2021 13:18:08 -0500	[thread overview]
Message-ID: <YCGAYEiyTKCO71E3@cmpxchg.org> (raw)
In-Reply-To: <20210207072402.67532-1-zhouchengming@bytedance.com>

On Sun, Feb 07, 2021 at 03:24:02PM +0800, Chengming Zhou wrote:
> The FULL state doesn't exist for the CPU resource at the system level,
> but exist at the cgroup level, means all non-idle tasks in a cgroup are
> delayed on the CPU resource which used by others outside of the cgroup.
> 
> Co-developed-by: Muchun Song <songmuchun@bytedance.com>
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>

Acked-by: Johannes Weiner <hannes@cmpxchg.org>

That metric's come up in our production environment recently as well,
it makes a lot of sense.

In addition to outside competition, this also applies to downtimes
enforced by cpu.max - another cgroup usecase that is worth mentioning
in the changelog & code comment.

Thanks

  reply	other threads:[~2021-02-08 19:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-07  7:24 Chengming Zhou
2021-02-08 18:18 ` Johannes Weiner [this message]
2021-02-09  1:49   ` [External] " Chengming Zhou
  -- strict thread matches above, loose matches on Subject: below --
2020-12-25  4:22 Chengming Zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YCGAYEiyTKCO71E3@cmpxchg.org \
    --to=hannes@cmpxchg.org \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=songmuchun@bytedance.com \
    --cc=vincent.guittot@linaro.org \
    --cc=zhouchengming@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®