From: Chengming Zhou <zhouchengming@bytedance.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, rostedt@goodmis.org,
dietmar.eggemann@arm.com, linux-kernel@vger.kernel.org,
songmuchun@bytedance.com
Subject: Re: [External] Re: [PATCH] psi: Add PSI_CPU_FULL state
Date: Tue, 9 Feb 2021 09:49:34 +0800 [thread overview]
Message-ID: <2cb984f3-fb8b-df26-31a2-8a091213d87e@bytedance.com> (raw)
In-Reply-To: <YCGAYEiyTKCO71E3@cmpxchg.org>
在 2021/2/9 上午2:18, Johannes Weiner 写道:
> On Sun, Feb 07, 2021 at 03:24:02PM +0800, Chengming Zhou wrote:
>> The FULL state doesn't exist for the CPU resource at the system level,
>> but exist at the cgroup level, means all non-idle tasks in a cgroup are
>> delayed on the CPU resource which used by others outside of the cgroup.
>>
>> Co-developed-by: Muchun Song <songmuchun@bytedance.com>
>> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
>> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>
>
> That metric's come up in our production environment recently as well,
> it makes a lot of sense.
>
> In addition to outside competition, this also applies to downtimes
> enforced by cpu.max - another cgroup usecase that is worth mentioning
> in the changelog & code comment.
Thank you, I will add this and send patch-v2.
> Thanks
prev parent reply other threads:[~2021-02-09 1:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-07 7:24 Chengming Zhou
2021-02-08 18:18 ` Johannes Weiner
2021-02-09 1:49 ` Chengming Zhou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cb984f3-fb8b-df26-31a2-8a091213d87e@bytedance.com \
--to=zhouchengming@bytedance.com \
--cc=dietmar.eggemann@arm.com \
--cc=hannes@cmpxchg.org \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=songmuchun@bytedance.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®