From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Muchun Song <songmuchun@bytedance.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
john.ogness@linutronix.de,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [External] Re: [PATCH v2] printk: fix deadlock when kernel panic
Date: Wed, 10 Feb 2021 11:25:12 +0900 [thread overview]
Message-ID: <YCNECIizrMwtjAW2@jagdpanzerIV.localdomain> (raw)
In-Reply-To: <YCJKRnBXjTNWRBZ7@alley>
On (21/02/09 09:39), Petr Mladek wrote:
> > > So then this never re-inits the safe_read_lock?
>
> Yes, but it will also not cause the deadlock.
Right.
> I prefer this approach. It is straightforward because it handles
> read_lock the same way as logbuf_lock.
I'm fine with that approach, but this needs to be in the commit message.
Something like "lose printk_safe message when we think we will deadlock
on printk_safe flush".
-ss
next prev parent reply other threads:[~2021-02-10 2:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-06 5:41 Muchun Song
2021-02-08 6:38 ` Sergey Senozhatsky
2021-02-08 8:49 ` [External] " Muchun Song
2021-02-08 13:12 ` Sergey Senozhatsky
2021-02-08 15:40 ` Muchun Song
2021-02-09 8:39 ` Petr Mladek
2021-02-10 2:25 ` Sergey Senozhatsky [this message]
2021-02-09 9:19 ` Petr Mladek
2021-02-09 12:20 ` [External] " Muchun Song
2021-02-10 2:16 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCNECIizrMwtjAW2@jagdpanzerIV.localdomain \
--to=sergey.senozhatsky@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®