From: Al Viro <viro@zeniv.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: syzbot <syzbot+3d2c27c2b7dc2a94814d@syzkaller.appspotmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-kernel@vger.kernel.org, snovitoll@gmail.com,
syzkaller-bugs@googlegroups.com
Subject: Re: WARNING in iov_iter_revert (2)
Date: Sat, 20 Feb 2021 17:38:49 +0000 [thread overview]
Message-ID: <YDFJKR5uG1N+g9TL@zeniv-ca.linux.org.uk> (raw)
In-Reply-To: <CAHk-=wiEBTD884i-U9DU7aDdRxXuz66Q1r-rKTiJUzZoYFgp+g@mail.gmail.com>
On Sat, Feb 20, 2021 at 08:56:40AM -0800, Linus Torvalds wrote:
> Al,
> This is the "FIXME! Have Al check this!" case in do_tty_write(). You were
> in on that whole discussion, but we never did get to that issue...
>
> There are some subtle rules about doing the iov_iter_revert(), but what's
> the best way to do this properly? Instead of doing a copy_from_iter() and
> then reverting the part that didn't fit in the buffer, doing a
> non-advancing copy and then advancing the amount that did fit, or what?
>
> I still don't have power, so this is all me on mobile with html email
> (sorry), and limited ability to really look closer.
>
> "Help me, Albi-wan Viro, you're my only hope"
Will check... BTW, when you get around to doing pulls, could you pick
the replacement (in followup) instead of the first pull request for
work.namei? Jens has caught a braino in the last commit there...
next prev parent reply other threads:[~2021-02-20 17:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 16:18 syzbot
2021-02-20 14:25 ` syzbot
[not found] ` <CAHk-=wiEBTD884i-U9DU7aDdRxXuz66Q1r-rKTiJUzZoYFgp+g@mail.gmail.com>
2021-02-20 17:38 ` Al Viro [this message]
2021-02-20 17:40 ` [git pull] work.namei stuff (v2) Al Viro
2021-02-21 17:43 ` Linus Torvalds
2021-02-21 18:39 ` pr-tracker-bot
2021-02-20 19:29 ` WARNING in iov_iter_revert (2) Al Viro
2021-02-20 19:40 ` Al Viro
2021-02-21 0:45 ` Linus Torvalds
2021-02-21 8:37 ` Sabyrzhan Tasbolatov
2021-02-21 17:20 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDFJKR5uG1N+g9TL@zeniv-ca.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=snovitoll@gmail.com \
--cc=syzbot+3d2c27c2b7dc2a94814d@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®