mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Amrit Khera <amritkhera98@gmail.com>
Cc: lee.jones@linaro.org, arnd@arndb.de, kuba@kernel.org,
	mail@anirudhrb.com, ayush@disroot.org,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: wimax: Fix block comment style issue in stack.c
Date: Sun, 21 Feb 2021 14:05:49 +0100	[thread overview]
Message-ID: <YDJarRhaoA/WFIyd@kroah.com> (raw)
In-Reply-To: <20210219202524.14642-1-amritkhera98@gmail.com>

On Sat, Feb 20, 2021 at 01:55:25AM +0530, Amrit Khera wrote:
> This change fixes a checkpatch warning for "Block comments
> use * on subsequent lines".
> 
> Signed-off-by: Amrit Khera <amritkhera98@gmail.com>
> ---
>  drivers/staging/wimax/stack.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/wimax/stack.c b/drivers/staging/wimax/stack.c
> index ace24a6dfd2d..781426000015 100644
> --- a/drivers/staging/wimax/stack.c
> +++ b/drivers/staging/wimax/stack.c
> @@ -62,11 +62,12 @@ MODULE_PARM_DESC(debug,
>   * close to where the data is generated.
>   */
>  /*
> -static const struct nla_policy wimax_gnl_re_status_change[WIMAX_GNL_ATTR_MAX + 1] = {
> -	[WIMAX_GNL_STCH_STATE_OLD] = { .type = NLA_U8 },
> -	[WIMAX_GNL_STCH_STATE_NEW] = { .type = NLA_U8 },
> -};
> -*/
> + * static const struct nla_policy
> + * wimax_gnl_re_status_change[WIMAX_GNL_ATTR_MAX + 1] = {
> + *	[WIMAX_GNL_STCH_STATE_OLD] = { .type = NLA_U8 },
> + *	[WIMAX_GNL_STCH_STATE_NEW] = { .type = NLA_U8 },
> + * };
> + */

Why not just remove this variable entirely?  It's obviously not needed,
so just delete the thing.

thanks,

greg k-h

      reply	other threads:[~2021-02-21 13:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-19 20:25 Amrit Khera
2021-02-21 13:05 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YDJarRhaoA/WFIyd@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=amritkhera98@gmail.com \
    --cc=arnd@arndb.de \
    --cc=ayush@disroot.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=kuba@kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mail@anirudhrb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®