* [PATCH] staging: wimax: Fix block comment style issue in stack.c
@ 2021-02-19 20:25 Amrit Khera
2021-02-21 13:05 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Amrit Khera @ 2021-02-19 20:25 UTC (permalink / raw)
To: gregkh, lee.jones, arnd, kuba, mail, ayush
Cc: devel, linux-kernel, Amrit Khera
This change fixes a checkpatch warning for "Block comments
use * on subsequent lines".
Signed-off-by: Amrit Khera <amritkhera98@gmail.com>
---
drivers/staging/wimax/stack.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/wimax/stack.c b/drivers/staging/wimax/stack.c
index ace24a6dfd2d..781426000015 100644
--- a/drivers/staging/wimax/stack.c
+++ b/drivers/staging/wimax/stack.c
@@ -62,11 +62,12 @@ MODULE_PARM_DESC(debug,
* close to where the data is generated.
*/
/*
-static const struct nla_policy wimax_gnl_re_status_change[WIMAX_GNL_ATTR_MAX + 1] = {
- [WIMAX_GNL_STCH_STATE_OLD] = { .type = NLA_U8 },
- [WIMAX_GNL_STCH_STATE_NEW] = { .type = NLA_U8 },
-};
-*/
+ * static const struct nla_policy
+ * wimax_gnl_re_status_change[WIMAX_GNL_ATTR_MAX + 1] = {
+ * [WIMAX_GNL_STCH_STATE_OLD] = { .type = NLA_U8 },
+ * [WIMAX_GNL_STCH_STATE_NEW] = { .type = NLA_U8 },
+ * };
+ */
/*
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] staging: wimax: Fix block comment style issue in stack.c
2021-02-19 20:25 [PATCH] staging: wimax: Fix block comment style issue in stack.c Amrit Khera
@ 2021-02-21 13:05 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2021-02-21 13:05 UTC (permalink / raw)
To: Amrit Khera; +Cc: lee.jones, arnd, kuba, mail, ayush, devel, linux-kernel
On Sat, Feb 20, 2021 at 01:55:25AM +0530, Amrit Khera wrote:
> This change fixes a checkpatch warning for "Block comments
> use * on subsequent lines".
>
> Signed-off-by: Amrit Khera <amritkhera98@gmail.com>
> ---
> drivers/staging/wimax/stack.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/wimax/stack.c b/drivers/staging/wimax/stack.c
> index ace24a6dfd2d..781426000015 100644
> --- a/drivers/staging/wimax/stack.c
> +++ b/drivers/staging/wimax/stack.c
> @@ -62,11 +62,12 @@ MODULE_PARM_DESC(debug,
> * close to where the data is generated.
> */
> /*
> -static const struct nla_policy wimax_gnl_re_status_change[WIMAX_GNL_ATTR_MAX + 1] = {
> - [WIMAX_GNL_STCH_STATE_OLD] = { .type = NLA_U8 },
> - [WIMAX_GNL_STCH_STATE_NEW] = { .type = NLA_U8 },
> -};
> -*/
> + * static const struct nla_policy
> + * wimax_gnl_re_status_change[WIMAX_GNL_ATTR_MAX + 1] = {
> + * [WIMAX_GNL_STCH_STATE_OLD] = { .type = NLA_U8 },
> + * [WIMAX_GNL_STCH_STATE_NEW] = { .type = NLA_U8 },
> + * };
> + */
Why not just remove this variable entirely? It's obviously not needed,
so just delete the thing.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-21 13:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-19 20:25 [PATCH] staging: wimax: Fix block comment style issue in stack.c Amrit Khera
2021-02-21 13:05 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®